[jira] [Commented] (JCR-4458) When JcrRemotingServlet deployed on non-root context, AclResource Webdav request fails

2019-07-22 Thread Julian Reschke (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCR-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890690#comment-16890690
 ] 

Julian Reschke commented on JCR-4458:
-

I'd like first to understand why with JCR-4460 tests seems to pass once the 
init param is set - so this certainly looks as  "works as designed" to me 
(although I'm not happy with the design).

> When JcrRemotingServlet deployed on non-root context, AclResource Webdav 
> request fails
> --
>
> Key: JCR-4458
> URL: https://issues.apache.org/jira/browse/JCR-4458
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.18.2
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
>
> If {{org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet}} is 
> configured in a non-root web application, the contextPath of which is "/cms" 
> for example with the servletPath, "/server", then 
> {{javax.jcr.Session#importXML(...)}} fails from a JCR client based on 
> JCR/WebDAV. In other words, {{#importXML(...)}} fails from a JCR {{Session}} 
> using a repository which can be created like the following for JCR over 
> WebDAV:
> {code}
> String repositoryAddress = "http://localhost:8080/cms/server;;
> Jcr2davRepositoryFactory factory = new Jcr2davRepositoryFactory();
> Map params = new HashMap();
> params.put(JcrUtils.REPOSITORY_URI, repositoryAddress);
> Repository repository = factory.getRepository(params);
> // ...
> {code}
> It seems like that {{Session#importXML(...)}} call invokes an AclResource 
> Webdav request first on the specific resource path, but 
> {{org.apache.jackrabbit.webdav.jcr.version.report.JcrPrivilegeReport#init(DavResource,
>  ReportInfo)}} does not remove the contextPath, "/cms" for example, when 
> determining the resoucrePath.
> Unlike the {{JcrPrivilegeReport}}, 
> {{org.apache.jackrabbit.webdav.WebdavRequestImpl#getHrefLocator(String, 
> boolean)}} seems to remove the contextPath properly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (JCRVLT-342) File leak in ProjectBuilder.getPluginVersion()

2019-07-22 Thread Tobias Bocanegra (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCRVLT-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890618#comment-16890618
 ] 

Tobias Bocanegra commented on JCRVLT-342:
-

LGTM. [~kwin] can you commit in your PR? thanks.

> File leak in ProjectBuilder.getPluginVersion()
> --
>
> Key: JCRVLT-342
> URL: https://issues.apache.org/jira/browse/JCRVLT-342
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.0.5
>
>
> The file opened in 
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/201a0b871361a5372fc0a0d0e7a540e2debc5dca/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java#L129
>  is not properly closed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (JCRVLT-342) File leak in ProjectBuilder.getPluginVersion()

2019-07-22 Thread Tobias Bocanegra (JIRA) 


 [ 
https://issues.apache.org/jira/browse/JCRVLT-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tobias Bocanegra reassigned JCRVLT-342:
---

Assignee: Konrad Windszus

> File leak in ProjectBuilder.getPluginVersion()
> --
>
> Key: JCRVLT-342
> URL: https://issues.apache.org/jira/browse/JCRVLT-342
> Project: Jackrabbit FileVault
>  Issue Type: Bug
>  Components: package maven plugin
>Affects Versions: package-maven-plugin-1.0.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: package-maven-plugin-1.0.5
>
>
> The file opened in 
> https://github.com/apache/jackrabbit-filevault-package-maven-plugin/blob/201a0b871361a5372fc0a0d0e7a540e2debc5dca/src/test/java/org/apache/jackrabbit/filevault/maven/packaging/it/ProjectBuilder.java#L129
>  is not properly closed.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (JCR-4458) When JcrRemotingServlet deployed on non-root context, AclResource Webdav request fails

2019-07-22 Thread Woonsan Ko (JIRA) 


[ 
https://issues.apache.org/jira/browse/JCR-4458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890599#comment-16890599
 ] 

Woonsan Ko commented on JCR-4458:
-

Hi [~reschke],

Could you please review my PR?
- https://github.com/apache/jackrabbit/pull/84

I think {{JcrPrivilegeReport}} needs to convert the input href to any of these 
anyway:
# an absolute URL (e.g, {{http://localhost:8080/cms/server/default/jcr:root}}),
# a context relative path (e.g, {{/server/default/jcr:root}}),
# or just a JCR resource path (e.g, {{/default/jcr:root}}).

The third option seems best to me, and it seems to fix the problem case.

Regards,

Woonsan

> When JcrRemotingServlet deployed on non-root context, AclResource Webdav 
> request fails
> --
>
> Key: JCR-4458
> URL: https://issues.apache.org/jira/browse/JCR-4458
> Project: Jackrabbit Content Repository
>  Issue Type: Bug
>Affects Versions: 2.18.2
>Reporter: Woonsan Ko
>Assignee: Julian Reschke
>Priority: Major
>
> If {{org.apache.jackrabbit.server.remoting.davex.JcrRemotingServlet}} is 
> configured in a non-root web application, the contextPath of which is "/cms" 
> for example with the servletPath, "/server", then 
> {{javax.jcr.Session#importXML(...)}} fails from a JCR client based on 
> JCR/WebDAV. In other words, {{#importXML(...)}} fails from a JCR {{Session}} 
> using a repository which can be created like the following for JCR over 
> WebDAV:
> {code}
> String repositoryAddress = "http://localhost:8080/cms/server;;
> Jcr2davRepositoryFactory factory = new Jcr2davRepositoryFactory();
> Map params = new HashMap();
> params.put(JcrUtils.REPOSITORY_URI, repositoryAddress);
> Repository repository = factory.getRepository(params);
> // ...
> {code}
> It seems like that {{Session#importXML(...)}} call invokes an AclResource 
> Webdav request first on the specific resource path, but 
> {{org.apache.jackrabbit.webdav.jcr.version.report.JcrPrivilegeReport#init(DavResource,
>  ReportInfo)}} does not remove the contextPath, "/cms" for example, when 
> determining the resoucrePath.
> Unlike the {{JcrPrivilegeReport}}, 
> {{org.apache.jackrabbit.webdav.WebdavRequestImpl#getHrefLocator(String, 
> boolean)}} seems to remove the contextPath properly.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Oak 1.16.0 Release Plan (was: Jackrabbit 1.16.0 Release Plan)

2019-07-22 Thread Julian Reschke 

(subject line fixed :-)

Hi,

I'd like to cut Oak 1.16.0 on Wednesday.

The list of open issues scheduled for 1.16.0 has *167* issues:

https://issues.apache.org/jira/issues?jql=fixVersion%20%3D%201.16.0%20AND%20project%20%3D%20OAK%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC

I *assume* that these can be-rescheduled to 1.18.0 (or unscheduled), but 
it would be good if everybody did a sanity check.


I will reschedule remaining issues tomorrow and then prepare the 
candidate release notes.


If there are any objections please let me know.

Best regards, Julian

Jackrabbit 1.16.0 Release Plan

2019-07-22 Thread Julian Reschke 

Hi,

I'd like to cut Oak 1.16.0 on Wednesday.

The list of open issues scheduled for 1.16.0 has *167* issues:

https://issues.apache.org/jira/issues?jql=fixVersion%20%3D%201.16.0%20AND%20project%20%3D%20OAK%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC

I *assume* that these can be-rescheduled to 1.18.0 (or unscheduled), but 
it would be good if everybody did a sanity check.


I will reschedule remaining issues tomorrow and then prepare the 
candidate release notes.


If there are any objections please let me know.

Best regards, Julian