[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343442#comment-16343442 ] Alex Deparvu commented on JCR-4249: --- it would be a good time, yes :) I was hoping to get JCR-4246 in the discussion, possibly have an early release where we can still fix things if something breaks, but did not have the time. definitely having a release available would benefit Oak, so I would prefer a release with only the api changes now, if you have the spare cycles. > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.18, 2.17.1 > > Attachments: JCR-4249-v2.patch, JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343394#comment-16343394 ] Julian Reschke commented on JCR-4249: - Thanks, [~stillalex]. So now would be a good time for a release, right? > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.18, 2.17.1 > > Attachments: JCR-4249-v2.patch, JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[
https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16336047#comment-16336047
]
angela commented on JCR-4249:
-
[~stillalex], the patch looks good to me. just one minor thing i noticed in
{{GroupPrincipal.members()}}: the {{isMember}} method is explicitly specified
to evaluate _inherited_ membership. does this also apply to
{{GroupPrincipal.members()}}? in other words: is {{GroupPrincipal.members()}}
the complete enumeration of principals for which {{isMember}} returns true?
> Introduce replacement for java.security.acl.Group
> -
>
> Key: JCR-4249
> URL: https://issues.apache.org/jira/browse/JCR-4249
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: JCR API, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Major
> Fix For: 2.17.1
>
> Attachments: JCR-4249-v2.patch, JCR-4249.patch
>
>
> See OAK-7024 and JCR-4246 for more information.
> I've decided to split off the api changes to have them in early for a release
> so both projects could use the same class as replacement of the Group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332199#comment-16332199 ] Julian Reschke commented on JCR-4249: - LGTM. > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.17.1 > > Attachments: JCR-4249-v2.patch, JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16332029#comment-16332029 ] Alex Deparvu commented on JCR-4249: --- attached v2 [^JCR-4249-v2.patch]. hope I've clarified things a bit. it's very important to spend some time on the javadocs, otherwise people will be pretty confused by this change, so please adjust if necessary! > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.17.1 > > Attachments: JCR-4249-v2.patch, JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331938#comment-16331938 ] Alex Deparvu commented on JCR-4249: --- bq. If this was entirely new, I'd replace isMember by isMemberOf, but we want to keep the change as simple as possible, right? yeah, I'm not a big fan of the enumeration either, but the focus should really be on having as few changes as possible. bq. I would mention in the javadoc of PrincipalManager that it used to be java.security.acl.Group and when + why this has been adjusted... as long as it's not remove implementations might have prinicipals that implement both interfaces for backwards compatibility agreed. I'll attach an updated version. > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.17.1 > > Attachments: JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[
https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16331333#comment-16331333
]
angela commented on JCR-4249:
-
[~stillalex], the patch looks good to me... the only thing that we might want
to add: I would mention in the javadoc of {{PrincipalManager}} that it used to
be {{java.security.acl.Group}} and when + why this has been adjusted... as long
as it's not remove implementations might have prinicipals that implement both
interfaces for backwards compatibility. wdyt?
> Introduce replacement for java.security.acl.Group
> -
>
> Key: JCR-4249
> URL: https://issues.apache.org/jira/browse/JCR-4249
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: JCR API, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Major
> Fix For: 2.17.1
>
> Attachments: JCR-4249.patch
>
>
> See OAK-7024 and JCR-4246 for more information.
> I've decided to split off the api changes to have them in early for a release
> so both projects could use the same class as replacement of the Group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[
https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330637#comment-16330637
]
Julian Reschke commented on JCR-4249:
-
Looks good, and +1 on separating out the API change.
If this was entirely new, I'd replace {{isMember}} by {{isMemberOf}}, but we
want to keep the change as simple as possible, right?
> Introduce replacement for java.security.acl.Group
> -
>
> Key: JCR-4249
> URL: https://issues.apache.org/jira/browse/JCR-4249
> Project: Jackrabbit Content Repository
> Issue Type: Improvement
> Components: JCR API, security
>Reporter: Alex Deparvu
>Assignee: Alex Deparvu
>Priority: Major
> Fix For: 2.17.1
>
> Attachments: JCR-4249.patch
>
>
> See OAK-7024 and JCR-4246 for more information.
> I've decided to split off the api changes to have them in early for a release
> so both projects could use the same class as replacement of the Group.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330609#comment-16330609 ] Alex Deparvu commented on JCR-4249: --- ah yes, sorry about that :) should be good now > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API, security >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Fix For: 2.17.1 > > Attachments: JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4249) Introduce replacement for java.security.acl.Group
[ https://issues.apache.org/jira/browse/JCR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330568#comment-16330568 ] Alex Deparvu commented on JCR-4249: --- Attaching proposed patch, needed for future refactoring. [~anchela], [~reschke] would appreciate your votes on this one. As soon as we have a release of the apis, we can unblock Oak. > Introduce replacement for java.security.acl.Group > - > > Key: JCR-4249 > URL: https://issues.apache.org/jira/browse/JCR-4249 > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: JCR API >Reporter: Alex Deparvu >Assignee: Alex Deparvu >Priority: Major > Attachments: JCR-4249.patch > > > See OAK-7024 and JCR-4246 for more information. > I've decided to split off the api changes to have them in early for a release > so both projects could use the same class as replacement of the Group. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
