[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-22 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16588519#comment-16588519 ] Alexander Klimetschek commented on JCR-4355: Latest patch: * [^JCR-4355-v3.patch] *

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-10 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576874#comment-16576874 ] Alexander Klimetschek commented on JCR-4355: Thanks for the review. It would actually be nice

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-10 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576173#comment-16576173 ] Julian Reschke commented on JCR-4355: - Question about "Some storage providers also support multi-part

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-10 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576167#comment-16576167 ] Julian Reschke commented on JCR-4355: - [^JCR-4355-jr.diff] * attempts to clarify the charset issue *

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575761#comment-16575761 ] Julian Reschke commented on JCR-4355: - Listing all of course is impossible. I just want to avoid

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575757#comment-16575757 ] Alexander Klimetschek commented on JCR-4355: How complete does the description have to be here?

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575755#comment-16575755 ] Julian Reschke commented on JCR-4355: - "Changed "text-based" to "character-based"" - that's still

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575334#comment-16575334 ] Alexander Klimetschek commented on JCR-4355: To make it easier to review, I attached generated

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Alexander Klimetschek (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575325#comment-16575325 ] Alexander Klimetschek commented on JCR-4355: Thanks for the feedback! Here is an updated

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574814#comment-16574814 ] Julian Reschke commented on JCR-4355: - Early feedback: - please avoid re-adding text that suggests

[jira] [Commented] (JCR-4355) Javadoc fixes and improvements for new direct binary access API

2018-08-09 Thread Julian Reschke (JIRA)
[ https://issues.apache.org/jira/browse/JCR-4355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574801#comment-16574801 ] Julian Reschke commented on JCR-4355: - Alex' proposed patch: