[jira] [Commented] (JCR-4444) Add nullable/notnull annotations for jackrabbit security API extensions
[ https://issues.apache.org/jira/browse/JCR-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856792#comment-16856792 ] angela commented on JCR-: - [~reschke]... ok... but i can also way a bit... whatever is better. there is no real pressure, i just find it confusing not to have the annotations. > Add nullable/notnull annotations for jackrabbit security API extensions > --- > > Key: JCR- > URL: https://issues.apache.org/jira/browse/JCR- > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-api >Reporter: angela >Assignee: angela >Priority: Major > > due to the missing nullable/notnull annotations and unspecific javadoc it's > not always clear, if null params are allow and if null return values should > be expected. adding the missing annotations will IMO clarify the API contract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4444) Add nullable/notnull annotations for jackrabbit security API extensions
[ https://issues.apache.org/jira/browse/JCR-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856386#comment-16856386 ] Julian Reschke commented on JCR-: - FWIW, I just noticed that we already have nullability annotations in the subproject (forgot about that). So go ahead if you like, [~angela]. > Add nullable/notnull annotations for jackrabbit security API extensions > --- > > Key: JCR- > URL: https://issues.apache.org/jira/browse/JCR- > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-api >Reporter: angela >Assignee: angela >Priority: Major > > due to the missing nullable/notnull annotations and unspecific javadoc it's > not always clear, if null params are allow and if null return values should > be expected. adding the missing annotations will IMO clarify the API contract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4444) Add nullable/notnull annotations for jackrabbit security API extensions
[ https://issues.apache.org/jira/browse/JCR-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849651#comment-16849651 ] Julian Reschke commented on JCR-: - The proposal (as discussed on the mailing list) was: once Oak 1.14.0 is released (~2 weeks from now). > Add nullable/notnull annotations for jackrabbit security API extensions > --- > > Key: JCR- > URL: https://issues.apache.org/jira/browse/JCR- > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-api >Reporter: angela >Assignee: angela >Priority: Major > > due to the missing nullable/notnull annotations and unspecific javadoc it's > not always clear, if null params are allow and if null return values should > be expected. adding the missing annotations will IMO clarify the API contract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4444) Add nullable/notnull annotations for jackrabbit security API extensions
[ https://issues.apache.org/jira/browse/JCR-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849646#comment-16849646 ] angela commented on JCR-: - i guess that depends on when the convert is going to happen > Add nullable/notnull annotations for jackrabbit security API extensions > --- > > Key: JCR- > URL: https://issues.apache.org/jira/browse/JCR- > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-api >Reporter: angela >Priority: Major > > due to the missing nullable/notnull annotations and unspecific javadoc it's > not always clear, if null params are allow and if null return values should > be expected. adding the missing annotations will IMO clarify the API contract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (JCR-4444) Add nullable/notnull annotations for jackrabbit security API extensions
[ https://issues.apache.org/jira/browse/JCR-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849645#comment-16849645 ] Julian Reschke commented on JCR-: - Can this wait until we have converted jackrabbit-api to an Oak project? > Add nullable/notnull annotations for jackrabbit security API extensions > --- > > Key: JCR- > URL: https://issues.apache.org/jira/browse/JCR- > Project: Jackrabbit Content Repository > Issue Type: Improvement > Components: jackrabbit-api >Reporter: angela >Priority: Major > > due to the missing nullable/notnull annotations and unspecific javadoc it's > not always clear, if null params are allow and if null return values should > be expected. adding the missing annotations will IMO clarify the API contract. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
