[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12420309 ]
angela commented on JCR-473:
oh. i can help you if you want me to.
apart from the deprecated calls, it would be nice to have all the hardcoded
index (0, 1), the depth and the name o
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419739 ]
Stefan Guggisberg commented on JCR-473:
---
+1 for 2nd patch from me as well
> Some enhancements to jackrabbit commons
> ---
>
> K
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419685 ]
Tobias Bocanegra commented on JCR-473:
--
besides some javadoc errors, the patch looks ok.
+1 for patch V2
> Some enhancements to jackrabbit commons
> ---
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419466 ]
Tobias Bocanegra commented on JCR-473:
--
> i guess you responded to a post, which gmail considered to be written by
> jukka...
> hehthey start getting subversive... it w
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419464 ]
Stefan Guggisberg commented on JCR-473:
---
> Julian Reschke commented on JCR-473:
>
>
> Regarding QName...:
>
> Did anybody consider to
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419462 ]
Jukka Zitting commented on JCR-473:
---
Julian:
> Did anybody consider to require JAXP 1.3 (available as seperate download for
> JDK 1.4), and just to use javax.xml.namespace.QNam
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419461 ]
angela commented on JCR-473:
Tobi:
> but i ment 'jukka'. it was a response to your post :-)
i guess you responded to a post, which gmail considered to be written by
jukka... heh..
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419460 ]
Marcel Reutegger commented on JCR-473:
--
Yes, I did, but the JCR QName are different from an XML QName. E.g. in JCR you
may start a name with a digit, which is not possible i
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419458 ]
Julian Reschke commented on JCR-473:
Regarding QName...:
Did anybody consider to require JAXP 1.3 (available as seperate download for
JDK 1.4), and just to use javax.xml.nam
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419456 ]
Jukka Zitting commented on JCR-473:
---
Tobias:
> but i ment 'jukka'. it was a response to your post :-)
Ah, OK. Just got confused as I didn't mention anything about ValueFactori
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419453 ]
Tobias Bocanegra commented on JCR-473:
--
> Tobias:
> > jukka, you're right
>
> It was Angela, credit where credit is due. :-)
but i ment 'jukka'. it was a response to your po
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419447 ]
angela commented on JCR-473:
and for the latter (modifications within core classes) i suggested 2 solutions
from the top of my head (because i was thinking about this before). if you
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419446 ]
angela commented on JCR-473:
a bit? i'm angela not jukka... unfortunately ;)
> i would put all convertion code into ValueHelper, and
> ValueFactoryImpl and InternalValue can then ma
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419445 ]
Jukka Zitting commented on JCR-473:
---
Tobias:
> jukka, you're right
It was Angela, credit where credit is due. :-)
I think you're right about questioning the excessive passing
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419443 ]
Tobias Bocanegra commented on JCR-473:
--
sorry. i'm a bit dizzy today:
- this was just a first ides but you're right.
+ this was just a first idea but you're right.
- somewh
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419439 ]
Tobias Bocanegra commented on JCR-473:
--
jukka, you're right. ValueFactory has nothing to do with resolving names.
> moving the InternalValue.create to the ValueHelper looks
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419425 ]
angela commented on JCR-473:
2. So, not passing the ValueFactory throughout the code, could be solved by:
- leave InternalValue as proposed in the patch
- remove usage of InternalVa
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419419 ]
angela commented on JCR-473:
InternalValue:
> we should find something nicer. for example, drop the to methods
> that take the nsresolver:
maybe i'm missing your point. from my po
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419318 ]
Tobias Bocanegra commented on JCR-473:
--
> consequently:
> - modify signature of InternalValue.create that include a value conversion to
> take a
> ValueFactory param and ad
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419300 ]
Stefan Guggisberg commented on JCR-473:
---
+1 for applying the patch
cheers
stefan
> Some enhancements to jackrabbit commons
> ---
>
>
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419218 ]
Jukka Zitting commented on JCR-473:
---
Angela:
> regarding interfaces for Path, QName:
Ah, sorry for being a bit unclear. I'd still keep them as concrete classes,
preferably fin
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419217 ]
angela commented on JCR-473:
regarding interfaces for Path, QName:
i used to have interfaces for them and keep the implementation in commons. but
i felt that the impact on the existi
[
http://issues.apache.org/jira/browse/JCR-473?page=comments#action_12419056 ]
Jukka Zitting commented on JCR-473:
---
+1, I especially like the approach of separating responsibilities from QName
and Path.
Would it make sense to go even further along this w
23 matches
Mail list logo
