[GitHub] jena pull request #176: Minor cleanup

2016-10-21 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r84549447 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java --- @@ -111,8 +110,6 @@ protected JsonValue

[jira] [Commented] (JENA-1243) Remove cruft from JDBC modules

2016-10-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-1243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595893#comment-15595893 ] ASF GitHub Bot commented on JENA-1243: -- GitHub user afs opened a pull request:

[GitHub] jena pull request #182: JENA-1243: Clean up POMs for jena-jdbc

2016-10-21 Thread afs
GitHub user afs opened a pull request: https://github.com/apache/jena/pull/182 JENA-1243: Clean up POMs for jena-jdbc 1. Remove com.mycila.maven-license-plugin including deleting the file to check against (license-header.txt) . 1. Remove version settings on pluging - pick up

[GitHub] jena pull request #176: Minor cleanup

2016-10-21 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r84518062 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionDatasets.java --- @@ -111,8 +110,6 @@ protected JsonValue

[GitHub] jena pull request #176: Minor cleanup

2016-10-21 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r84518192 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/validation/DataValidator.java --- @@ -102,7 +102,8 @@ protected String

[GitHub] jena pull request #176: Minor cleanup

2016-10-21 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r84518512 --- Diff: jena-base/src/test/java/org/apache/jena/atlas/io/AbstractTestPeekInputStream.java --- @@ -153,7 +152,7 @@ @Test public void unread3()

[GitHub] jena issue #176: Minor cleanup

2016-10-21 Thread ajs6f
Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/176 I think I addressed the comments given here in that last commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jena pull request #176: Minor cleanup

2016-10-21 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/176#discussion_r84510072 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/async/AsyncPool.java --- @@ -53,7 +53,7 @@ public AsyncTask submit(Runnable task,

Re: tdbloader2 hex files

2016-10-21 Thread Andy Seaborne
Sorting hex can be done by string comparison : A-F > 0-9 in ASCII. With enough padding so can decimal but hex is natural. The loader needs some kind of external sort - ideally it would be based on binary. sort(1) is widely available and handles all the spill-merge work. It is well-tried in a

Re: running TDB tests?

2016-10-21 Thread Andy Seaborne
Several module have "testing/" directories. They are for any one the test wants to work from files, including the W3C test manifest. bin-test/ are old scripts to help run helpers used during development. I doubt they work (cmd/classpath changes) but they do record knowledge. Andy On

[GitHub] jena pull request #181: SORT_ARGS behavior

2016-10-21 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/181#discussion_r84507839 --- Diff: apache-jena/bin/tdbloader2index --- @@ -150,7 +150,9 @@ LOC= KEEP_WORK=0 DEBUG=0 JVM_ARGS= -SORT_ARGS= --- End diff --

[GitHub] jena pull request #181: SORT_ARGS behavior

2016-10-21 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/jena/pull/181#discussion_r84507635 --- Diff: apache-jena/bin/tdbloader2index --- @@ -150,7 +150,9 @@ LOC= KEEP_WORK=0 DEBUG=0 JVM_ARGS= -SORT_ARGS= --- End diff -- Can

[GitHub] jena pull request #181: SORT_ARGS behavior

2016-10-21 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/181 SORT_ARGS behavior Allow env variable SORT_ARGS to be used for multiflag sort args Do not override parallel flag if it is set on CLI in --sort-args or in env SORT_ARGS You can merge this pull

running TDB tests?

2016-10-21 Thread A. Soroka
Looking in TDB's source, I see folders bin-test and testing, which seem to contain testing scripts and manifests and data. I was wondering how to run these? I can't seem to find a place to begin. {grin} --- A. Soroka The University of Virginia Library

Re: tdbloader2 hex files

2016-10-21 Thread A. Soroka
Looks like tdbloader2 is currently using a nice non-Unicode locale, so that's covered. https://github.com/apache/jena/blob/master/apache-jena/bin/tdbloader2index#L146 --- A. Soroka The University of Virginia Library > On Oct 21, 2016, at 9:22 AM, Stian Soiland-Reyes wrote: >