[GitHub] jena pull request #358: JENA-1484: Correcting behavior in ApplyElementTransf...

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/358 JENA-1484: Correcting behavior in ApplyElementTransformVisitor You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-1484 Alternatively

Re: [08/10] jena git commit: Merge branch 'master' into FixGraphContractTestTransactionUsage

genuinely useful info. ajs6f > On Feb 8, 2018, at 9:51 AM, Andy Seaborne <a...@apache.org> wrote: > > Claude, > > I think using "git rebase" rather than "git merge" would have made this > cleaner. Rebase undoes the differences, merges

Re: merging pull requests

merges (as Claude was just expecting to do) and the repo would get mirrored back to Apache. The cost would be that we lose our current convenient Jira integration, although INFRA is aware of that and is interested in working on that problem. ajs6f > On Feb 7, 2018, at 10:37 AM, Andy Seabo

Re: CMS diff: Jena RDF/XML How-To

Committed, thank you! ajs6f > On Feb 6, 2018, at 11:46 AM, Ian Dunlop <anonym...@apache.org> wrote: > > Clone URL (Committers only): > https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Fio%2Frdfxml_howto.mdtext > > Ian

Re: Building with Java9

... ajs6f > On Feb 6, 2018, at 2:57 AM, Lorenz B. <conpcompl...@googlemail.com> wrote: > > Well, I read about this some time ago and was wondering how many people > are really aware of the fact that no more security updates will be > delivered 6 month after the release of a new

Re: Building with Java9

Works for me. I think it's good to take as many steps as we can to do this (= make each one as small as we can). ajs6f > On Feb 6, 2018, at 8:00 AM, Andy Seaborne <a...@apache.org> wrote: > > Would there be any problems if the plugin settings for a building wither > Java9 we

Re: Building with Java9

Ditto (haven't been paying much attention). A six month cycle is pretty fast, in some ways. At least it will be if we have to do a lot of work for each version. ajs6f > On Feb 5, 2018, at 11:34 AM, Andy Seaborne <a...@apache.org> wrote: > > I hadn't grok'ed (or, to be honest,

Re: Welcome Chris!

Amen! I'm looking forward to your next PR! ajs6f > On Feb 1, 2018, at 3:40 AM, Osma Suominen <osma.suomi...@helsinki.fi> wrote: > > Welcome Chris! Great to have you as a committer. You've done excellent work > on jena-text recently. > > -Osma > > > Andy Sea

[GitHub] jena pull request #349: Cleanup comments and code around txn

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/349#discussion_r164806834 --- Diff: jena-tdb/src/main/java/org/apache/jena/tdb/store/GraphNonTxnTDB.java --- @@ -32,25 +34,58 @@ * @see GraphTxnTDB */ public class

Re: FILTER EXISTS evaluation of different triple stores

There is a W3C Community Group discussing related issues, chaired by Andy. Unfortunately, I think progress has stalled on disagreements as to the best road forward. ajs6f > On Jan 28, 2018, at 5:56 AM, Lorenz B. <conpcompl...@googlemail.com> wrote: > > Hi all, >

Re: riot/jena - limiting CPU and memory usage

-intensive output format. ajs6f > On Jan 19, 2018, at 4:14 PM, Erman Korkut (BLOOMBERG/ 120 PARK) > <ekork...@bloomberg.net> wrote: > > Hi all, > > I was running riot to generate ttl files with 50+ millions triples in it in a > production machine and it took over the entir

[GitHub] jena issue #339: resolve JENA-1459 add jena text highlighting

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/339 That is one prob with using the Github on-line editors. But they _are_ convenient! I use them for corrections to human-centric docs like READMEs, etc. ---

[GitHub] jena issue #339: resolve JENA-1459 add jena text highlighting

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/339 Relax-- it's not nearly as bad as all that. :grin: I often say that having to rebase PRs a lot is good-- it means the project is lively and the code is evolving. For me, the trick (as almost

[GitHub] jena issue #339: resolve JENA-1459 add jena text highlighting

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/339 Cool. That's essentially an in-line version of the same workflow, minus the rebase. That means you end up with an extra no-real-content commit (https://github.com/apache/jena/pull/339/commits

[GitHub] jena issue #339: resolve JENA-1459 add jena text highlighting

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/339 It's no big deal-- happens all the time! Do you know how to rebase and resolve conflicts in Git? https://help.github.com/articles/resolving-merge-conflicts-after-a-git-rebase/ https

Re: PROV vocabulary class

involved and instead use ResourceFactory. ajs6f > On Jan 7, 2018, at 8:09 PM, Adam Jacobs <jacobs_...@hotmail.com> wrote: > > Is it a good idea to have a public mutable model? > > > > > From: Cotton Franck <franck.cot...@in

Re: PROV vocabulary class

This list doesn't permit attachments. Can you please send your work as a PR on Github, or failing that, as a gist or pastebin or the like? Adam Soroka > On Jan 7, 2018, at 12:00 PM, Cotton Franck wrote: > > Hello > > For my own needs, I created this class

[GitHub] jena issue #338: Removing very old deprecated types

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/338 I'll get something in Jira, for sure, and I'll wait to merge this to hear from @Claudenw . ---

[GitHub] jena pull request #338: Removing very old deprecated types

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/338 Removing very old deprecated types Just some cleanup in `jena-base` and `jena-core`. All of the few types being removed have been publicly deprecated for at least two years. You can merge this pull

[GitHub] jena issue #337: JENA-1391: Dataset dyadic views, Model and Dataset Stream c...

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/337 I'll let this hang out until EOD today in case anyone else wants to opine. Happy new year everyone! ---

[GitHub] jena pull request #336: JENA-1458: Transaction promotion

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/336#discussion_r159748796 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -146,25 +162,84 @@ private void _begin(ReadWrite readWrite

[GitHub] jena pull request #336: JENA-1458: Transaction promotion

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/336#discussion_r159729634 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -146,25 +162,84 @@ private void _begin(ReadWrite readWrite

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159529387 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java --- @@ -37,6 +40,30 @@ public A car() { return a ; } public B cdr

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159528705 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java --- @@ -199,13 +193,12 @@ public long getLong(Symbol symbol, long defaultValue

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159527929 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena issue #335: Jena 1453 reduce docs

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/335 @xristy That's what I meant-- I didn't mean to suggest an in-place op, sorry. ---

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159261113 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java --- @@ -37,6 +40,30 @@ public A car() { return a ; } public B cdr

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159255082 --- Diff: jena-arq/src/main/java/org/apache/jena/query/util/DatasetCollector.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159252897 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159252167 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159251828 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java --- @@ -37,6 +40,30 @@ public A car() { return a ; } public B cdr

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159251422 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159251106 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159251025 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java --- @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159250915 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java --- @@ -199,13 +193,12 @@ public long getLong(Symbol symbol, long defaultValue

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/337#discussion_r159250681 --- Diff: jena-arq/src/main/java/org/apache/jena/query/util/DatasetCollector.java --- @@ -0,0 +1,125 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request #336: JENA-1458: Transaction promotion

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/336#discussion_r159162581 --- Diff: jena-arq/src/main/java/org/apache/jena/query/TxnType.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] jena pull request #336: JENA-1458: Transaction promotion

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/336#discussion_r159162566 --- Diff: jena-arq/src/main/java/org/apache/jena/query/TxnType.java --- @@ -0,0 +1,77 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] jena pull request #337: JENA-1391: Dataset dyadic views, Model and Dataset S...

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/337 JENA-1391: Dataset dyadic views, Model and Dataset Stream collectors This is a bit preliminary-- probably needs some more tests. But I wanted to get it out there for early comments so I can take them

Re: TDB Graph usage question

TIM uses a subclass of GraphView called GraphInMemory which is indeed also stateless. ajs6f > On Dec 30, 2017, at 5:54 AM, Andy Seaborne <a...@apache.org> wrote: > > Have you tried TDB2 and TIM yet? > > On 30/12/17 00:09, Claude Warren wrote: >> When I tried t

Re: CMS diff: Command-line and other tools for Jena developers

Committed, thanks! ajs6f > On Dec 27, 2017, at 8:04 PM, Albert Min <anonym...@apache.org> wrote: > > Clone URL (Committers only): > https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Ftools%2Findex.mdtext > > Albert Min &

Re: RDF Diff/patch

both triples and add a new one, or just remove a triple, and if so, is that deterministic? If dataset2 is instead: _:a a my:type . will the algorithm only remove one triple and be done, or remove both and add a new one? ajs6f > On Dec 27, 2017, at 11:00 AM, Andy Seaborne <a...@apac

Re: CMS diff: Security in Fuseki2

Committed, thanks! ajs6f > On Dec 21, 2017, at 11:32 AM, Adrian Gschwend <anonym...@apache.org> wrote: > > Clone URL (Committers only): > https://cms.apache.org/redirect?new=anonymous;action=diff;uri=http://jena.apache.org/documentation%2Ffuseki2%2Ffuseki-security.mdtext &g

[GitHub] jena pull request #332: JENA-1452: GraphUnionRead; Union of one.

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/332#discussion_r158302470 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphUnionRead.java --- @@ -82,16 +94,29 @@ protected PrefixMapping createPrefixMapping

[GitHub] jena pull request #332: JENA-1452: GraphUnionRead; Union of one.

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/332#discussion_r158292354 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphUnionRead.java --- @@ -82,16 +94,29 @@ protected PrefixMapping createPrefixMapping

[GitHub] jena pull request #333: JENA-1451: "contains" for special graphs

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/333#discussion_r158256408 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/core/AbstractTestDataset.java --- @@ -116,4 +116,24 @@ ds.addNamedModel(graphName, model1

Re: Jira and Gitbox integration?

. Also, a detail: reversing the mirroring from what we have now would mean that commits could go to _either_ gitbox or Github, which is nice. ajs6f Adam Soroka (ajs6f) 9:27 AM Hi, INFRA-folks! I'm from Apache Jena, and we've got a question or two about Gitbox and possible arrangements between

Re: Jira and Gitbox integration?

, but is there a protocol about bugging INFRA? If an email goes unanswered for several weeks, better to email again or better to file a ticket on INFRA asking for info? ajs6f > On Dec 17, 2017, at 11:28 AM, Andy Seaborne <a...@apache.org> wrote: > > Any news? > > Even after reading aroun

Re: potential new API Was: Immutability

/jena/compare/master...ajs6f:JENA-1391 ajs6f > On Dec 17, 2017, at 8:15 PM, Adam Jacobs <jacobs_...@hotmail.com> wrote: > > I just want to mention that it was not my intent to derail progress on > Jena-1391 (https://issues.apache.org/jira/browse/JENA-1391) by raising the >

Re: consistent blank id values from RDFConnection

> On Dec 18, 2017, at 8:17 AM, Andy Seaborne <a...@apache.org> wrote: > On 17/12/17 16:35, ajs6f wrote: >> >> I think offering configurability is a good middle ground. Claude-- does that >> ARQ option meet your needs? >> Andy-- do you think pulling all the

[GitHub] jena pull request #331: JENA-1450: fn:error

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/331#discussion_r157378417 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/function/library/FN_Error.java --- @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software

[GitHub] jena issue #329: Give more time to ElasticSearch to startup

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/329 Ah, I think I figured it out-- for future reference, this seems to happen when you merge a branch into `master` and push it, but the branch on Github isn't up to date with the local repo. Okay, I should

[GitHub] jena pull request #329: Give more time to ElasticSearch to startup

Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/329 ---

[GitHub] jena issue #329: Give more time to ElasticSearch to startup

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/329 Dang it! This is the second time this has happened. I've been merging my PR branches into `master` and then pushing them. It normally works fine... I need to figure out what's nutty on my end

Re: Jena-1427 - nextOptional()

every possible syntactic convenience. (This ain't Scala! :wink:) ajs6f > On Dec 17, 2017, at 2:18 PM, Claude Warren <cla...@xenei.com> wrote: > > From the original request it seems the requirements were: > 1. return a default value if the iterator is empty. > 2. throw a cus

Re: consistent blank id values from RDFConnection

? In that case, the API seems a bit more complex, because it's something that could arise outside of ARQ, so maybe a static setting is better (than a Symbol in Contexts). ajs6f > On Dec 17, 2017, at 11:36 AM, Andy Seaborne <a...@apache.org> wrote: > > I was hoping we'd change it

Re: consistent blank id values from RDFConnection

more "fine-grained" than static settings, and can vary within an app more easily. ajs6f > On Dec 17, 2017, at 11:29 AM, Adam Jacobs <jacobs_...@hotmail.com> wrote: > > You're right, that section does seem conclusive, at leas

Re: consistent blank id values from RDFConnection

t maintaining bnode labeling is a normal part of using SPARQL, when it isn't-- it's something extra that Jena provides. If there's no reason this is an undocumented feature, I'm going to document it at: https://jena.apache.org/documentation/query/app_api.html ajs6f > On Dec 17, 2017, a

Re: consistent blank id values from RDFConnection

That is useful, and it's undocumented. Is that because it is dangerous (in the sense in which you used the phrase "dubious in terms of spec compliance") or just because we never have documented it? ajs6f > On Dec 17, 2017, at 10:43 AM, Andy Seaborne <a...@a

Re: consistent blank id values from RDFConnection

Where? I found nothing documented. ajs6f > On Dec 17, 2017, at 10:38 AM, Andy Seaborne <a...@apache.org> wrote: > > On 17/12/17 15:19, ajs6f wrote: >> Claude-- I'm looking at RDFConnection, but it's an interface. I think you >> mean around L220 of JSONInput itse

Re: consistent blank id values from RDFConnection

method to use. At L195 it uses SyntaxLabels.createLabelToNode(). We could thread such a mapping choice all the way through the call stack, but that seems a bit difficult to me. Maybe we could introduce a Context setting for this purpose? ajs6f > On Dec 17, 2017, at 9:28 AM, Claude Warren &

Re: [VOTE] Apache Jena 3.6.0 RC1

Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.12.6", arch: "x86_64", family: "mac" ajs6f > On Dec 16, 2017, at 6:55 PM, Bruno P. Kinoshita > <brunodepau...@yahoo.com.br.INVALID> wrote: > > [ X

Re: Jena-1427 - nextOptional()

. If the retrieved value is never null, the usage is congruent with things like Stream::findFirst. I agree that it will be difficult to remove, which is why I don't want to add a bunch of other nextOr* methods. ajs6f > On Dec 14, 2017, at 12:46 PM, Claude Warren <cla...@xenei.com> wrot

potential new API Was: Immutability

? It's fun to make wish lists at the end of the year. :grin: ajs6f > On Nov 16, 2017, at 11:47 AM, Andy Seaborne <a...@apache.org> wrote: > > Yes, I think it is best done as a new API. > > Modifications to the existing one are likely to run into problems somewhere

[GitHub] jena pull request #329: Give more time to ElasticSearch to startup

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/329 Give more time to ElasticSearch to startup You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena MoreTimeForESStartup Alternatively you can

Re: Build failed in Jenkins: Jena_Development_Deploy #1465

, but thirty seconds more seems reasonable. ajs6f > On Dec 9, 2017, at 6:38 AM, Apache Jenkins Server <jenk...@builds.apache.org> > wrote: > > See > <https://builds.apache.org/job/Jena_Development_Deploy/1465/display/redirect?page=changes> > > Changes: > > [

[GitHub] jena issue #314: JENA-1430

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 Okay, then let's break this thing up, as you describe above. Your number 2 and 3 are uncontroversial. As for number 1, sure, I want that fix too, but this PR (#314) didn't do just that. It also

[GitHub] jena issue #314: JENA-1430

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 1. The two different datasets at TIM and general. The fact that the code for the general dataset assembler doesn't mention `ja:data` is fine, but because TIM's assembler does understand `ja:data

Re: Pooling Http Client lockup

should block only until a connection is released, 2) and that closing a query execution should definitely return the connection underneath it to the pool, more or less immediately? It's almost like something above the client is blocking and not letting the connections get released... ajs6f

[GitHub] jena issue #314: JENA-1430

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 I'm saying that `ja:data` is now used for loading quads into two different kinds of datasets, but loading triples into only one. That's confusing at best. I want to make it clearer by getting rid

[GitHub] jena issue #314: JENA-1430

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/314 Ouch! I realize I wasn't clear enough at all in my last comment: I was actually -1 on this. I think the confusion that `ja:data` now has in its semantics is too much, and I completely disagree

Re: [jira] [Resolved] (JENA-1427) Add nextOrElse() method in ExtendedIterator

rst). ExtendedIterator (< Iterator) just isn't a Stream. ajs6f > On Dec 6, 2017, at 12:21 PM, Andy Seaborne <a...@apache.org> wrote: > > What this all shows to me is that Optional for end of iterator is not what > Optional is for. > > next() has two return paths: an object refer

Re: [jira] [Resolved] (JENA-1427) Add nextOrElse() method in ExtendedIterator

bility and streams and possibly more.) ajs6f > On Dec 6, 2017, at 10:21 AM, Claude Warren <cla...@xenei.com> wrote: > > Is optional.get() == null an expected or acceptable solution? I supose it > might be in this case. However i am beginning to believe that streaming > opera

Re: [jira] [Commented] (JENA-1427) Add nextOrElse() method in ExtendedIterator

If it turns out that nextOptional is problematic because of nulls in iterators, we could, at least in theory, change it to return null for null, empty for hasNext=false, and Optional.of(next()) for hasNext=true. ajs6f > On Dec 6, 2017, at 9:23 AM, Andy Seaborne <a...@apache.org&

Re: [jira] [Commented] (JENA-1427) Add nextOrElse() method in ExtendedIterator

to be usable in the only use case we have for it. ajs6f > On Dec 6, 2017, at 5:57 AM, Claude Warren <cla...@xenei.com> wrote: > > my reading of this is that nextOptional will return null at the end of the > iteration and that this is indistinguishable from a null in the

[GitHub] jena issue #324: JENA-1443: Use DatasetGraph for GraphView TransactionHandle...

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/324 Nice, thanks! ---

[GitHub] jena issue #324: JENA-1443: Use DatasetGraph for GraphView TransactionHandle...

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/324 `GraphInMemory extends GraphView`, so this should apply automatically to TIM, right? ---

Re: IteratorIterator deprecated

://google.github.io/guava/releases/19.0/api/docs/com/google/common/collect/Iterators.html#concat(java.util.Iterator...) etc. ajs6f > On Dec 2, 2017, at 9:42 AM, Claude Warren <cla...@xenei.com> wrote: > > I know that the IteratorIterator class was deprecated some time

[GitHub] jena issue #323: JENA-1427: ExtendedIterator.nextOptional

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/323 That's my point-- I don't think you can do a good fluent API for this without narrowing the `Iterator` contract to exclude `null`s, because you can't distinguish. We can do that (narrow the contact

[GitHub] jena issue #323: JENA-1427: ExtendedIterator.nextOptional

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/323 I'm saying we don't do `orElseThrow` or any other `orElseX`, we leave that to `nextOptional().orElseThrow()`, etc. Then at iterator end, `nextOptional()` returns `empty` forever. If there are `null`s

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/320#discussion_r154109219 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -319,13 +311,13 @@ private StrMatch objectToStruct(PropFuncArg argObject

[GitHub] jena issue #323: JENA-1427: ExtendedIterator.nextOptional

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/323 Do we want to return `empty` for `null`? I ask because the "ergonomics" are different. The way we have it now: ``` try { iterator.nextOptional().ifPresent(this::doStuff); }

Fwd: [GitHub] jena pull request #321: Just doing some syntax cleanup by using the new Grap...

Andy-- this is so trivial I would have just committed it, but I didn't want to bump into anything you might be doing to prep for a release. ajs6f > Begin forwarded message: > > From: ajs6f <g...@git.apache.org> > Subject: [GitHub] jena pull request #321: Just doing s

[GitHub] jena pull request #321: Just doing some syntax cleanup by using the new Grap...

GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/321 Just doing some syntax cleanup by using the new Graph::find method You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena FindANYtoFind

[GitHub] jena pull request #319: Jena 1441 tracing

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153861908 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/TextIndexLuceneAssembler.java --- @@ -144,6 +144,17 @@ public TextIndex open(Assembler

[GitHub] jena issue #319: Jena 1441 tracing

Github user ajs6f commented on the issue: https://github.com/apache/jena/pull/319 Logging statements look good to me! ---

[GitHub] jena pull request #320: JENA-1438 rdf:langString args

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/320#discussion_r153824555 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -295,6 +295,14 @@ private String chooseGraphURI(ExecutionContext execCxt

[GitHub] jena pull request #319: Jena 1441 tracing

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153822758 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextIndexLucene.java --- @@ -204,7 +204,10 @@ public void close() { @Override public

[GitHub] jena pull request #319: Jena 1441 tracing

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/319#discussion_r153822788 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java --- @@ -224,12 +234,16 @@ private QueryIterator resultsToQueryIterator(Binding

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153816757 --- Diff: jena-core/src/main/java/org/apache/jena/assembler/assemblers/AssemblerBase.java --- @@ -63,11 +63,16 @@ protected static RDFNode getUnique( Resource

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153815330 --- Diff: jena-arq/src/test/java/org/apache/jena/sparql/core/assembler/TestDatasetAssembler.java --- @@ -0,0 +1,122 @@ +/* + * Licensed to the Apache

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153815022 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -20,54 +20,45 @@ import static

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153814226 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssemblerVocab.java --- @@ -31,7 +31,7 @@ // General dataset

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153814026 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -57,28 +65,31 @@ public Dataset createDataset(Assembler

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153813914 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[GitHub] jena pull request #314: JENA-1430

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/314#discussion_r153813903 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java --- @@ -26,25 +30,29 @@ import

[GitHub] jena pull request #317: JENA-1440: TDB2 - transform bytes to NodeIds directl...

Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/317#discussion_r153284608 --- Diff: jena-db/jena-dboe-base/src/main/java/org/apache/jena/dboe/base/buffer/RecordBufferIteratorMapper.java --- @@ -0,0 +1,105 @@ +/* + * Licensed

Re: Jena 3.6.0?

Right, I just wouldn't want to make 3.6.0 wait on it if the other stuff gets done. ajs6f > On Nov 27, 2017, at 9:51 AM, Andy Seaborne <a...@apache.org> wrote: > > > > On 27/11/17 14:30, ajs6f wrote: >> Comments inline... >> ajs6f >>>

Re: Jena 3.6.0?

Comments inline... ajs6f > On Nov 27, 2017, at 8:10 AM, Andy Seaborne <a...@apache.org> wrote: > > ... > 1/ The jena-text documentation improvements Is this required for or by a release? Can we not do this independently? > 2/ Downgrade shiro to 1.2.6 > 3/ riot: statu

Re: Jena 3.6.0?

Ditto, except for me it's the 8th. ajs6f > On Nov 25, 2017, at 6:12 PM, Bruno P. Kinoshita > <brunodepau...@yahoo.com.br.INVALID> wrote: > > I can run the build and verify signatures any day in the next weeks. Just not > much time to properly test Fuseki and review change

<    1   2   3   4   5   6   7   8   9   10   >