Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/108#discussion_r47445013
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -55,21 +51,15 @@
private final
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/108#issuecomment-164263376
I'm not sure why you renamed `commitLock`. I would think that `systemLock`
would be a better name for the lock supporting `getLock`, which is not the same
and is in fact
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/108#discussion_r47445042
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -125,57 +115,104 @@ public DatasetGraphInMemory(final
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/108#issuecomment-164263343
I agree about`ReentrantLock`. Lighter for the same value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/105#issuecomment-163937760
I had no idea that throwing WARNINGs in the test suite was any kind of
issue. ERRORs, yes, but not WARNINGs. That's a policy that might be recorded
somewhere, perhaps
Github user ajs6f closed the pull request at:
https://github.com/apache/jena/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/105#issuecomment-163938075
In any event, I can review them and eliminate them. No need for you to
spend time doing that-- this is my code and I take responsibility for it. Would
you reopen
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/107#discussion_r47392305
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -166,16 +179,31 @@ public void close() {
@Override
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/107#issuecomment-164023587
Yes, I think that renaming `writeLock` makes sense. The alternative would
be to actually check the type of transaction and avoid fiddling with that lock
if it is a READ. I
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/107#issuecomment-164023866
I'm fine with pulling out the default impl of `TupleTable::abort`. I myself
don't find it any less clear, but if you do, that's evidence enough.
---
If your project is set
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/106#issuecomment-163739254
There are a lot of whitespace changes in this PR, for which I apologize.
They are present because I have switched my IDE to 4-space indents to match the
more commons usage
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/106
JENA-1083: Refactoring in TupleTable and subtypes for clarity and concision
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/105#discussion_r47086225
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -161,17 +161,17 @@ public void abort() {
@Override
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/105
JENA-1078: Logging warning when transaction is ended without commiting
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/104
Using ThreadLocal::remove to clean thread-specific state
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ajs6f/jena RemoveThreadLocals
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r46154284
--- Diff: jena-base/pom.xml ---
@@ -50,21 +50,29 @@
org.apache.commons
commons-csv
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r46153931
--- Diff: jena-arq/pom.xml ---
@@ -123,9 +123,18 @@
com.jayway.awaitility
awaitility
test
+
--- End diff
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/103
JENA-624: Correction to transaction begin for DatasetGraphInMemory
Correction to transaction begin for DatasetGraphInMemory to include default
graph as well as quad table.
You can merge this pull
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159014671
Re: `ResultSet`: Yes and, I think you want to avoid using them again even
if they are not complete. As soon as a thread has called `::next` even once,
they are no longer
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158935620
Sure, I was just responding to the question about commits. I agree that
code must be written in a style that supports maintenance over the long term.
I'd make two points
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605114
--- Diff: .travis.yml ---
@@ -0,0 +1,22 @@
+ # Licensed to the Apache Software Foundation (ASF) under one
--- End diff --
I think Travis-CI
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158940056
I'm not usually one to complain about this sort of thing, but there is so
much whitespace-change noise in this that it is _really_ hard to figure what
has actually been
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158933847
Maybe there's confusion about what this PR is for-- I wasn't intending that
it would be merged, but that you would use it as a source of examples, like I
wrote
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-158938940
Just to be clear, I don't mean to argue that Jena's code is particularly
archaic, just that we should aim for balance between taking advantage of new
capabilities
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605185
--- Diff:
jena-arq/src/main/java/org/apache/jena/atlas/json/io/JSWriter.java ---
@@ -67,7 +67,7 @@ public void startOutput() {}
public static final
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45605299
--- Diff:
jena-arq/src/main/java/org/apache/jena/query/ResultSetFormatter.java ---
@@ -48,7 +48,7 @@
public class ResultSetFormatter {
// See also
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45619712
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseOutputStream.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45619804
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseOutputStream.java
---
@@ -0,0 +1,76 @@
+/*
+ * Licensed
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620222
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseResultSet.java
---
@@ -309,13 +296,81 @@ private static void output
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158980337
I'm honestly more and more confused about the design here, using
`CacheAction` and `CacheEntry`. It seems that the same work could be
accomplished more clearly either
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620264
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158987655
@rvesse Sorry, I didn't phrase that well. I meant that commits _can_ get
squashed, so there's no need to worry about making extra ones.
---
If your project is set up
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158996139
If I understand you correctly, and you are providing `ResultSet` as the
cached value in some cases, are you dealing with threading? That is, are you
ensuring that you don't
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/101#issuecomment-159008507
Sure, @afs . It might be good to get some of this written down in the docs.
I'll happily close this PR and leave the one directly to @osma's clone in place
for him to do
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-159011031
@afs Yes, I work on other projects where that is the case. My feeling is
that (irrespective of policy) it's good form to squash down, not all the way to
one commit, but down
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45621175
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Update.java
---
@@ -92,13 +93,15 @@ protected void doOptions
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45625411
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-158994873
I'm not quite clear what you mean by "I faced error as ResultSet is closed,
Query execution error." Do you mean that the `ResultSet` cannot be rewound for
re
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r45620403
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/SPARQL_Query_Cache.java
---
@@ -0,0 +1,249 @@
+/*
+ * Licensed
GitHub user ajs6f opened a pull request:
https://github.com/apache/jena/pull/101
A few suggestions for @osma
These are a few small suggestions for @osma for using Guava or Java 8
features to slightly tighen code in `jena-text`. They are far from exhaustive,
just meant
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/100#issuecomment-158076981
And the various `Assembler` subtypes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/100#issuecomment-157728485
I'm totally cool with this renaming, of course. I did want to ask about
tests for the Assembler system-- I didn't see any, when I came to write the
ones for my little
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-156126355
@afs Squashed 'em pretty flat. The first commit is journaling operation,
the second is the new in-memory design.
I will wait to hear from you, otherwise moving
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-156146622
It occurs to me that a better way to explain myself is:
`TestDatasetGraphInMemory` looks the way it does (lots of nested classes)
because I wanted to keep the usual
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-156149841
Ah, I didn't realize that we were using the automatic
"execute-by-naming-convention" test running as well as the explicit style of
gathering things up into suites
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-155535885
@afs , I've factored a `findInUnionGraph` through the code to provide
access to implementation efficiencies. Let me know what you think!
---
If your project is set up
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44455660
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/DatasetGraphFactory.java ---
@@ -53,45 +54,38 @@ private static void copyOver(DatasetGraph dsgDest
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-155581142
Ah, that is exciting! I will begin learning the documentation CMS so as to
offer a good set of pointers and explanations to help people try this out.
---
If your project
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-155582592
Right, I'll do what I did before and squash to two more-or-less orthogonal
commits, one for "Introducing a journaling dataset!" and one for "Introducing
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44411395
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44412440
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44409220
--- Diff: jena-arq/src/main/java/org/apache/jena/query/DatasetFactory.java
---
@@ -16,253 +16,226 @@
* limitations under the License
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44410022
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44410004
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44410251
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44410452
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java ---
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44409436
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -0,0 +1,310 @@
+/*
+ * Licensed to the Apache Software
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44411038
--- Diff: jena-arq/src/main/java/org/apache/jena/query/DatasetFactory.java
---
@@ -16,253 +16,226 @@
* limitations under the License
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-155581224
@afs Shall I squash again in preparation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/97#discussion_r44015443
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/TestDatasetWithConfigurableAnalyzer.java
---
@@ -0,0 +1,63 @@
+/**
+ * Licensed
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/97#discussion_r44015231
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/ConfigurableAnalyzerAssembler.java
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-154127004
Weird. I don't know what that means, but it certainly doesn't seem right.
Several of the intermediate commits in that last also came well after 19 July
(which is what
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44028911
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44029048
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44030781
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44025566
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44025441
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44025646
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44025972
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/94#discussion_r44027198
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java
---
@@ -0,0 +1,67 @@
+package
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/97#issuecomment-154099939
Sure, there's nothing wrong with what's there. All I meant is that
`newHashSet` seems as clear as `new HashSet<>()` and allows elements, so is
shorter.
---
If your p
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/97#issuecomment-154093794
@osma I am a nitpicker of the worst kind! {grin}
If you would like me to make a PR against `jena-text` looking for this kind
of thing (using Guava or Java 8 idioms
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/97#discussion_r44013590
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/assembler/ConfigurableAnalyzerAssembler.java
---
@@ -0,0 +1,101 @@
+/**
+ * Licensed
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/97#discussion_r44012158
--- Diff:
jena-text/src/main/java/org/apache/jena/query/text/analyzer/ConfigurableAnalyzer.java
---
@@ -0,0 +1,93 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151317139
Makes sense, @afs. I'll head down that road.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151155300
@afs For "Persistent datastructures: These could go in their own package."
are you thinking of a subpackage of the one I'm currently using in
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151165442
Okay, you mean then to add a
`jena-base`:`org.apache.jena.atlas.lib.persistent`? Can do.
---
If your project is set up for it, you can reply to this email and have your
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151154190
Got 'em, thanks. I had forgotten to turn on Eclipse's warnings for "empty
statements".
---
If your project is set up for it, you can reply to this email and have
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151139579
@afs I can't find any of the unnecessary semicolon warnings-- can you give
me a pointer?
---
If your project is set up for it, you can reply to this email and have your
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151194518
@afs On the assembler front, did you want me to contribute a totally new
assembler that works for this new dataset impl, or to alter the current
`DatasetAssembler` to use
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-151170795
Oh, okay, that's different: so you're thinking
`jena-base`:`org.apache.jena.atlas.lib.persistent` or the like? Cool.
---
If your project is set up for it, you can reply
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/94#issuecomment-149916761
Thanks for the feedback, @afs! I'll take it point-by-point:
- Performance Status: The suspicion to which I was referring is that it's
because using the Streams API
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-149213529
There has been some discussion of ETags on the mailing list recently:
http://jena.markmail.org/search/%22Fuskei+and+ETags%22
and there is also this older
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42413989
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42413334
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheEntry.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42413696
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42413412
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42413572
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42329075
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/GuavaCacheClient.java
---
@@ -0,0 +1,73 @@
+/**
+ * Licensed
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42325590
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/system/InitARQ.java
---
@@ -23,7 +23,7 @@
/** ARQ initialization. Used by {@code JenaSystem
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42325746
--- Diff:
jena-core/src/main/java/org/apache/jena/system/JenaSubsystemLifecycle.java ---
@@ -18,15 +18,15 @@
package org.apache.jena.system
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42325752
--- Diff: jena-fuseki2/jena-fuseki-core/pom.xml ---
@@ -108,6 +108,12 @@
+ com.google.guava
--- End diff --
Guava
Github user ajs6f commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-149066287
I'm a little confused by the fact that for a feature that seems to require
purchase only in an HTTP API (in Fuseki itself) this code seems to tangle all
the way down
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42325779
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheAction.java
---
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42325781
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheAction.java
---
@@ -0,0 +1,45 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42320566
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java
---
@@ -0,0 +1,150 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42320708
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java ---
@@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42320704
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java ---
@@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42320206
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheEntry.java
---
@@ -0,0 +1,57 @@
+/**
+ * Licensed to the Apache
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/95#discussion_r42320283
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheClient.java
---
@@ -0,0 +1,30 @@
+/**
+ * Licensed to the Apache
801 - 900 of 1019 matches
Mail list logo
