[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44414632 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44412440 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44411395 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44411038 --- Diff: jena-arq/src/main/java/org/apache/jena/query/DatasetFactory.java --- @@ -16,253 +16,226 @@ * limitations under the License

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44409436 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44410452 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44410251 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/QuadTable.java --- @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44410004 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44410022 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java --- @@ -0,0 +1,310 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: JENA-624

2015-11-10 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44409220 --- Diff: jena-arq/src/main/java/org/apache/jena/query/DatasetFactory.java --- @@ -16,253 +16,226 @@ * limitations under the License

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-154127004 Weird. I don't know what that means, but it certainly doesn't seem right. Several of the intermediate commits in that last also came well after 19 July (which

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44030781 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44029048 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44028911 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/97#issuecomment-154099939 Sure, there's nothing wrong with what's there. All I meant is that `newHashSet` seems as clear as `new HashSet<>()` and allows elements, so is shorter. ---

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44027198 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44025972 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44025646 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44025566 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-624

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/94#discussion_r44025441 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/InMemDatasetAssembler.java --- @@ -0,0 +1,67 @@ +package

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/97#issuecomment-154093794 @osma I am a nitpicker of the worst kind! {grin} If you would like me to make a PR against `jena-text` looking for this kind of thing (using Guava or Java 8 idioms

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/97#discussion_r44015231 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/ConfigurableAnalyzerAssembler.java --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/97#discussion_r44015443 --- Diff: jena-text/src/test/java/org/apache/jena/query/text/TestDatasetWithConfigurableAnalyzer.java --- @@ -0,0 +1,63 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/97#discussion_r44013590 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/assembler/ConfigurableAnalyzerAssembler.java --- @@ -0,0 +1,101 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-1062: configurable Lucene analyzer for jen...

2015-11-05 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/97#discussion_r44012158 --- Diff: jena-text/src/main/java/org/apache/jena/query/text/analyzer/ConfigurableAnalyzer.java --- @@ -0,0 +1,93 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151317139 Makes sense, @afs. I'll head down that road. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151194518 @afs On the assembler front, did you want me to contribute a totally new assembler that works for this new dataset impl, or to alter the current `DatasetAssembler` to use

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151170795 Oh, okay, that's different: so you're thinking `jena-base`:`org.apache.jena.atlas.lib.persistent` or the like? Cool. --- If your project is set up for it, you ca

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151165442 Okay, you mean then to add a `jena-base`:`org.apache.jena.atlas.lib.persistent`? Can do. --- If your project is set up for it, you can reply to this email and have your

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151154190 Got 'em, thanks. I had forgotten to turn on Eclipse's warnings for "empty statements". --- If your project is set up for it, you can reply to this email

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151155300 @afs For "Persistent datastructures: These could go in their own package." are you thinking of a subpackage of the one I'm currently usi

[GitHub] jena pull request: JENA-624

2015-10-26 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-151139579 @afs I can't find any of the unnecessary semicolon warnings-- can you give me a pointer? --- If your project is set up for it, you can reply to this email and have

[GitHub] jena pull request: JENA-624

2015-10-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-149916761 Thanks for the feedback, @afs! I'll take it point-by-point: - Performance Status: The suspicion to which I was referring is that it's because using the S

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42413989 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42413696 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42413572 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42413412 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42413334 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheEntry.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-19 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/95#issuecomment-149213529 There has been some discussion of ETags on the mailing list recently: http://jena.markmail.org/search/%22Fuskei+and+ETags%22 and there is also this older

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/95#issuecomment-149066287 I'm a little confused by the fact that for a feature that seems to require purchase only in an HTTP API (in Fuseki itself) this code seems to tangle all the way down

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42329075 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/GuavaCacheClient.java --- @@ -0,0 +1,73 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42325781 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheAction.java --- @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42325779 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheAction.java --- @@ -0,0 +1,45 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42325752 --- Diff: jena-fuseki2/jena-fuseki-core/pom.xml --- @@ -108,6 +108,12 @@ + com.google.guava --- End diff -- Guava

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42325746 --- Diff: jena-core/src/main/java/org/apache/jena/system/JenaSubsystemLifecycle.java --- @@ -18,15 +18,15 @@ package org.apache.jena.system

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42325590 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/system/InitARQ.java --- @@ -23,7 +23,7 @@ /** ARQ initialization. Used by {@code JenaSystem

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42321146 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/TSVOutput.java --- @@ -97,6 +97,63 @@ public void format(OutputStream out, ResultSet resultSet

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320974 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java --- @@ -114,7 +170,19 @@ else if ( n.isBlank() ) str = csvSafe(str

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320957 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java --- @@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320718 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java --- @@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320708 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java --- @@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320704 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/resultset/CSVOutput.java --- @@ -102,6 +102,62 @@ public void format(OutputStream out, ResultSet

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320697 --- Diff: jena-arq/src/main/java/org/apache/jena/riot/system/InitRIOT.java --- @@ -31,7 +31,7 @@ public void start() { @Override public

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/95#issuecomment-149012148 This may be me being thick, but I don't see how a mutating query invalidates any part of the cache? --- If your project is set up for it, you can reply to this emai

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320655 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheClient.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320640 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320616 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320602 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320566 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320283 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheClient.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320279 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheClient.java --- @@ -0,0 +1,30 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320210 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheStore.java --- @@ -0,0 +1,150 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-626 SPARQL Query Caching

2015-10-18 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/95#discussion_r42320206 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/cache/CacheEntry.java --- @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache

[GitHub] jena pull request: JENA-624

2015-10-14 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/94#issuecomment-148155899 Okay, @afs, I've squashed everything into two commits. They are basically orthogonal, although there is a tiny leak from the first into the secon

[GitHub] jena pull request: JENA-624

2015-10-14 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/94 JENA-624 JENA-624: new in-memory dataset implementation using persistent data structures There are a lot of commits in this: I can squash them if desired, just let me know. I will be

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-08-10 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/90#issuecomment-129442497 Since commit https://github.com/apache/jena/commit/fd5a94ae61bcd32d2a82cebb6d088d0d81f1da39 contains literally none of the usage advice that was the only purpose of this PR

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35871940 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

[GitHub] jena pull request: Merge confidencesun/master (Merged from JENA-49...

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/89#discussion_r35870389 --- Diff: jena-arq/src-examples/arq/examples/constructquads/ExampleConstructQuads.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-30 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35869523 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/90#discussion_r35807971 --- Diff: jena-base/src/main/java/org/apache/jena/atlas/iterator/Iter.java --- @@ -29,6 +29,14 @@ import org.apache.jena.atlas.lib.Closeable ; import

[GitHub] jena pull request: Richer Javadocs for Iter and ExtendedIterator

2015-07-29 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/90 Richer Javadocs for Iter and ExtendedIterator You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena DocsForIterAndExtendedIterator

[GitHub] jena pull request: Bump versions of JUnit, Guava for Elephas

2015-07-22 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123745671 Is that something that can be automated as a system test (test-driving the demo app in a simple cluster)? --- If your project is set up for it, you can reply to this email

[GitHub] jena pull request: Merge confidencesun/master (Merged from JENA-49...

2015-07-22 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/89#discussion_r35211560 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/lang/arq/ARQParserBase.java --- @@ -67,4 +79,25 @@ protected void jsonValueString(String image, long

[GitHub] jena pull request: Merge confidencesun/master (Merged from JENA-49...

2015-07-22 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/89#discussion_r35211501 --- Diff: jena-arq/src/main/java/org/apache/jena/sparql/engine/QueryExecutionBase.java --- @@ -242,6 +257,49 @@ public Model execConstruct(Model model

[GitHub] jena pull request: Merge confidencesun/master (Merged from JENA-49...

2015-07-22 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/89#discussion_r35211148 --- Diff: jena-arq/src-examples/arq/examples/constructquads/ExampleConstructQuads.java --- @@ -0,0 +1,141 @@ +/* + * Licensed to the Apache Software

[GitHub] jena pull request: Bump versions of JUnit, Guava for Elephas

2015-07-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123455323 I know nothing of the story behind the chosen JUnit version, but I can tell you that the current version of Guava used in the main codebase (18.0) will not work with the

[GitHub] jena pull request: Bump versions of Hadoop, Guava for Elephas

2015-07-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123373621 I brought this back to just a bump for Guava (to an old, but less old, version) and JUnit. --- If your project is set up for it, you can reply to this email and have your

[GitHub] jena pull request: Bump versions of Hadoop, Guava for Elephas

2015-07-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123365451 Okay, I'll back off on Hadoop and just offer a simple bump for Guava up to the last version that is compatible with the current Hadoop. --- If your project is set up f

[GitHub] jena pull request: Bump versions of Hadoop, Guava for Elephas

2015-07-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123352349 The version of Hadoop in use is controlled by a Maven profile. Perhaps we could offer a "reliable" default profile and a "latest release" profile f

[GitHub] jena pull request: Bump versions of Hadoop, Guava for Elephas

2015-07-21 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/87#issuecomment-123350955 Have users asked for upgrades in the past? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] jena pull request: Bump versions of Hadoop, Guava for Elephas

2015-07-21 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/87 Bump versions of Hadoop, Guava for Elephas https://issues.apache.org/jira/browse/JENA-994 Possibly off-target or too late for this ticket, but bumping Hadoop to latest release enables bringing

[GitHub] jena pull request: Deprecating and removing some iterators from je...

2015-07-15 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request: Removing out-of-date comment and empty @Overrid...

2015-06-29 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/83 Removing out-of-date comment and empty @Overrides from Dataset A comment in `Dataset` indicated that it did not implement `Transactional` when in fact it now does. I removed that comment and the now

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/82#discussion_r33457733 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionBackupList.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116628538 Okay, sorry to cloud the waters. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116612135 I meant something as simple as a method that accepts an identifier and response and adds the correctly-formatted tag. --- If your project is set up for it, you can reply to

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116603288 Okay-- do you think it's worth a separate ticket and PR for some helpers for ETags, so that future new Fuseki HTTP functions could offer them at low cost? --- If

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/82#issuecomment-116597497 `POST` is one way to enable a "force up-to-date`, but it should also be possible to supply an ETag, which is a little more to the exact need. Perhaps Fuseki has helper

[GitHub] jena pull request: JENA-979: add a fuseki admin service to list al...

2015-06-29 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/jena/pull/82#discussion_r33451617 --- Diff: jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/mgt/ActionBackupList.java --- @@ -0,0 +1,98 @@ +/** + * Licensed to the

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/79#issuecomment-114963573 Closed in favor of #80 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-24 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/79#issuecomment-114963486 Closed in favor of #80 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] jena pull request: Deprecating and removing some iterators from je...

2015-06-24 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/80 Deprecating and removing some iterators from jena-core https://issues.apache.org/jira/browse/JENA-966 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] jena pull request:

2015-06-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11746591 Oh, I see you added a different commit-- cool! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] jena pull request:

2015-06-18 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11746416 Okay, but isn't the build broken now? --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] jena pull request: Fix jena-querybuilder test

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/78#issuecomment-112912669 https://issues.apache.org/jira/browse/JENA-969 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jena pull request: JENA-966: Eliminating some unnecessary iterator...

2015-06-17 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/79 JENA-966: Eliminating some unnecessary iterator types You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena JENA-966 Alternatively you can

[GitHub] jena pull request: Fix jena-querybuilder test

2015-06-17 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/78 Fix jena-querybuilder test The change to how rdf:type is serialized seems to have zonked a test in `jena-querybuilder`. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] jena pull request:

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/commit/6570c25be8c6e958a5647a7d2c1e23466498b332#commitcomment-11730739 @afs Did you have any problems with `jena-querybuilder` after this? It's looking for the full type URI in some tests... -

[GitHub] jena pull request: Move arq.cmd.* to jena-base's jena.cmd

2015-06-17 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/77#issuecomment-112862578 Okay, I've got `ModVersion` out to `jena-base` and moved `Version` into it as an inner class (since `ModVersion` is the only client of `Version`). We are still doing th

<    5   6   7   8   9   10   11   >