[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550229#comment-14550229 ] Claude Warren commented on JENA-945: After further review and some head scratching I managed to reduce the change to adding a setGroupBy(VarExprList) method. If the method is passed a null it resets the groupBy to an empty list (initial condition upon construction of the Query). So it can not be set to null by this method. It was either add that or add methods to VarExprList that would allow manipulation of the items in that list. That seemed to be more work and more prone to error. Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[
https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550349#comment-14550349
]
Andy Seaborne commented on JENA-945:
Added {{VarExprList::clear()}} and {{VarExprList::remove(Var)}}.
Add Seven methods to Query class
Key: JENA-945
URL: https://issues.apache.org/jira/browse/JENA-945
Project: Apache Jena
Issue Type: Improvement
Components: Core
Affects Versions: Jena 3.0.0
Reporter: Claude Warren
Assignee: Claude Warren
Priority: Minor
The QueryBuilder uses reflection to perform some of its data manipulation.
This reflection will fail in an environment with Java Security Manager
enabled.
This change is to add methods so that QueryBuilder no longer needs to use
reflection to get and set Query internal variables.
The variables are:
namedGraphURIs -- get and set required. parameter/return: ListString
graphURIs -- get and set required. parameter/return: ListString
projectVars -- get and set required. parameter/return: VarExprList
groupVars -- set required. parameter: VarExprList
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103505735 Meaning split it into changes to - jena-jdbc and its submodules - all other modules ? For a total of two new PRs? Sorry to be so precise-- I just want to make sure we're on the same wavelength. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550471#comment-14550471 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103505735 Meaning split it into changes to - jena-jdbc and its submodules - all other modules ? For a total of two new PRs? Sorry to be so precise-- I just want to make sure we're on the same wavelength. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103520470 Should I wait for comment from @Claudenw or move to make three new PRs: - `jena-elephas` - `jena-querybuilder` - everything else that was included here ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550519#comment-14550519 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103520470 Should I wait for comment from @Claudenw or move to make three new PRs: - `jena-elephas` - `jena-querybuilder` - everything else that was included here ? Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-elephas
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/67 JENA-938: Nonfunctional cleanup in jena-elephas You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupElephas Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 59150221aaacd8b60c803708887bb406237eb35b Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:45:21Z JENA-938: Nonfunctional cleanup in jena-elephas --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550990#comment-14550990 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/67 JENA-938: Nonfunctional cleanup in jena-elephas You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupElephas Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/67.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #67 commit 59150221aaacd8b60c803708887bb406237eb35b Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:45:21Z JENA-938: Nonfunctional cleanup in jena-elephas Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-querybu...
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/68 JENA-938: Nonfunctional cleanup in jena-querybuilder You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupQueryBuilder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit fe69dfb669b2edd063988d83fb3abb5cbaa4b644 Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:47:17Z JENA-938: Nonfunctional cleanup in jena-querybuilder --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550993#comment-14550993 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/68 JENA-938: Nonfunctional cleanup in jena-querybuilder You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupQueryBuilder Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/68.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #68 commit fe69dfb669b2edd063988d83fb3abb5cbaa4b644 Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:47:17Z JENA-938: Nonfunctional cleanup in jena-querybuilder Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-fuseki*
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/69 JENA-938: Nonfunctional cleanup in jena-fuseki* You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupFuseki Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 77aa48156b455ea5ebf47aa2b4e2053c3f6e5784 Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:49:12Z JENA-938: Nonfunctional cleanup in jena-fuseki* --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550998#comment-14550998 ] ASF GitHub Bot commented on JENA-938: - GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/69 JENA-938: Nonfunctional cleanup in jena-fuseki* You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupFuseki Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/69.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #69 commit 77aa48156b455ea5ebf47aa2b4e2053c3f6e5784 Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:49:12Z JENA-938: Nonfunctional cleanup in jena-fuseki* Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/61 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550999#comment-14550999 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f closed the pull request at: https://github.com/apache/jena/pull/61 Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551000#comment-14551000 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103629462 Closed in favor of #67, #68, #69. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103629462 Closed in favor of #67, #68, #69. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/70 JENA-938: Nonfunctional cleanup in various modules You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/jena CleanupMisc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/70.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #70 commit 76ad9ca1cf4d15ce057ddc84cb10fa88e81d6bf7 Author: ajs6f aj...@virginia.edu Date: 2015-05-19T18:53:41Z JENA-938: Nonfunctional cleanup in various modules --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551011#comment-14551011 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103632078 Okay, I've split this guy between this PR and #70. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550661#comment-14550661 ] ASF subversion and git services commented on JENA-945: -- Commit 716640bbe42bae9c014ce5fae99af37e2f9f6692 in jena's branch refs/heads/master from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=716640b ] Added Query.setGroupBy( VarExprList) in support of QueryBuilder and to close JENA-945 Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103566657 Cool. I'll get on that. Might take a day or two, because I'm going to use it as a chance to improve my Gitcraft and try to understand how to split commits on a condition like is under a directory / isn't under that directory. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550675#comment-14550675 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103566657 Cool. I'll get on that. Might take a day or two, because I'm going to use it as a chance to improve my Gitcraft and try to understand how to split commits on a condition like is under a directory / isn't under that directory. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103564682 Good to be precise! 2 PRs would be fantastic - (1) jena-jdbc and everything below it; they all go to make up jena-jdbc and (2) the rest. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: jena-spatial
Yes, if you are doing updates to the Lucene index while performing reads at the same time with the current jena-spatial code, you will eventually run into an AlreadyClosedException: this IndexWriter is closed. This will then leave the indexes in a non-safe state because they will get our of sync. The best way forward is probably to combine both projects into one as they are very similar and duplicate a lot of code currently. If I have some time soon I will try to take a look at it (but no promises that I will have the time!). Previous email available at [1]. -Stephen [1] http://markmail.org/message/6uab6glusw7lqpmz On Mon, May 18, 2015 at 8:55 AM, Chris Dollin chris.dol...@epimorphics.com wrote: (Just back from a week's hols and catching up ...) So Stephen Do I gather from Jena 848 and your email on 8th? May [1] that UNLESS we can ensure that only one query is being handled at a time it would be ... unwise ... to use jena-spatial as it stands [2]? I understand there would be a performance hit if we did this (because of multiple index opening/closing-s) but other than that would it be safe? [I'm pressing on this because if possible we'd like to decouple our project from ongoing jena development and I'm making sure we understand the options.] Chris [1] In the back-at-work cleanup I appear to have misdeleted your message and hence can only refer to it not quote it ... [2] ie without revamping the transaction handling -- If I were you, I would go to the crackpots. /They Shall Have Stars/ Epimorphics Ltd, http://www.epimorphics.com Registered address: Court Lodge, 105 High Street, Portishead, Bristol BS20 6PT Epimorphics Ltd. is a limited company registered in England (number 7016688)
[GitHub] jena pull request: Jena-text multilingual alternative implementati...
Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-103661706 1. Not exactly, let's suppose that langField is used with name language. If lang arg == none in the Sparql query, then the query extension for Lucene will be : ``` String qs2 = -language:* ``` with a minus before to exclude filled values 2. Ok I will submit it to the dev list. Is there a required formatting on on the message ? ps: I will also mention the refactoring to obtain their advices on it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (JENA-948) Remove the dependency on reflection to access Query variables.
Claude Warren created JENA-948: -- Summary: Remove the dependency on reflection to access Query variables. Key: JENA-948 URL: https://issues.apache.org/jira/browse/JENA-948 Project: Apache Jena Issue Type: Improvement Components: Jena Affects Versions: Jena 3.0.0 Reporter: Claude Warren Priority: Minor QueryBuilder depends on reflection to access some variables that are otherwise hidden. This change is to take advantage of the changes to Query and a better understanding of the Query code to remove the dependencies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550670#comment-14550670 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103564682 Good to be precise! 2 PRs would be fantastic - (1) jena-jdbc and everything below it; they all go to make up jena-jdbc and (2) the rest. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-938) Clean up dead code
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14550674#comment-14550674 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103566061 I can process the everything else PR because I think I understand those code modules well enough. If it's not much work, 3 PRs is a clear cut split but if it turns into a lot of work, plan B is that I can take a patch file and edit it. Clean up dead code -- Key: JENA-938 URL: https://issues.apache.org/jira/browse/JENA-938 Project: Apache Jena Issue Type: Task Components: Jena Affects Versions: Jena 3.0.0 Reporter: A. Soroka Priority: Minor Labels: cleanup, jena This is an umbrella task to which several PRs will be attached, each containing clean up for some modules in Jena. Each PR will contain only non-controversial emendations, such as the removal of unused imports or unthrown exceptions. Specifically disallowed are the removal of actual logic or methods. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...
Github user afs commented on the pull request: https://github.com/apache/jena/pull/61#issuecomment-103566061 I can process the everything else PR because I think I understand those code modules well enough. If it's not much work, 3 PRs is a clear cut split but if it turns into a lot of work, plan B is that I can take a patch file and edit it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] jena pull request: Jena-text multilingual alternative implementati...
Github user amiara514 commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-103635153 Languages can now be stored in the index by providing a langField param to EntityDefinition (assembler and java code). So you can use a TexIndexLucene with your own analyzer and target language of localized literals. 3 cases on Sparql clauses : ```?s text:query (rdfs:label 'word' 'lang:en' )``` will target english literals ```?s text:query (rdfs:label 'word' 'lang:none')``` will target unlocalized literals ```?s text:query (rdfs:label 'word')``` will ignore language NOTE: in Sparql queries, ```lang``` is a predefined keyword and the Lucene query will be mapped with the right langField name. Moreover, TextIndexConfig class has been introduced and EntityDefinition refactored to simplify TextDatasetFactory as desired. LuceneUtil has moved as Util class in analyzer package. It still used with the LocalizedAnalyzerAssembler --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
jena-base
I was looking at a couple of modules in Jena and using Eclipse to work with them. I could build the projects in maven. Created all the jars using -U to force rebuilding of snapshot jars. However, the jena-permissions package would not build without adding jena-base. That package uses apache-jena-libs. I think the jena-base is somehow missing from apache-jena-libs but I am not certain how to add it. Any ideas? Claude -- I like: Like Like - The likeliest place on the web http://like-like.xenei.com LinkedIn: http://www.linkedin.com/in/claudewarren
[jira] [Commented] (JENA-948) Remove the dependency on reflection to access Query variables.
[ https://issues.apache.org/jira/browse/JENA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551044#comment-14551044 ] ASF subversion and git services commented on JENA-948: -- Commit 8d5f1cb2737d95867526f6d8b9a10c2ab1c65e1d in jena's branch refs/heads/add-contract-tests from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=8d5f1cb ] Changes to remove use of reflection to modify Query objects as part of JENA-948 Remove the dependency on reflection to access Query variables. -- Key: JENA-948 URL: https://issues.apache.org/jira/browse/JENA-948 Project: Apache Jena Issue Type: Improvement Components: Jena Affects Versions: Jena 3.0.0 Reporter: Claude Warren Priority: Minor QueryBuilder depends on reflection to access some variables that are otherwise hidden. This change is to take advantage of the changes to Query and a better understanding of the Query code to remove the dependencies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JENA-945) Add Seven methods to Query class
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14551043#comment-14551043 ] ASF subversion and git services commented on JENA-945: -- Commit 716640bbe42bae9c014ce5fae99af37e2f9f6692 in jena's branch refs/heads/add-contract-tests from [~cla...@xenei.org] [ https://git-wip-us.apache.org/repos/asf?p=jena.git;h=716640b ] Added Query.setGroupBy( VarExprList) in support of QueryBuilder and to close JENA-945 Add Seven methods to Query class Key: JENA-945 URL: https://issues.apache.org/jira/browse/JENA-945 Project: Apache Jena Issue Type: Improvement Components: Core Affects Versions: Jena 3.0.0 Reporter: Claude Warren Assignee: Claude Warren Priority: Minor The QueryBuilder uses reflection to perform some of its data manipulation. This reflection will fail in an environment with Java Security Manager enabled. This change is to add methods so that QueryBuilder no longer needs to use reflection to get and set Query internal variables. The variables are: namedGraphURIs -- get and set required. parameter/return: ListString graphURIs -- get and set required. parameter/return: ListString projectVars -- get and set required. parameter/return: VarExprList groupVars -- set required. parameter: VarExprList -- This message was sent by Atlassian JIRA (v6.3.4#6332)
Re: jena-base
Found the problem. I had an older pom in the jena-core. :( On Tue, May 19, 2015 at 8:07 PM, Claude Warren cla...@xenei.com wrote: I was looking at a couple of modules in Jena and using Eclipse to work with them. I could build the projects in maven. Created all the jars using -U to force rebuilding of snapshot jars. However, the jena-permissions package would not build without adding jena-base. That package uses apache-jena-libs. I think the jena-base is somehow missing from apache-jena-libs but I am not certain how to add it. Any ideas? Claude -- I like: Like Like - The likeliest place on the web http://like-like.xenei.com LinkedIn: http://www.linkedin.com/in/claudewarren -- I like: Like Like - The likeliest place on the web http://like-like.xenei.com LinkedIn: http://www.linkedin.com/in/claudewarren
[GitHub] jena pull request: Jena-text multilingual alternative implementati...
Github user osma commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-103646019 Excellent work! Looks almost ready for merging. A couple of comments: 1.You say that ?s text:query (rdfs:label 'word' 'lang:none') will target unlocalized literals. But the code does this: ```java String qs2 = !none.equals(langArg)? field + : + langArg : - + field + :*; ``` In my understanding, this will do a wildcard search on the language field if the query argument is lang:none. So it wouldn't be possible to search for non-language-tagged literals. Unless I'm missing something, I'd replace the above expression with simply this line: ```java String qs2 = field + : + langArg; ``` 2.You have now removed some of the old constructors from EntityDefinition and the create* methods from TextDatasetFactory (and had to change the example code and some unit tests accordingly). While this leads to cleaner code, it also breaks the API so old code has to be changed. This might actually be a good moment to do it, as Jena has just bumped the version number to 3 and other APIs are also being changed, but I think we need opinions on that. If it turns out to be too disruptive, then compatibility methods could be added back. Could you write a message to the dev@ list and explain your contribution? I could then join in with comments in favor of merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
