[jira] [Resolved] (JENA-1818) Bug: CustomCoordinateSequence::setOrdinate missing break statements

2020-01-20 Thread Greg Albiston (Jira)


 [ 
https://issues.apache.org/jira/browse/JENA-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Albiston resolved JENA-1818.
-
Fix Version/s: Jena 3.15.0
   Resolution: Fixed

Break statements added.

> Bug: CustomCoordinateSequence::setOrdinate missing break statements
> ---
>
> Key: JENA-1818
> URL: https://issues.apache.org/jira/browse/JENA-1818
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Assignee: Greg Albiston
>Priority: Major
> Fix For: Jena 3.15.0
>
>
> https://github.com/apache/jena/blob/master/jena-geosparql/src/main/java/org/apache/jena/geosparql/implementation/jts/CustomCoordinateSequence.java#L441
>  
> There should be "break" statements in that switch.
> Currently there is a fallthrough manipulating other axis' values leading to 
> data corruption.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (JENA-1818) Bug: CustomCoordinateSequence::setOrdinate missing break statements

2020-01-20 Thread Greg Albiston (Jira)


 [ 
https://issues.apache.org/jira/browse/JENA-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Albiston reassigned JENA-1818:
---

Assignee: Greg Albiston

> Bug: CustomCoordinateSequence::setOrdinate missing break statements
> ---
>
> Key: JENA-1818
> URL: https://issues.apache.org/jira/browse/JENA-1818
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Assignee: Greg Albiston
>Priority: Major
>
> https://github.com/apache/jena/blob/master/jena-geosparql/src/main/java/org/apache/jena/geosparql/implementation/jts/CustomCoordinateSequence.java#L441
>  
> There should be "break" statements in that switch.
> Currently there is a fallthrough manipulating other axis' values leading to 
> data corruption.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread Greg Albiston (Jira)


 [ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Albiston resolved JENA-1820.
-
Fix Version/s: Jena 3.15.0
   Resolution: Fixed

LinearRing added to XML construction for Polygon GML shape. Tests updated.

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Assignee: Greg Albiston
>Priority: Major
> Fix For: Jena 3.15.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread Greg Albiston (Jira)


[ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019764#comment-17019764
 ] 

Greg Albiston edited comment on JENA-1820 at 1/20/20 10:56 PM:
---

This has now been fixed in 3.15.0-snapshot. Apologies for any inconvenience.

 


was (Author: gregalbiston):
This has now been fixed in 3.15-snapshot. Apologies for any inconvenience.

 

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread Greg Albiston (Jira)


 [ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Greg Albiston reassigned JENA-1820:
---

Assignee: Greg Albiston

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Assignee: Greg Albiston
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread Greg Albiston (Jira)


[ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019764#comment-17019764
 ] 

Greg Albiston commented on JENA-1820:
-

This has now been fixed in 3.15-snapshot. Apologies for any inconvenience.

 

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019762#comment-17019762
 ] 

ASF subversion and git services commented on JENA-1820:
---

Commit d913e20d4bda328bb6d046520a567a54ddbc78be in jena's branch 
refs/heads/master from Greg Albiston
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=d913e20 ]

GMLWriter: added missing "LinearRing" element as reported in JENA-1820.

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira

[jira] [Commented] (JENA-1820) GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, malformed lexicalForm

2020-01-20 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/JENA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17019763#comment-17019763
 ] 

ASF subversion and git services commented on JENA-1820:
---

Commit d78d9278fa09b618181cca8f342506aa68f5b6c9 in jena's branch 
refs/heads/master from GregAlbo
[ https://gitbox.apache.org/repos/asf?p=jena.git;h=d78d927 ]

Merge pull request #675 from galbiston/GeoSPARQL_GeometryWrapper_Fix

JENA-1820

> GeometryWrapper::asLiteral throws NullPointerException for GMLDatatype, 
> malformed lexicalForm
> -
>
> Key: JENA-1820
> URL: https://issues.apache.org/jira/browse/JENA-1820
> Project: Apache Jena
>  Issue Type: Bug
>  Components: Spatial
>Affects Versions: Jena 3.13.1
>Reporter: Philipp Neuschwander
>Priority: Major
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> GML-Literal of MultiPolygon/Polygon is malformed (generated by GMLWriter).
> Under the gml:exterior and gml:interior node, there should be a linear ring 
> that contains the posList. But the posList is generated as a direct child to 
> gml:exterior/interior:
> {code:java}
> http://www.opengis.net/ont/gml; 
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>  
> srsName="http://www.opengis.net/def/crs/OGC/1.3/CRS84;>0
>  0 10 0 10 10 0 10 0 
> 05 5 7 7 7 5 5 
> 54 4 4 5 5 5 4 
> 4
> {code}
> The missing linearRing leads to NullPointerException when trying to call
> {code:java}
> geometryWrapper.asLiteral(GMLDatatype.INSTANCE)
> {code}
> as the GMLReader (I have no clue why it is called as part of the 
> asLiteral-call) tries to access the linearRing and it's posList child. 
> Stackstrace:
> {code}
> java.lang.NullPointerException: null
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extractPosList(GMLReader.java:223)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildLinearRing(GMLReader.java:503)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildPolygon(GMLReader.java:477)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildMultiSurface(GMLReader.java:644)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.buildGeometry(GMLReader.java:199)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.(GMLReader.java:108)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.parsers.gml.GMLReader.extract(GMLReader.java:707)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GMLDatatype.read(GMLDatatype.java:84)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieveMemoryIndex(GeometryLiteralIndex.java:77)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.index.GeometryLiteralIndex.retrieve(GeometryLiteralIndex.java:51)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:57)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:50)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.datatype.GeometryDatatype.parse(GeometryDatatype.java:32)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setValue(LiteralLabelImpl.java:217)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.setLiteralLabel_1(LiteralLabelImpl.java:111)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelImpl.(LiteralLabelImpl.java:100) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.impl.LiteralLabelFactory.create(LiteralLabelFactory.java:50)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.graph.NodeFactory.createLiteral(NodeFactory.java:171) 
> ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory$Impl.createTypedLiteral(ResourceFactory.java:313)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.rdf.model.ResourceFactory.createTypedLiteral(ResourceFactory.java:148)
>  ~[jena-core-3.13.1.jar:3.13.1]
>   at 
> org.apache.jena.geosparql.implementation.GeometryWrapper.asLiteral(GeometryWrapper.java:986)
>  ~[jena-geosparql-3.13.1.jar:3.13.1]
> {code}



--
This message was sent by Atlassian Jira