[GitHub] jena pull request: Jena-text multilingual alternative implementati...

2015-05-20 Thread osma
Github user osma commented on the pull request: https://github.com/apache/jena/pull/64#issuecomment-103778663 with a minus before to exclude filled values Ah, I see. Sorry for the confusion. I had different expectations and the expression is a bit hard to read. I think this

Re: contract tests

2015-05-20 Thread Andy Seaborne
On 19/05/15 20:25, Claude Warren wrote: There is a set of contract tests (and test helpers) on the add-contract-tests branch. That branch works and has minimal change from the current tests. Those changes are adding the junit-contract runner and plugins. It makes no change to the execution.

[GitHub] jena pull request: Kill dead things

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-103970036 Changes based the ideas here have been applied to the codebase (See JENA-938). --- If your project is set up for it, you can reply to this email and have your reply appear on

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552729#comment-14552729 ] ASF GitHub Bot commented on JENA-938: - Github user asfgit closed the pull request at:

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552728#comment-14552728 ] ASF GitHub Bot commented on JENA-938: - Github user asfgit closed the pull request at:

Jena-text multilingual implementation

2015-05-20 Thread Alexis Miara
Hi, This proposal aims to integrate language-specific support in jena-text. It summarizes changes (and several discussions) done in https://github.com/apache/jena/pull/64 (JENA-928) and previously in https://github.com/apache/jena/pull/52. The forked branch is available at

Re: Jena-text multilingual implementation

2015-05-20 Thread Osma Suominen
20.05.2015, 18:40, Alexis Miara wrote: Hi, This proposal aims to integrate language-specific support in jena-text. I've been coaching this along, as you can see on GitHub. I think Alex has done a lot of good work here and I'm in favor of merging this contribution. Backward compatibility

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552724#comment-14552724 ] ASF subversion and git services commented on JENA-938: -- Commit

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552726#comment-14552726 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

[GitHub] jena pull request: Kill dead things

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in various modu...

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/70 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-fuseki*

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552727#comment-14552727 ] ASF subversion and git services commented on JENA-938: -- Commit

[jira] [Updated] (JENA-949) DISTINCT spilling to disk leads to twrong answers.

2015-05-20 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Seaborne updated JENA-949: --- Attachment: Jena949_1.java DISTINCT spilling to disk leads to twrong answers.

[jira] [Resolved] (JENA-945) Add Seven methods to Query class

2015-05-20 Thread Claude Warren (JIRA)
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved JENA-945. Resolution: Fixed Fix Version/s: Jena 3.0.0 fixed by adding Query.setGroupBy( VarExprList)

[jira] [Created] (JENA-949) DISTINCT spilling to disk leads to twrong answers.

2015-05-20 Thread Andy Seaborne (JIRA)
Andy Seaborne created JENA-949: -- Summary: DISTINCT spilling to disk leads to twrong answers. Key: JENA-949 URL: https://issues.apache.org/jira/browse/JENA-949 Project: Apache Jena Issue Type:

[jira] [Resolved] (JENA-948) Remove the dependency on reflection to access Query variables.

2015-05-20 Thread Claude Warren (JIRA)
[ https://issues.apache.org/jira/browse/JENA-948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren resolved JENA-948. Resolution: Fixed Fix Version/s: Jena 3.0.0 Assignee: Claude Warren Build has

[jira] [Closed] (JENA-945) Add Seven methods to Query class

2015-05-20 Thread Claude Warren (JIRA)
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Claude Warren closed JENA-945. -- Build succeeds so this is being closed Add Seven methods to Query class

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552742#comment-14552742 ] ASF GitHub Bot commented on JENA-938: - Github user ajs6f commented on the pull request:

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103971350 No problemo. Because it was a single commit, it was no harder than a `git reset` to before that commit and then some tap dancing between `git add`ing changes, committing

[GitHub] jena pull request: JENA-938: Nonfunctional cleanup in jena-jdbc

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/62#issuecomment-103970644 Thanks for the splitting. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Commented] (JENA-938) Clean up dead code

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552733#comment-14552733 ] ASF GitHub Bot commented on JENA-938: - Github user afs commented on the pull request:

Re: contract tests

2015-05-20 Thread Claude Warren
parallel for now, but I expect we would move a fair number of tests to it as a replacement. On Wed, May 20, 2015 at 10:25 AM, Andy Seaborne a...@apache.org wrote: On 19/05/15 20:25, Claude Warren wrote: There is a set of contract tests (and test helpers) on the add-contract-tests branch.

[jira] [Commented] (JENA-941) Upgrade code quality reports in Jena build to versions for Java 8

2015-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/JENA-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14552775#comment-14552775 ] ASF GitHub Bot commented on JENA-941: - Github user asfgit closed the pull request at:

[GitHub] jena pull request: JENA-941: Upgrading code quality plugin version...

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (JENA-945) Add Seven methods to Query class

2015-05-20 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553222#comment-14553222 ] Andy Seaborne commented on JENA-945: Replacing the call of {{Query.setGroupBy}} by:

[jira] [Commented] (JENA-945) Add Seven methods to Query class

2015-05-20 Thread Andy Seaborne (JIRA)
[ https://issues.apache.org/jira/browse/JENA-945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553230#comment-14553230 ] Andy Seaborne commented on JENA-945: Replacing the call of {{Query.setGroupBy}} in