Github user afs commented on the pull request:
https://github.com/apache/jena/pull/133#issuecomment-205982759
For `Model`: it would be unusual (mainly in small examples!) for a model to
be created and closed in the way that scoping for try-with resources tends to
emphasis. Now
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/134#discussion_r58615451
--- Diff:
apache-jena-osgi/jena-osgi/src/main/java/org/apache/jena/osgi/Activator.java ---
@@ -0,0 +1,47 @@
+package org.apache.jena.osgi;
+
+import
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/134#discussion_r58615513
--- Diff:
apache-jena-osgi/jena-osgi/src/main/java/org/apache/jena/osgi/Activator.java ---
@@ -0,0 +1,47 @@
+package org.apache.jena.osgi;
+
+import
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-205989600
(again - non-OSGi user question) Why do we need a customized version of
dexx? From a practical point of view, using the formal releases of another
project is less work
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/132#issuecomment-206374357
For now, I think that "local locale" is the best single choice because if
the user wants the XSD standard form "1.23" they can workaround it with a call
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-206426701
I don't understand why dexx-collections is different.
v0.2 has a MANIFEST.MF as does the v0.5 (but it's rather minimal)
Are you saying all our de
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-207822477
@ajs6f 's plan looks good to me. #135 applied.
Changing `JenaSubsystemRegistryBasic` looks fine.
If this PR is rebased, I'll apply it.
---
If yo
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/132#issuecomment-208295483
Looks good and I've merged it into master. Thanks!
(I've added t the documentation for the function library.)
---
If your project is set up for it, you ca
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-208348383
I have applied this fix and pushed the result to branch "osgi-fix-init"
It builds with `mvn clean install` and because this fixes something that is
otherw
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-208531897
Thanks for the quick response. Things are looking good for this.
As Jena calls into the details of Xerces, not just the XML APIs, even a
particular version can cause
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/134#discussion_r59410968
--- Diff:
apache-jena-osgi/jena-osgi/src/main/java/org/apache/jena/osgi/Activator.java ---
@@ -0,0 +1,47 @@
+package org.apache.jena.osgi;
+
+import
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/134#issuecomment-210619357
Thank you!
Merged into master and a development deployment build done.
osgi-tests are disabled because they do not work from a preflight build
("mvn
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/136
Unset prefixes
JENA-1165 : Support for handlign undefined prefixes, especially in command
line tools.
The default setting everywhere is "off".
You can merge this pull request
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/136#discussion_r60234337
--- Diff: jena-arq/src/main/java/org/apache/jena/riot/system/RiotLib.java
---
@@ -73,12 +78,37 @@ public static Node createIRIorBNode(String iri
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-212116452
An alternative (mentioned before) is to cache the query results before
serialization and replay and iterator when there is a cache hit. This could be
done with an iterator
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-212483795
@der - no it doesn't (ditto uploader). Good catch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-212484919
@ajs6f - this is about SELECT results at the moment. The same principles
will apply to model and dataset results but let's stick to result sets for now.
Even
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-213467383
@osma - really great analysis and very insightful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-213496231
**Intent and Abstraction**
Fuseki-caching isn't going to beat Vanish so I think the better use of
Fuseki-caching is supporting cases flexibility like (in the f
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/95#issuecomment-213624032
It is not for serious use! It is to explore the cases mentioned earlier
like different update paths and concurrent cache entry creation.
---
If your project is set up for it
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/137#issuecomment-216488533
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/143#issuecomment-218735541
`Z` is the same-value-as `+00:00`, testing both is ideal.
It is commenting that if the data is Z, which it is for `exprSprintf_05b`,
the outcome can be a day behind
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/143#issuecomment-218739759
`test_exprSprintf_05` is ignoring it's first argument. Bother.
If NodeValue.makeDateTime is changed:
String exprStr = "afn:sprintf('%1
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/141#issuecomment-219221447
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/143#issuecomment-219229233
I includes the new tests and kept the temporary tests so testing happens
both ways.
Tests renumbered as well.
---
If your project is set up for it, you can reply to
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/145
JENA-1171: Rework the algebra/expression walking into one framework.
This PR reworks the algebra walker to cover both algebra (op) and
expressions in one algorithm.
The algebra Transformer is redone
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/146#issuecomment-219649421
You can merge it.
The principle is that any contribution needs to be clearly given by the
original owner. Someone making sending a Pull Request is taking a step that
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/144#issuecomment-219678956
Tests: exprStrNormalizeUnicode10, exprStrNormalizeUnicode11
I don't know why they are failing either. May be it's because the version
of Unicodein Java
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/324
JENA-1443: Use DatasetGraph for GraphView TransactionHandler
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena graph-txn
Alternatively you
Github user afs commented on the issue:
https://github.com/apache/jena/pull/324
Yes, it does; see `TestGraphView`.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/317
I had time for some more testing.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/323
That was already the case in the PR and I've added text to call it out
explicitly into the javadoc.
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/314#discussion_r155532515
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssembler.java
---
@@ -26,25 +30,29 @@
import
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/314#discussion_r155532650
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/assembler/DatasetAssemblerVocab.java
---
@@ -31,7 +31,7 @@
// General dataset
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Merged in order to progress Jena 3.6.0.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
@ajs6f I do not understand your point - it is to abstract talking about
"predicates". Some examples maybe?
How do you deprecate in Turtle assembler files?
`ja:graph` isn'
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
`ja:data` isn't mentioned in `DatasetAssembler` except to redirect to TIM.
Which two different kinds of dataset?
Would you like to move `public static final Property data = property(
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Can we separate the different parts of this and unblock 3.6.0?
Is the following acceptable for 3.6.0:
1. #314 fixed a specific problem - `` and "filename" behave
diffe
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
I'm certainly willing to discuss it, that's what JENA-1445 is about and we
can rename it to be more accurate.
I'm not able to agree to the details at this stage. I have sever
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/326
JENA-1446: Fix for OpTriple and OpQuad when Var collecting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena fix-vars-optriple
Alternatively
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/327
Add Node_Triple
In support of PR #299 (RDF*).
Add `Node_Triple` - and RDF triple created as an RDF Term.
Also add `Node_Graph` for completeness.
You can merge this pull request
Github user afs commented on the issue:
https://github.com/apache/jena/pull/299
PR #327 adds an RDFTerm for a triple.
---
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/328
JENA-1447: Special case datasets
A collection of datasets and associated graphs and machinery, for one-graph
view datasets, empty and sink datasets.
More details on
[JENA-1447](https
Github user afs commented on the issue:
https://github.com/apache/jena/pull/314
Required reverts done, #313 applied and `ja:MemoryDataset` made the primary
type name for TIM assembler.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/330
Good to see this.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/329
There is a different commit ee9c98b108942f258fd9a6b2e02cc6104a648368 on the
Jena ASF git repository.
This can be closed?
For next time, it would be good to use the same commit
Github user afs commented on the issue:
https://github.com/apache/jena/pull/299
@mschroeder-github, @hartig
Apache Jena 3.6.0 is out and has `Node_Triple` for you. Feedback etc
welcome - this is an experimental feature and can be revised. Note - this does
not mean parsers
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/331
JENA-1450: Fn error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena fn_error
Alternatively you can review and apply these changes as the
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/332
JENA-1452: GraphUnionRead; Union of one.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena union-of-one
Alternatively you can review and
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/333
JENA-1451: "contains" for special graphs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena contains-special-graphs
Alternative
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/332#discussion_r158299025
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/graph/GraphUnionRead.java ---
@@ -82,16 +94,29 @@ protected PrefixMapping createPrefixMapping
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/334
JENA-1454: Introduce builder pattern for result set reading and writing.
Rework the machinery for ResultSet reading and writing to use a builder
pattern (in ResultsReader and ResultsWriter). This is
Github user afs commented on the issue:
https://github.com/apache/jena/pull/334
Needs some further cleanup before its ready to merge.
The main syntax forms, XML, JSON support read/write with a `Context` for
passing in configuration. Thrift does anyway.
TSV, CSV, Text
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/334#discussion_r158571022
--- Diff: jena-arq/src/main/java/org/apache/jena/riot/ResultSetMgr.java ---
@@ -36,123 +41,216 @@
* @see ResultSetFormatter
*/
public class
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/334#discussion_r158571855
--- Diff: jena-arq/src/main/java/org/apache/jena/riot/ResultSetMgr.java ---
@@ -36,123 +41,216 @@
* @see ResultSetFormatter
*/
public class
Github user afs commented on the issue:
https://github.com/apache/jena/pull/334
Cleaning up and switching to new reader/writer code now done.
This PR is now complete.
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/334#discussion_r158602513
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/resultset/rw/ResultsWriter.java ---
@@ -77,19 +79,33 @@ private ResultsWriter(Lang lang, Context context
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/336
JENA-1458: Transaction promotion
This PR provides promotion (read mode goes to write mode as needed) for
TIM, TDB1 and TDB2.
Transactions have a type (new) and a current mode
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159240339
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159238188
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java ---
@@ -37,6 +40,30 @@
public A car() { return a ; }
public B cdr
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159238495
--- Diff:
jena-arq/src/main/java/org/apache/jena/query/util/DatasetCollector.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159238850
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java
---
@@ -37,7 +35,7 @@
public static final Context emptyContext = new
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159241709
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159239355
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java
---
@@ -199,13 +193,12 @@ public long getLong(Symbol symbol, long defaultValue
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159240514
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159250196
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159251782
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159252508
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159253627
--- Diff:
jena-arq/src/main/java/org/apache/jena/query/util/DatasetCollector.java ---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/335#discussion_r159427449
--- Diff:
jena-text/src/test/java/org/apache/jena/query/text/TestTextGraphIndexExtra2.java
---
@@ -0,0 +1,335 @@
+/**
--- End diff --
Minor
Github user afs commented on the issue:
https://github.com/apache/jena/pull/335
Does this change the on-disk format? I do't think it does but confirmation
would be good.
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/336
That's it for now - the last commits have been converting and tidying up
the test machinery. This in turn showed up some corner cases.
There is one design issue with TDB2
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159527518
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/Context.java
---
@@ -199,13 +193,12 @@ public long getLong(Symbol symbol, long defaultValue
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159527781
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/util/ViewDatasetGraph.java ---
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159528932
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java ---
@@ -37,6 +40,30 @@
public A car() { return a ; }
public B cdr
Github user afs commented on the issue:
https://github.com/apache/jena/pull/336
(:clap: :clap: :clap:). :grinning:
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/336#discussion_r159746359
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -146,25 +162,84 @@ private void _begin(ReadWrite readWrite
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/336#discussion_r159750664
--- Diff:
jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
---
@@ -146,25 +162,84 @@ private void _begin(ReadWrite readWrite
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/337#discussion_r159885344
--- Diff: jena-base/src/main/java/org/apache/jena/atlas/lib/Pair.java ---
@@ -37,6 +40,30 @@
public A car() { return a ; }
public B cdr
Github user afs commented on the issue:
https://github.com/apache/jena/pull/338
@Claudenw may have an opinion about `ConcatenatedIterator`.
Otherwise, is this the list of classes to go (machien extracted)? This list
could go on the JIRA "for the r
Github user afs commented on the issue:
https://github.com/apache/jena/pull/335
A few words for the release announcement, especially about non needing to
rebuild indexes but if you do, hey are smaller would be most helpful.
---
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/340
JENA-1461: JavaScript custom functions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena js-functions
Alternatively you can review and apply
Github user afs commented on the issue:
https://github.com/apache/jena/pull/340
This works to pick up a javascript library in `library.js`
```
sparql --set arq:js-library=library.js --data data.ttl --query query.rq
```
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/335
Presumably this was ready to merge. I've noted the announcement text as
well, thanks, and will sort out the documentation (unless someone beats me to
it).
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/340#discussion_r160727572
--- Diff:
jena-arq/src/test/java/org/apache/jena/sparql/function/js/TestNV.java ---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/340#discussion_r160727864
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/function/js/NV.java
---
@@ -0,0 +1,217 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user afs commented on the issue:
https://github.com/apache/jena/pull/335
Documentation changes applied. Thanks!
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/340
Documentation:
http://jena.staging.apache.org/documentation/query/javascript-functions.html
---
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/342
IRI resolving
Cleaning up resolving IRIs.
Addresses JENA-1462 and JENA-1463.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena iri
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/341#discussion_r161378072
--- Diff: jena-arq/testing/RIOT/URISchemes/file-base.rdf ---
@@ -0,0 +1,8 @@
+http://2dee5b0a-6100-470a-a67f-1399518cb470/nested/";
--- End
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/341#discussion_r161378376
--- Diff: jena-arq/testing/RIOT/URISchemes/app.nt ---
@@ -0,0 +1 @@
+
<http://www.w3.org/2000/01/rdf-schema#seeAlso>
.
--- End diff --
Github user afs commented on the issue:
https://github.com/apache/jena/pull/341
To be clear: RIOT based parsing does not enforce IANA checking. It was just
that the RDF/XML parser didn't pick up the right IRIFactory via RIOT.
https://github.com/apache/jena/pull/342/co
Github user afs commented on the issue:
https://github.com/apache/jena/pull/339
There are some conflicts (due to PR #335, I think).
Is this simple to resolve? Is that because this PR includes some of the
other one?
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/341#discussion_r161625830
--- Diff: jena-arq/testing/RIOT/URISchemes/file-base.rdf ---
@@ -0,0 +1,8 @@
+http://2dee5b0a-6100-470a-a67f-1399518cb470/nested/";
--- End
Github user afs commented on the issue:
https://github.com/apache/jena/pull/339
Done! (One trivial syntax error fixed.)
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/339
TS_Text.java, line 54 had a leading backtick character. I thought I could
safely fix it :-)
+`, TestTextHighlighting.class
---
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/343#discussion_r162823649
--- Diff:
jena-core/src/test/java/org/apache/jena/graph/GraphWithPerformContractTest.java
---
@@ -68,7 +68,13 @@ public void testPerformAdd_Triple
Github user afs commented on the issue:
https://github.com/apache/jena/pull/343
Yes - there are problems with JSONInput. This is visible in the {{.patch}}
form. It looks like changes were copied from Jena master and separately
committed.
---
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/344
JENA-1467: Remove fragment before finding extension
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena ext-fragments
Alternatively you can
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/345
JENA-1468: Retain variables in op (table)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena empty-table
Alternatively you can review and
801 - 900 of 1218 matches
Mail list logo
