Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Branch created:
[JENA-632-before-merge](https://github.com/kinow/jena/tree/JENA-632-before-merge).
Won't delete it this year, in case we need to revisit.
Followed that by:
```
$
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
That works for me.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
:tada: should I proceed with the merging? If so, I will squash the 18
commits into a single one before, as said before, but with a backup branch
just-in-case. And then start working on the documentation
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
@afs also removed the `Number()` clause as that was not being used any
more. Ready for review again :+1:
And big thanks for all the feedback (and patience!) so far.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Rebase'd against master. Added `TestJsonEval.java`, with a couple more
tests. Then understood why the projected variables were not working.
Updated the grammar to call the method that populates
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
If it does not make the release then - whatever! - there'll be another
along soon!
I may be able to do some work on it after the release. I think I now
understand it better and it makes a useful
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
Eval tests: https://gist.github.com/afs/9e57b705a0d53889606346f6723238ce
Framework : needs more tests!
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
@afs had a quick look at your gist and it looks good! I won't be able to
have a proper look at it and to commit for the next ~8 hours. But feel free to
commit to this branch and update the pull request
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
And only started working again on this because you bumped this PR @ajs6f
:-) learning a lot working on this ticket, and with JENA-1488, hope to start
contributing back to Jena more now.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Will apply some of the changes tonight. But I'm afraid I may not be able to
fix the serialization issues before this weekend when there might be a new
release. This weekend I'll be in Japan for some
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
Syntax tests: https://gist.github.com/afs/e069478ec6839267256b9eacd30aa2c4
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Replied @afs `s last comment, and also rebased the code. Even though it's
rebased, there's quite a few commits... let me know if I should squash the
commits or if it's preferable to leave the commit
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
Great timing! but as ever, it it makes it, it makes it, and if it doesn't,
it doesn't.
(I will not be able to build 3.7.0 until next week anyway.)
PR #383 merged.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Most of the tests are done, just need to add at least basic coverage for
the SPARQL changes. Then will spend some minutes playing with the queries in
Fuseki, before updating the PR. Aiming to push the
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
PR #383 - we can still change it based on experience.
BTW The grammar accepts the JSON field names in single quotes to make
embedding in strings easier. It's a STRING1, either one `"` or one `'`
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
FWIW, the output of the second test right now is
```
{
"s" : "s" ,
"p" : "" ,
"o" : "def@en"
}
{
"s" : "s" ,
"p" : "" ,
"o" : "abc"
}
{
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
+1 for the current draft
I would use it
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
Conversion code (draft): 2dd4418a22 (on a branch in my GH at the moment).
The code is in `RDFTerm2Json.fromNode`.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Going to check how to get the correct values with JSON. Great catch, as I
was using just Strings. But shouldn't be too hard.
Will also include the initial tests with the next changes, covering
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
Tests?
---
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
I applied 114.patch locally and it integrated just fine.
I tried `JSON { "s": ?s , "p": ?p , "o" : ?o } WHERE { ?s ?p ?o }` on data
```
:s :p 123 .
:s :p "abc" .
:s :p "def"@en .
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Done, and ready for review again.
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Rebased!
Tested the `ARQParser` main method (which is added here, but I find very
handy for quickly testing it, but happy to remove if others prefer). And got
the following:
```
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Rebasing again, now manually, testing in Eclipse. Previous branch before
the GitHub rebase archived at https://github.com/kinow/jena/tree/JENA-632-3
---
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Rebased using GitHub's interface :tada: (never used it before, hope didn't
make any silly mistakes :-) ).
Good points @afs ! I noticed the existing SPARQL to JSON result writers, so
adjusted a
Github user afs commented on the issue:
https://github.com/apache/jena/pull/114
The JSON ecosystem moves fast! GraphQL is now significant and how that
might be used is also very interesting. There are different ways to use GraphQL
and maybe it is not the solution to all needs anyway
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
Hey @ajs6f , I think so. My weak memory seems to tell me that the last time
I did that... shortly after, there was some work on JSON (JSON-LD? Or maybe
pure JSON) somewhere else in Jena; and when I saw
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
Hey, @kinow , is this ready for rebase and review? I can try rebasing it
into a separate PR, or you can if you have time... then (hopefully) we can get
it in!
---
Github user tommals commented on the issue:
https://github.com/apache/jena/pull/114
Relevant to this thread [Return nested JSON
Github user defret5y6u7yhfgtdrfe commented on the issue:
https://github.com/apache/jena/pull/114
Relevant to this thread: [Return nested JSON
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
No prob-- good to see you back, @kinow !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kinow commented on the issue:
https://github.com/apache/jena/pull/114
@ajs6f sorry for the delay. Checked out the branch, just need to refresh my
memory. Will need a few more days before pinging you guys to check out this PR
again. Next month finally will have some time
Github user ajs6f commented on the issue:
https://github.com/apache/jena/pull/114
@kinow is this still live?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
34 matches
Mail list logo
