[GitHub] jena pull request: Kill dead things

2015-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] jena pull request: Kill dead things

2015-05-20 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-103970036 Changes based the ideas here have been applied to the codebase (See JENA-938). --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread kinow
Github user kinow commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101428998 @ajs6f we've requested SonarQube for Jena about three weeks ago https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9469 Waiting for infra :smile: --- If you

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101273013 I don't think you owe me any apologies. It's just a case of a new guy showing up to an open source project who has to spend some time getting to know the rhythm before joinin

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101256776 Good point. I wasn't able to catch on this PR before the JENA-938 ones emerged over the weekend so you have got ahead of me and everyone else. My apologies. Finding

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread ajs6f
Github user ajs6f commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101236372 This is all good info, although I feel a bit unfortunate for having done these "speculative" PRs to get it. Can some kind of policy be published for these rules-of-thumb? Eve

[GitHub] jena pull request: Kill dead things

2015-05-12 Thread afs
Github user afs commented on the pull request: https://github.com/apache/jena/pull/58#issuecomment-101213856 JENA-938 (using this PR to cover #60, #61, #62, #63) Some of these are style points: Unthrown checked exceptions: many (not all but most in my sampling) of

[GitHub] jena pull request: Kill dead things

2015-05-08 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/jena/pull/58 Kill dead things NOT FOR MERGING. This PR is just a resource for selecting smaller, more carefully-examined packages of changes. You can merge this pull request into a Git repository by running