[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
Github user asfgit closed the pull request at: https://github.com/apache/jena/pull/456 ---
[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207735470
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.build;
+
+import org.apache.jena.fuseki.FusekiConfigException;
+import org.apache.jena.fuseki.webapp.SystemState;
+import org.apache.jena.query.* ;
+import org.apache.jena.rdf.model.Literal ;
+import org.apache.jena.rdf.model.Model ;
+import org.apache.jena.rdf.model.RDFNode ;
+import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.shared.PrefixMapping ;
+import org.apache.jena.vocabulary.RDFS ;
+
+public class FusekiBuildLib {
--- End diff --
Good idea. And, yes, it is the build-specific operations.
Done.
---
[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734465
--- Diff:
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/build/FusekiBuildLib.java
---
@@ -0,0 +1,125 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jena.fuseki.build;
+
+import org.apache.jena.fuseki.FusekiConfigException;
+import org.apache.jena.fuseki.webapp.SystemState;
+import org.apache.jena.query.* ;
+import org.apache.jena.rdf.model.Literal ;
+import org.apache.jena.rdf.model.Model ;
+import org.apache.jena.rdf.model.RDFNode ;
+import org.apache.jena.rdf.model.Resource ;
+import org.apache.jena.shared.PrefixMapping ;
+import org.apache.jena.vocabulary.RDFS ;
+
+public class FusekiBuildLib {
--- End diff --
Is `FusekiBuildLib` going to replace `FusekiLib`? Would it be worth a
one/two lines comment explaining what each one does? Just so one does not
create a method in one, while the method was supposed to be in the other
class...
From a quick peek at the new classes, I think `FusekiLib` is for methods
used by Fuseki server, and `FusekiBuildLib` is more for handling
nodes/resources. In which case maybe `FusekiLib#addDataInto` methods sit in
between, but maybe could be in `FusekiBuildLib` too?
---
[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734729
--- Diff:
jena-fuseki2/jena-fuseki-embedded/src/main/java/org/apache/jena/fuseki/embedded/FusekiServer.java
---
@@ -246,6 +248,13 @@ public Builder enableStats(boolean withStats) {
return this;
}
+/** Add the "/$/ping" servlet that responds to HTTP very
efficiently.
+ * This is useful for testign whether a server is alove, for
example, from a load balencer.
--- End diff --
s/testign/testing & s/balencer/balancer
---
[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
Github user kinow commented on a diff in the pull request:
https://github.com/apache/jena/pull/456#discussion_r207734712
--- Diff:
jena-fuseki2/jena-fuseki-core/src/test/java/org/apache/jena/fuseki/package-info.java
---
@@ -16,38 +16,17 @@
* limitations under the License.
*/
-package org.apache.jena.fuseki.servlets;
-
-import java.io.* ;
-
/**
-* Code needed to implement an OutputStream that does nothing.
-*/
-
-
-public class NullOutputStream extends /*Filter*/OutputStream
-{
- public NullOutputStream()
- {
- }
-
- // The OutputStream operations
- @Override
-public void close() { /* .close() ;*/ }
- @Override
-public void flush() { /* .flush() ;*/ }
-
- // Need to implement this one.
- @Override
-public void write(int b) { /* .write(b) ;*/ }
- @Override
-public void write(byte b[]) { /* this.write(b, 0, b.length) ; */}
+ * This package has the Fuseki full server tests. ServerCtl manages a
full server for tetsing.
--- End diff --
s/tetsing/testing
---
[GitHub] jena pull request #456: JENA-1585: Fuseki core reorg
GitHub user afs opened a pull request: https://github.com/apache/jena/pull/456 JENA-1585: Fuseki core reorg Class reorganisation within the the jena-fuseki-core module. jena-fuseki-embedded and jena-fuseki-basic changes show the cleaner split - no mention of the webapp or mgt packages where the webapp code now resides. You can merge this pull request into a Git repository by running: $ git pull https://github.com/afs/jena fuseki-reorg Alternatively you can review and apply these changes as the patch at: https://github.com/apache/jena/pull/456.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #456 commit 1d41d2ce4975ebc34e8a4dd4ff67cf1100421856 Author: Andy Seaborne Date: 2018-08-04T20:56:23Z JENA-1585: Fuseki core reorg ---
