Re: Changes to HC4 HTTP sampler

Hi Quick question regarding the proxy recorder. Will it put now the encoding into the sampler or remain for now the same with the http headers config element? Best, Shmuel. בתאריך 2012 8 24 17:17, מאת "sebb" : > I'm trying to tidy up the private content generation methods in > HTTPHC4Impl. > > So

Build failed in Jenkins: JMeter-trunk #2484

See Changes: [pmouawad] Code cleanup : Remove public modifier from interface methods >From JLS : It is permitted, but strongly discouraged as a matter of style, to redundantly specify the public modifier for interface methods. Remove pub

Build failed in Jenkins: JMeter-trunk #2483

See Changes: [pmouawad] Bug 52266 - Code:Inconsistent synchronization Bugzilla Id: 52266 -- [...truncated 607 lines...] [jar] Building jar:

Build failed in Jenkins: JMeter-trunk #2482

See Changes: [sebb] We already derived the contentEncoding (charset) above [pmouawad] Removed useless method call -- [...truncated 606 lines...] [jar] Building jar:

Re: svn commit: r1376905 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java

On 24 August 2012 14:32, Philippe Mouawad wrote: > Hello sebb, > This commit and the previous one seem strange to me. > Are you sure you're not breaking something ? It looks like I have broken one of the POST unit tests. However, I'm not sure the test makes much sense. It ought to be possible t

Re: svn commit: r1376902 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java

On 24 August 2012 15:00, Philippe Mouawad wrote: > On Fri, Aug 24, 2012 at 3:08 PM, wrote: > >> Author: sebb >> Date: Fri Aug 24 13:08:08 2012 >> New Revision: 1376902 >> >> URL: http://svn.apache.org/viewvc?rev=1376902&view=rev >> Log: >> Simplify and add Javadoc for PUT/PATCH content processing

Changes to HC4 HTTP sampler

I'm trying to tidy up the private content generation methods in HTTPHC4Impl. So far I have dealt with PUT/PATCH which I hope is now easier to read - but still working OK! I'm starting on the POST method which is much bigger and messier, so I propose to fix it bit by bit. I've set up PUT/PATCH so

Re: svn commit: r1376902 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java

On Fri, Aug 24, 2012 at 3:08 PM, wrote: > Author: sebb > Date: Fri Aug 24 13:08:08 2012 > New Revision: 1376902 > > URL: http://svn.apache.org/viewvc?rev=1376902&view=rev > Log: > Simplify and add Javadoc for PUT/PATCH content processing. > TODO: the same for POST > > Modified: > > jmeter/trunk/s

Build failed in Jenkins: JMeter-trunk #2481

See Changes: [sebb] The the case of getSendParameterValuesAsPostBody, encoding should be left to the entity handler [sebb] Simplify and add Javadoc for PUT/PATCH content processing. TODO: the same for POST --

Re: svn commit: r1376905 - /jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java

Hello sebb, This commit and the previous one seem strange to me. Are you sure you're not breaking something ? Regards Philippe On Fri, Aug 24, 2012 at 3:21 PM, wrote: > Author: sebb > Date: Fri Aug 24 13:21:08 2012 > New Revision: 1376905 > > URL: http://svn.apache.org/viewvc?rev=1376905&view=r

buildbot failure in ASF Buildbot on jmeter-trunk

The Buildbot has detected a new failure on builder jmeter-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/jmeter-trunk/builds/1008 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: hemera_ubuntu Build Reason: scheduler Build Source S

Possible change to layout of Tree View contents - display order should follow actual request

I find it a bit odd that the Request Headers appear after the content data in the Request panel. I would expect the display to look more like the actual request. Not sure how easy this would be to do, given the way that HTTPSampleResult extends SampleResult. So first I'd like to see if there is a