[GitHub] jmeter pull request #364: let GUI component (dynamically) decide whether it ...

2017-12-21 Thread ham1
Github user ham1 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/364#discussion_r158429468 --- Diff: src/core/org/apache/jmeter/gui/util/MenuInfo.java --- @@ -74,4 +75,16 @@ public String getClassName(){ public int getSortOrder() {

[GitHub] jmeter pull request #364: let GUI component (dynamically) decide whether it ...

2017-12-21 Thread ham1
Github user ham1 commented on a diff in the pull request: https://github.com/apache/jmeter/pull/364#discussion_r158423992 --- Diff: src/core/org/apache/jmeter/gui/JMeterGUIComponent.java --- @@ -220,4 +220,12 @@ * @see org.apache.jmeter.gui.util.MenuFactory */

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-21 Thread pmouawad
Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/231 Hi @vlsi , I tried the component and if I have this: https://user-images.githubusercontent.com/3127467/34276777-3096e68e-e6a3-11e7-9726-759d086d11d2.png";> https://user-images.githubuserco

[GitHub] jmeter pull request #364: let GUI component (dynamically) decide whether it ...

2017-12-21 Thread ptrd
GitHub user ptrd opened a pull request: https://github.com/apache/jmeter/pull/364 let GUI component (dynamically) decide whether it can be added via th… …e menu or not; the menu item will be enabled/disabled accordingly. ## Description Added the ability to have menu

Weird Test failure

2017-12-21 Thread Philippe Mouawad
Hello, We have since few days a failure in this method which didn't change neither in test function nor in the test: - TestTimeShiftFunction#testNowWithComplexPeriod It seems something strange happens with Duration#parse. - P10DT-1H-5M5S Reading : - https://docs.oracle.com/javase/8/d

Build failed in Jenkins: JMeter-trunk #6552

2017-12-21 Thread Apache Jenkins Server
See Changes: [pmouawad] Add Apache License Header [pmouawad] Bug 61919 - UX : Reorder Menus Update tests Contributed by Graham Russell This closes #363 Bugzilla Id: 61919 [pmouawad] Bug 61919 - UX : Reorder Menus

[GitHub] jmeter pull request #363: Re-added missing menu items

2017-12-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/jmeter/pull/363 ---

[GitHub] jmeter pull request #363: Re-added missing menu items

2017-12-21 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/363 Re-added missing menu items You can merge this pull request into a Git repository by running: $ git pull https://github.com/ham1/jmeter fix_menu_regression Alternatively you can review and apply

buildbot failure in on jmeter-trunk

2017-12-21 Thread buildbot
The Buildbot has detected a new failure on builder jmeter-trunk while building . Full details are available at: https://ci.apache.org/builders/jmeter-trunk/builds/3365 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave1_ubuntu Build Reason: The AnyBranchScheduler sched

[GitHub] jmeter pull request #362: Fix sonar issue in PR #355

2017-12-21 Thread ham1
GitHub user ham1 opened a pull request: https://github.com/apache/jmeter/pull/362 Fix sonar issue in PR #355 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ham1/jmeter boundary_extractor_refactor Alternatively you can review an

Re: add hooks to JMeter for websocket plugin

2017-12-21 Thread Peter Doornbosch
Thanks Philippe, great. Looks good so far. If i'd have any feedback i'll let you know. Regards Peter 2017-12-20 10:49 GMT+01:00 Philippe Mouawad : > Hello Peter, > Thanks for your ideas and PR which has been merged with slight > modifications. > > Tests and feedback very welcome. > Regards > Phil

Re: [GitHub] jmeter issue #358: Checkstyle: LineLength max 165, AnonInnerLength 45 and ot...

2017-12-21 Thread Peter Doornbosch
Sorry, for the confusing email formatting. Of course, the way it is displayed in the mail does not reflect the original source code formatting, but i think you catch my point: i'm not very happy with breaking up lines that are only 120 chars long.. Cheers Peter 2017-12-21 10:37 GMT+01:00 Pet

Re: [GitHub] jmeter issue #358: Checkstyle: LineLength max 165, AnonInnerLength 45 and ot...

2017-12-21 Thread Peter Doornbosch
I wonder why you break up lines like these useBrowserCompatibleMultipartMode = new JCheckBox(JMeterUtils.getResString("use_multipart_mode_browser")); // $NON-NLS-1$ into useBrowserCompatibleMultipartMode = new JCheckBox(JMeterUtils.getResString("use_multi

[GitHub] jmeter issue #231: WIP: timer that produces poisson arrivals with given cons...

2017-12-21 Thread vlsi
Github user vlsi commented on the issue: https://github.com/apache/jmeter/pull/231 >Could you confirm your component implements the following features: That's true. ---