Hi Imoto,
Thanks for considering, below are my comments.
On Tuesday, December 17, 2019, Takashi Imoto wrote:
> To: Rahul-san.
>
>
>
> Thank you for comments.
>
>
>
> > Why you are manually selecting the corealtion candidates? it should be
> automated.
>
>
>
> Auto correlation feature list up
My proposal was in case we don't add ability to configure it.
So ok by me with Vladimir's proposal although it should be documented that
settings are kind of related.
On Tue, Dec 17, 2019 at 10:45 PM Dmitry Sherstobitov
wrote:
> Philippe,
>
> I don't think this will be the correct solution.
Philippe,
I don't think this will be the correct solution. It's still hardcoded in
this case and strictly depends on autoCommit which is not obvious.
I agree with Vladimir - this should be configurable.
On Wed, Dec 18, 2019 at 12:07 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
>
Philippe>dataSource.setEnableAutoCommitOnReturn(isAutocommit());
What do you think of adding a checkbox like "rollback on returning
connections to the pool"?
Dmitry>I've created issue. Currently I can't find solution for that without
Dmitry>changing source code :(
I guess it would make sense to
Hello,
I guess correct fix would be:
dataSource.setEnableAutoCommitOnReturn(isAutocommit());
Can you try with this code ?
Thank you
On Tue, Dec 17, 2019 at 9:45 PM Dmitry Sherstobitov
wrote:
> Vladimir,
>
> I've created issue. Currently I can't find solution for that without
> changing
Vladimir,
I've created issue. Currently I can't find solution for that without
changing source code :(
https://bz.apache.org/bugzilla/show_bug.cgi?id=64012
On Tue, Dec 17, 2019 at 12:27 AM Dmitry Sherstobitov
wrote:
> About cause - it's true. I chose 3.3 version because it's first version
>
