buildbot success in on jmeter-nightly

2020-09-27 Thread buildbot
The Buildbot has detected a restored build on builder jmeter-nightly while building . Full details are available at: https://ci.apache.org/builders/jmeter-nightly/builds/1861 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave7_ubuntu Build Reason: The Nightly

[GitHub] [jmeter] woonsan commented on a change in pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
woonsan commented on a change in pull request #627: URL: https://github.com/apache/jmeter/pull/627#discussion_r495591693 ## File path: src/core/src/main/resources/org/apache/jmeter/resources/messages_de.properties ## @@ -224,6 +224,11 @@ graph_results_ms=Millisekunden (ms)

[GitHub] [jmeter] woonsan commented on a change in pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
woonsan commented on a change in pull request #627: URL: https://github.com/apache/jmeter/pull/627#discussion_r495591602 ## File path: lib/aareadme.txt ## @@ -106,6 +106,11 @@ groovy-3.0.3 -- Advised scripting language for JSR223 Test Elements

[GitHub] [jmeter] vlsi commented on pull request #628: Add a boolean property to choose if we want to propagate the state of…

2020-09-27 Thread GitBox
vlsi commented on pull request #628: URL: https://github.com/apache/jmeter/pull/628#issuecomment-699652697 I think we should not introduce a gobal propery like that. State propagation should be element-aware. This is an

[GitHub] [jmeter] pmouawad commented on pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
pmouawad commented on pull request #627: URL: https://github.com/apache/jmeter/pull/627#issuecomment-699632242 Hello @woonsan , Thanks for this great contribution. I have added few notes. Thanks Regards

[GitHub] [jmeter] pmouawad commented on a change in pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
pmouawad commented on a change in pull request #627: URL: https://github.com/apache/jmeter/pull/627#discussion_r495570479 ## File path: lib/aareadme.txt ## @@ -106,6 +106,11 @@ groovy-3.0.3 -- Advised scripting language for JSR223 Test Elements

[GitHub] [jmeter] pmouawad commented on a change in pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
pmouawad commented on a change in pull request #627: URL: https://github.com/apache/jmeter/pull/627#discussion_r495568930 ## File path: src/core/src/main/resources/org/apache/jmeter/resources/messages_de.properties ## @@ -224,6 +224,11 @@ graph_results_ms=Millisekunden (ms)

[GitHub] [jmeter] pmouawad commented on a change in pull request #627: BZ 64752 - Add GraphQL/HTTP Request Sampler

2020-09-27 Thread GitBox
pmouawad commented on a change in pull request #627: URL: https://github.com/apache/jmeter/pull/627#discussion_r495568930 ## File path: src/core/src/main/resources/org/apache/jmeter/resources/messages_de.properties ## @@ -224,6 +224,11 @@ graph_results_ms=Millisekunden (ms)

[GitHub] [jmeter] pmouawad edited a comment on pull request #618: Ensure fallback enabled fonts are used.

2020-09-27 Thread GitBox
pmouawad edited a comment on pull request #618: URL: https://github.com/apache/jmeter/pull/618#issuecomment-699629289 Hello @weisJ , Did you also test with non darklaf LAF ? Thanks This is an automated message from the

[GitHub] [jmeter] pmouawad commented on pull request #618: Ensure fallback enabled fonts are used.

2020-09-27 Thread GitBox
pmouawad commented on pull request #618: URL: https://github.com/apache/jmeter/pull/618#issuecomment-699629289 Hello @weisJ , Did you also test with non darklaf ? Thanks This is an automated message from the Apache Git

[GitHub] [jmeter] pmouawad commented on pull request #628: Add a boolean property to choose if we want to propagate the state of…

2020-09-27 Thread GitBox
pmouawad commented on pull request #628: URL: https://github.com/apache/jmeter/pull/628#issuecomment-699628341 Hello @vdaburon , Thanks for your PR. I think there is a need to use your property also here:

[GitHub] [jmeter] vdaburon opened a new pull request #628: Add a boolean property to choose if we want to propagate the state of…

2020-09-27 Thread GitBox
vdaburon opened a new pull request #628: URL: https://github.com/apache/jmeter/pull/628 … the current element to the children of the tree ## Description Add a new jmeter property to choose if you want to propagate the state of the current element to the children of the tree OR