Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/381
Apply on trunk. Thanks.
You can close the PR.
URL: http://svn.apache.org/viewvc?rev=1829511=rev
Log:
French translation of Precise Throughput Timer label
Bugzilla
Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/289
Thanks.
I merge the changes except the fixes on sbadmin because JMeter has not the
source of this app.
---
If your project is set up for it, you can reply to this email and have
Github user milamberspace commented on the issue:
https://github.com/apache/jmeter/pull/223
OK for me too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/223#discussion_r73644512
--- Diff: src/core/org/apache/jmeter/util/JSR223TestElement.java ---
@@ -86,11 +88,16 @@ public JSR223TestElement
GitHub user milamberspace opened a pull request:
https://github.com/apache/jmeter/pull/197
Revert Bugzilla 58679
A character of value 0 is not valid as part of XML, but it's was written by
xpp3.
You can merge this pull request into a Git repository by running:
$ git pull
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59113426
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/187#discussion_r59111727
--- Diff: src/core/org/apache/jmeter/resources/messages_fr.properties ---
@@ -853,7 +853,7 @@ reportgenerator_summary_statistics_kbytes=Ko/sec
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/152#issuecomment-192651347
@benbenw Thanks for your PR. I've just merge the #159 with include the
change for the status icon. You can close your PR
@pmouawad thanks for the ping
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-186879979
@d0k1 Thanks for your improvement patch. Committed on jmeter repo, sorry
for long delay for commit.
---
If your project is set up for it, you can reply
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-181077864
@d0k1 don't forget to ping me on github after the update of your PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/91#discussion_r52122001
--- Diff: src/core/org/apache/jmeter/gui/util/JSyntaxTextArea.java ---
@@ -90,6 +95,9 @@ public JSyntaxTextArea(int rows, int cols, boolean
disableUndo
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-177597892
@d0k1: You can modify your PR to include the comments above directly on
your local branch, commit, squash your commits into one commit, push with
--force option
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/91#issuecomment-175880747
Thanks for your PR.
Some comments:
* That would be better to use Constants (final public static) for
properties strings inside .java files (like
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171238944
Can you provide a test case to show the issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/69#issuecomment-171233558
It would be better to not mixed format/ident changes and fix code changes.
Please can you rework the PR with a new PR with 2 commits, one for fix code
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171425357
Not a junit test, a jmeter test (.jmx)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/70#issuecomment-171403740
Yes, to show which kind of params are missing in the display
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user milamberspace commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/27#discussion_r37808539
--- Diff:
src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/AbstractJDBCTestElement.java
---
@@ -46,6 +28,14 @@
import
GitHub user milamberspace opened a pull request:
https://github.com/apache/jmeter/pull/19
Add AJP protocol (and test notification on dev list)
Test Notification with a simple PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user milamberspace closed the pull request at:
https://github.com/apache/jmeter/pull/19
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user milamberspace commented on the pull request:
https://github.com/apache/jmeter/pull/19#issuecomment-106937616
Close PR. Notifications works on dev list now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
21 matches
Mail list logo
