[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 PR commited --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Hi, Do you mean set the language to groovy in the UI when we had the component? Antonio 2016-08-11 15:42 GMT+02:00 vlsi : > Github user vlsi commented on the issue: > > https://github.com/apache/jmeter/pull/223 > > > remove log to avoid performance problem > >

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user milamberspace commented on the issue: https://github.com/apache/jmeter/pull/223 OK for me too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user vlsi commented on the issue: https://github.com/apache/jmeter/pull/223 > remove log to avoid performance problem +1 Technically speaking, I would prefer set the language to "groovy" if it was not specified. That would make the UI clear (user will

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi all, I have check in JMeter source code if this "problem" (take a default solution if nothing is setted in GUI) and I have find "CSS/JQuery Extractor" element If you check the

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user pmouawad commented on the issue: https://github.com/apache/jmeter/pull/223 Hello, In my opinion, you should commit it and we can improve it with further commits. I agree with @vlsi on the performance involvement of warn logging , but we'll find a solution if you

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 It's don't work :-( protected ScriptEngine getScriptEngine() throws ScriptException { String lang = getScriptLanguage(); if (StringUtils.isEmpty(lang))

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi ubikloadpack, Your solution seem good I will implement it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ubikloadpack commented on the issue: https://github.com/apache/jmeter/pull/223 Hello, Thanks for PR. My notes: - defaultScriptLanguage should be uppercase being a constant. - use StringUtils.isEmpty to avoid spaces breaking the control -

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user vlsi commented on the issue: https://github.com/apache/jmeter/pull/223 >I don't know how to implement For instance, a boolean flag that is cleared after the fist warning is printed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user ra0077 commented on the issue: https://github.com/apache/jmeter/pull/223 Hi vladimir, Can you give me more details to avoid logging a warning on each sampler execution? I don't know how to implement Thanks Antonio --- If your project is set up

[GitHub] jmeter issue #223: Bug59945_DefaultGroovyEngineToJSR223ElementsV2

Github user vlsi commented on the issue: https://github.com/apache/jmeter/pull/223 -1 for logging a warning on each sampler execution. Typical user would never open log files, and get bad performance results (or even log overflow of some kind) --- If your project is set up for