Github user ham1 closed the pull request at:
https://github.com/apache/jmeter/pull/131
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enable
Github user ham1 commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-199507116
@FSchumacher thank you for applying most of my changes. I've updated the PR
and there are a few more minor things left. Regarding the spelling of that
constant, I agree, it
Github user FSchumacher commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-198908905
I applied all of your formatting, typo and boolean expression changes (I
think). The change of APPLIABLE to APPLICABLE seems correct, but that mistake
is in all clas
Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-192510866
Hello,
Thanks for PR.
Would it be possible to either resubmit it after 3.0 release or resubmit
one updated ?
Thanks
---
If your project is set up for
Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/131#issuecomment-186923437
Hi,
At Team, Please avoid merging this PR for now as it would introduce a
conflict on :
https://bz.apache.org/bugzilla/show_bug.cgi?id=59033
which is mo
GitHub user ham1 opened a pull request:
https://github.com/apache/jmeter/pull/131
Refactoring of HTTPSamplerBase
Removal of unused method.
Minor simplifications of some boolean expressions.
Code formatting.
Spelling.
I've split the removal of the method and the f
