Re: Replacing ClassFinder with ServiceLoader

2017-07-20 Thread Emilian Bold
BTW: here is an example code with ServiceLoader in the JMeter codebase https://github.com/emilianbold/jmeter/commit/4bc26448e8c301b2af11f6629da93081abcb9935 What I'm trying is separate the hard dependency on NewDriver which lives in the separate launcher JAR. I'm introducing for that two new serv

Re: Replacing ClassFinder with ServiceLoader

2017-07-20 Thread Emilian Bold
> - Another critical part is to make it as easy as today to register a > plugin which is IMO one of the major reasons for JMeter success. Do you mean easy to register a plugin in the UI or easy to develop a plugin? > - The backward compatibility with 3rd party plugins is a critical part. >

Re: Replacing ClassFinder with ServiceLoader

2017-07-20 Thread Philippe Mouawad
Hello Emilian, Thanks for your analysis , and new ideas ! Can you clarify: => "The only downside is we have to think about older external JARs that expect the current behaviour. We could use some flag (in MANIFEST perhaps?) to differentiate between them." => "many calls of ClassFinder do some fil