vlsi commented on PR #727:
URL: https://github.com/apache/jmeter/pull/727#issuecomment-1295789734
Well, it triggers test failures:
```
java.lang.IllegalStateException: Cannot modify HeaderManager while test is
running. If you need dynamic headers, prefer using ${...} expressions
vlsi opened a new pull request, #5722:
URL: https://github.com/apache/jmeter/pull/5722
It has fetch depth=1 by default
See https://github.com/actions/checkout#checkout-v3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
vlsi commented on PR #727:
URL: https://github.com/apache/jmeter/pull/727#issuecomment-1295777873
The change would impact the ones who attempt to add/remove headers
dynamically via JSR223 or something similar.
For instance,
vlsi commented on PR #727:
URL: https://github.com/apache/jmeter/pull/727#issuecomment-1295786062
I've added `if (running version) throw IllegalStateException` so the ones
who accidentally run into the updating of the shared HTTP header manager would
know the limitation.
I'm
vlsi commented on code in PR #5717:
URL: https://github.com/apache/jmeter/pull/5717#discussion_r1008671507
##
src/components/src/main/java/org/apache/jmeter/assertions/JSONPathAssertion.java:
##
@@ -137,15 +137,15 @@ private void doAssert(String jsonString) {
}
vlsi commented on PR #5715:
URL: https://github.com/apache/jmeter/pull/5715#issuecomment-1295788720
@weisJ , just wondering, is this ready to go re darklaf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
vlsi merged PR #5712:
URL: https://github.com/apache/jmeter/pull/5712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
vlsi merged PR #5719:
URL: https://github.com/apache/jmeter/pull/5719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
vlsi merged PR #5722:
URL: https://github.com/apache/jmeter/pull/5722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
