[GitHub] jmeter pull request #261: Clear querystring args on each call to setPath

2017-02-01 Thread squarebracket
GitHub user squarebracket opened a pull request: https://github.com/apache/jmeter/pull/261 Clear querystring args on each call to setPath I use the `HTTPSamplerBase` class as a base class for an HTTP sampler class. I recently found a bug with the way handling of query strings is

[GitHub] jmeter issue #261: Clear querystring args on each call to setPath

2017-02-07 Thread squarebracket
Github user squarebracket commented on the issue: https://github.com/apache/jmeter/pull/261 That's a very good idea. I don't have very much experience with testing in Java, but I'll see what I can manage. Is the Travis job the right command to run for

[GitHub] jmeter issue #261: Clear querystring args on each call to setPath

2017-02-07 Thread squarebracket
Github user squarebracket commented on the issue: https://github.com/apache/jmeter/pull/261 I've added a test. I verified that it failed without the fix, passes with it. I also had to change around the test [`testMakingUrl2`](https://github.com/apache/jmeter/pull/261/co

[GitHub] jmeter issue #261: Clear querystring args on each call to setPath

2017-02-13 Thread squarebracket
Github user squarebracket commented on the issue: https://github.com/apache/jmeter/pull/261 That's a fair point, but I'm not sure what to do with what you said. Consider the following situation which occurs in the current code: ```java sampler.setPath(&q

[GitHub] jmeter issue #261: Clear querystring args on each call to setPath

2017-05-16 Thread squarebracket
Github user squarebracket commented on the issue: https://github.com/apache/jmeter/pull/261 Still waiting on an answer here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] jmeter issue #261: Clear querystring args on each call to setPath

2017-05-26 Thread squarebracket
Github user squarebracket commented on the issue: https://github.com/apache/jmeter/pull/261 In that case I will manually clear the query parameters from my inherited sampler class. Thank you for your time. --- If your project is set up for it, you can reply to this email

[GitHub] jmeter pull request #261: Clear querystring args on each call to setPath

2017-05-26 Thread squarebracket
Github user squarebracket closed the pull request at: https://github.com/apache/jmeter/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature