Re: [GitHub] incubator-joshua pull request: More work on structuring translatio...

Hey Matt. I'd suggest we hook up the unit test runs in Vancouver (only a week away). They should be runnable with junit. On Apr 28, 2016 9:55 PM, "mjpost" wrote: > Github user mjpost commented on the pull request: > > >

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/9#issuecomment-215626822 Okay, this is merged. This is nice work. A few notes: - Can you tell me how to run the unit tests? @KellenSunderland @fhieber - The phrase-based

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/9#issuecomment-215596770 Can you describe how to run the unit tests? Are you folks using Eclipse? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-joshua pull request: More work on structuring translatio...

GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/9 More work on structuring translation output These commits focus on two areas: - One is structured translation output, and this should be our last PR for this topic for the

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215286087 Okay, going to hold off until I hear from you... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user mjpost commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274644 Should I wait then to pull this in and fix the test cases? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user KellenSunderland commented on the pull request: https://github.com/apache/incubator-joshua/pull/6#issuecomment-215274462 Closing this PR temporarily as we want to tweak some commit messages. --- If your project is set up for it, you can reply to this email and have your

[GitHub] incubator-joshua pull request: More work on structuring translatio...

Github user KellenSunderland closed the pull request at: https://github.com/apache/incubator-joshua/pull/6 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-joshua pull request: More work on structuring translatio...

GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/6 More work on structuring translation output These commits focus on two areas: * One is structured translation output, and this should be our last PR for this topic for the