[jira] [Commented] (JOSHUA-297) List supported versions of Hadoop

[Bob Paulin (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425812#comment-15425812
 ] 

Bob Paulin commented on JOSHUA-297:
---

Added the logs from the Hadoop 2.6.4 and 0.20.2 runs.

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
> Attachments: thrax-hadoop0.20.2.log, thrax-hadoop2.6.4.log
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JOSHUA-297) List supported versions of Hadoop

[Bob Paulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Paulin updated JOSHUA-297:
--
Attachment: thrax-hadoop0.20.2.log

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
> Attachments: thrax-hadoop0.20.2.log, thrax-hadoop2.6.4.log
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (JOSHUA-297) List supported versions of Hadoop

[Bob Paulin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bob Paulin updated JOSHUA-297:
--
Attachment: thrax-hadoop2.6.4.log

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
> Attachments: thrax-hadoop2.6.4.log
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-301) Add findbugs plugin to maven build

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425750#comment-15425750
 ] 

Hudson commented on JOSHUA-301:
---

SUCCESS: Integrated in Jenkins build joshua_master #91 (See 
[https://builds.apache.org/job/joshua_master/91/])
JOSHUA-301 - Add findbugs plugin. (max: rev 
dccb48bcc0ab76faaa3b9f3e58823b5fa66ea983)
* (edit) pom.xml


> Add findbugs plugin to maven build
> --
>
> Key: JOSHUA-301
> URL: https://issues.apache.org/jira/browse/JOSHUA-301
> Project: Joshua
>  Issue Type: Sub-task
>  Components: build
>Reporter: Max Thomas
>Priority: Minor
>
> Add the findbugs maven plugin to the build. This will allow the build to 
> report on issues found via the popular Findbugs static analysis tool. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425203#comment-15425203
 ] 

Hudson commented on JOSHUA-302:
---

SUCCESS: Integrated in Jenkins build joshua_master #90 (See 
[https://builds.apache.org/job/joshua_master/90/])
JOSHUA-302 - Remove dependency on concurrent/concurrent package; replace (max: 
rev 19fe7561aa516b1a7eba63473e8d26111a708c33)
* (edit) src/main/java/org/apache/joshua/adagrad/AdaGradCore.java
* (edit) pom.xml
* (edit) src/main/java/org/apache/joshua/pro/PROCore.java


> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425173#comment-15425173
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/40


> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15425171#comment-15425171
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/40
  
I actually think this might have been auto-inserted by Eclipse somehow 
(resolving to the wrong version of a library). So, good find, and thanks for 
submitting.


> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua pull request #40: JOSHUA-302 - Remove dependency on concurr...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-joshua/pull/40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua issue #40: JOSHUA-302 - Remove dependency on concurrent/con...

[mjpost]

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/40
  
I actually think this might have been auto-inserted by Eclipse somehow 
(resolving to the wrong version of a library). So, good find, and thanks for 
submitting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (JOSHUA-302) Remove concurrent package and replace with builtins

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424749#comment-15424749
 ] 

ASF GitHub Bot commented on JOSHUA-302:
---

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/40

JOSHUA-302 - Remove dependency on concurrent/concurrent package



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-302

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 19fe7561aa516b1a7eba63473e8d26111a708c33
Author: Max Thomas 
Date:   2016-08-17T15:32:20Z

JOSHUA-302 - Remove dependency on concurrent/concurrent package; replace 
instances with JDK library builtins




> Remove concurrent package and replace with builtins
> ---
>
> Key: JOSHUA-302
> URL: https://issues.apache.org/jira/browse/JOSHUA-302
> Project: Joshua
>  Issue Type: Improvement
>Reporter: Max Thomas
>Priority: Minor
>
> According to this site:
> http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html
> this package is essentially replaced by SDK builtins from JDK5.0+. 
> Is there a reason this is still a dependency and cannot be replaced with 
> default library code (which, according to the site, "includes improved, more 
> efficient, standardized versions of the main components in this package")? 
> It seems to only be used in 2 places, one of which is  about 3000 lines of 
> copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua pull request #40: JOSHUA-302 - Remove dependency on concurr...

[maxthomas]

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/40

JOSHUA-302 - Remove dependency on concurrent/concurrent package



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-302

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/40.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #40


commit 19fe7561aa516b1a7eba63473e8d26111a708c33
Author: Max Thomas 
Date:   2016-08-17T15:32:20Z

JOSHUA-302 - Remove dependency on concurrent/concurrent package; replace 
instances with JDK library builtins




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (JOSHUA-302) Remove concurrent package and replace with builtins

[Max Thomas (JIRA)]

Max Thomas created JOSHUA-302:
-

 Summary: Remove concurrent package and replace with builtins
 Key: JOSHUA-302
 URL: https://issues.apache.org/jira/browse/JOSHUA-302
 Project: Joshua
  Issue Type: Improvement
Reporter: Max Thomas
Priority: Minor


According to this site:

http://gee.cs.oswego.edu/dl/classes/EDU/oswego/cs/dl/util/concurrent/intro.html

this package is essentially replaced by SDK builtins from JDK5.0+. 

Is there a reason this is still a dependency and cannot be replaced with 
default library code (which, according to the site, "includes improved, more 
efficient, standardized versions of the main components in this package")? 

It seems to only be used in 2 places, one of which is  about 3000 lines of 
copy/pasted code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua pull request #39: JOSHUA-301 - Add findbugs plugin.

[maxthomas]

GitHub user maxthomas opened a pull request:

https://github.com/apache/incubator-joshua/pull/39

JOSHUA-301 - Add findbugs plugin.

Currently this can be run with 'mvn findbugs:check'. There are a ton of 
warnings, however,
which currently fail the build if this is run as part of the maven build. 
Perhaps once fixed this auto-build failure can be added in, but at present 
there are too many warnings to fix at present.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/maxthomas/incubator-joshua JOSHUA-301

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/39.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #39


commit dccb48bcc0ab76faaa3b9f3e58823b5fa66ea983
Author: Max Thomas 
Date:   2016-08-17T15:13:37Z

JOSHUA-301 - Add findbugs plugin.

Currently this can be run with 'mvn findbugs:check'. There are a ton of 
warnings, however,
which currently fail the build. Perhaps once fixed this auto-build failure 
can be added
in, but at present there are too many warnings to fix immediately.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Release Apache Joshua 6.1

[Tommaso Teofili]

thanks for the update Matt.
+1 for a 6.1 release early in September.

Regards,
Tommaso

Il giorno mar 16 ago 2016 alle ore 07:47 Matt Post  ha
scritto:

> Lewis,
>
> A number of us met in person here in Berlin to discuss this, and we
> hammered out a roadmap. The current state reflected on JIRA is correct.
> Kellen has a multithreading simplification that he'll push up, I have the
> changes listed below, and those will constitute most of what we want to get
> done for Joshua 6.1, which we plan to release in September.
>
> In the meantime we have also reorganized the code along multi-module
> support (an earlier github PR). This will serve as the basis for Joshua 7,
> which we'll create a new branch for.
>
> I have tried to adjust the roadmap dates but don't seem to have
> permission. Can you:
>
> - Change the release date of 6.1 to 9/15?
> - Delete the Joshua 7 milestone?
> - Rename Joshua 6.2 to Joshua 7?
> - Set its release date to March 15, 2017?
>
> Thanks,
> matt
>
>
> > On Aug 13, 2016, at 11:39 PM, Matt Post  wrote:
> >
> > I just massaged the roadmap a bit. I couldn't figure out how to change
> the dates, though. I think we are on track for a September 6.1 release. Can
> someone change the target date for 6.1 to 9/1, and remove the target date
> for 6.2 (which might end up being 7?)
> >
> > The main thing I want to do is
> >
> > - Make a moderate change to the way the phrase-based decoder works (this
> will fix issues 278, 282, 284, and possibly 268)
> > - Set up the language packs more formally, with official test sets we
> can test against, and bundle them with a Joshua JAR so that there are no
> external dependencies
> >
> > matt
> >
> >
> >> On Aug 13, 2016, at 3:07 AM, lewis john mcgibbney 
> wrote:
> >>
> >> Hi dev@,
> >> What is waiting on us releasing Joshua 6.1?
> >> This is the projected roadmap...
> >>
> https://issues.apache.org/jira/browse/JOSHUA/?selectedTab=com.atlassian.jira.jira-projects-plugin:roadmap-panel
> >> Can someone please take a look through and we can rebase on our move
> >> towards a release?
> >> Thanks
> >>
> >> --
> >> http://home.apache.org/~lewismc/
> >> @hectorMcSpector
> >> http://www.linkedin.com/in/lmcgibbney
> >
>
>

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

[lewismc]

Github user lewismc commented on the issue:

https://github.com/apache/incubator-joshua/pull/24
  
Boom goes the dynamite

On Aug 17, 2016 3:33 AM, "Matt Post"  wrote:

> Awesome, that merged really cleanly. There is now a pushed 7 branch that
> we can begin work on for release 7. Travis-CI
>  is
> testing this as I write.
>
> Once we release 6.1, I'll merge 7 into master.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> 
,
> or mute the thread
> 

> .
>



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (JOSHUA-301) Add findbugs plugin to maven build

[Max Thomas (JIRA)]

Max Thomas created JOSHUA-301:
-

 Summary: Add findbugs plugin to maven build
 Key: JOSHUA-301
 URL: https://issues.apache.org/jira/browse/JOSHUA-301
 Project: Joshua
  Issue Type: Sub-task
  Components: build
Reporter: Max Thomas
Priority: Minor


Add the findbugs maven plugin to the build. This will allow the build to report 
on issues found via the popular Findbugs static analysis tool. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (JOSHUA-300) Lexicalized reordering

[Matt Post (JIRA)]

Matt Post created JOSHUA-300:


 Summary: Lexicalized reordering
 Key: JOSHUA-300
 URL: https://issues.apache.org/jira/browse/JOSHUA-300
 Project: Joshua
  Issue Type: New Feature
Reporter: Matt Post
 Fix For: 6.2


Joshua's phrase-based system should have a lexicalized reordering system.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

[Max Thomas (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424583#comment-15424583
 ] 

Max Thomas commented on JOSHUA-291:
---

alright, I'll submit some stuff I've already done on master then work off the 7 
branch. 

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-297) List supported versions of Hadoop

[Bob Paulin (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424497#comment-15424497
 ] 

Bob Paulin commented on JOSHUA-297:
---

He Matt.  I was using standalone and just switching the PATH environment 
variable.  JDK is Java 8 but I don't think I have any other versions installed. 
 Should I try everything on JDK 7?  I can post the thrax.log from the run that 
failed if that would help.  It does show the annotationjob failing.  Thanks for 
the quick response!

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua pull request #:

[mjpost]

Github user mjpost commented on the pull request:


https://github.com/apache/incubator-joshua/commit/3e2e053db9cafcdc5b4885a0f6fa5e54a63bc468#commitcomment-18672288
  
No


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-joshua pull request #:

[fhieber]

Github user fhieber commented on the pull request:


https://github.com/apache/incubator-joshua/commit/3e2e053db9cafcdc5b4885a0f6fa5e54a63bc468#commitcomment-18672173
  
In src/test/java/org/apache/joshua/system/LmOovFeatureTest.java:
In src/test/java/org/apache/joshua/system/LmOovFeatureTest.java on line 69:
is this main required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (JOSHUA-299) Move regression tests to proper unit tests

[Matt Post (JIRA)]

Matt Post created JOSHUA-299:


 Summary: Move regression tests to proper unit tests
 Key: JOSHUA-299
 URL: https://issues.apache.org/jira/browse/JOSHUA-299
 Project: Joshua
  Issue Type: Bug
Reporter: Matt Post
 Fix For: 6.1


Many of the regression tests (test*.sh under src/test/resources) have been 
moved to proper unit tests, but this move should be completed, and the 
regression tests should be deleted. This should be done for 6.1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-291) Improve code quality via static analysis

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424280#comment-15424280
 ] 

Matt Post commented on JOSHUA-291:
--

I think either is fine. If you go the sub ticket route, it would be good to 
reference this ticket in the discussion.

One thing to be wary of: we are working on issues for the impending 6.1 
release, but are going to close that out soon. The 7 release (I just created a 
branch) involves a substantial multi-module support change to the codebase. So 
to avoid complex merges in the near future, you should (a) convince us these 
changes should go into 6.1, or (b) start basing your changes off the 7 branch. 
Once 6.1 is released in early September, we'll merge 7 back into master.

> Improve code quality via static analysis
> 
>
> Key: JOSHUA-291
> URL: https://issues.apache.org/jira/browse/JOSHUA-291
> Project: Joshua
>  Issue Type: Improvement
>  Components: core
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
>
> We can improve code quality / readability leveraging code analysis from tools 
> like FindBugs and others integrated in IDEs.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] incubator-joshua issue #24: Maven multi-module project layout proposal

[mjpost]

Github user mjpost commented on the issue:

https://github.com/apache/incubator-joshua/pull/24
  
Awesome, that merged really cleanly. There is now a pushed 7 branch that we 
can begin work on for release 7. 
[Travis-CI](https://travis-ci.org/apache/incubator-joshua/builds/152931806) is 
testing this as I write.

Once we release 6.1, I'll merge 7 into master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (JOSHUA-297) List supported versions of Hadoop

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post updated JOSHUA-297:
-
Fix Version/s: 6.1

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Assigned] (JOSHUA-297) List supported versions of Hadoop

[Matt Post (JIRA)]

 [ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matt Post reassigned JOSHUA-297:


Assignee: Matt Post

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Assignee: Matt Post
>Priority: Minor
> Fix For: 6.1
>
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-297) List supported versions of Hadoop

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424262#comment-15424262
 ] 

Matt Post commented on JOSHUA-297:
--

Hmm, this is strange; we are using 2.6.4 just fine. Can you elaborate on what 
happens? Also, how do you have two different Hadoop versions? Are you setting 
up in standalone mode?

I wonder if was a Java version you were using was the problem? I have run into 
issues where Thrax gets compiled with Java 8 (our default), but Hadoop was 
using Java 7.

> List supported versions of Hadoop
> -
>
> Key: JOSHUA-297
> URL: https://issues.apache.org/jira/browse/JOSHUA-297
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Priority: Minor
>
> When working through the training tutorial I noticed that no version of 
> Hadoop was listed so I tried the latest Hadoop 2.6.4.  The Thrax Job failed 
> on this version.  It worked however with 0.20.2 .  I found this on 
> http://joshua.incubator.apache.org/6.0/pipeline.html by hovering over a link 
> on the Hadoop section.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (JOSHUA-298) Joshua Tutoral command contains a typo

[Matt Post (JIRA)]

[ 
https://issues.apache.org/jira/browse/JOSHUA-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15424258#comment-15424258
 ] 

Matt Post commented on JOSHUA-298:
--

Fixed, thanks!

> Joshua Tutoral command contains a typo
> --
>
> Key: JOSHUA-298
> URL: https://issues.apache.org/jira/browse/JOSHUA-298
> Project: Joshua
>  Issue Type: Task
>Reporter: Bob Paulin
>Priority: Minor
>
> On the following page: 
> https://cwiki.apache.org/confluence/display/JOSHUA/Joshua+Tutorial
> There are 3 typos.
> 1) 
> {code} 
> $JOSHUA/bin/pipeline.pl \
>   --rundir 2 \
>   --readme "Baseline phrase run" \
>   --source es \
>   --target en \
>   --type phrase \
>   --corpus $FISHER/corpus/ldc/fisher_train \
>   --tune $FISHER/corpus/ldc/fisher_dev \
>   --test $FISHER/corpus/ldc/fisher_dev2 \
>   --maxlen 11 \
>   --maxlen-tune 11 \
>   --maxlent-test 11 \
>   --tuner-iterations 1 \
>   --lm-order 3
> {code}
> There is an extra t in the maxlent-test .  It should be:
> {code}
> $JOSHUA/bin/pipeline.pl \
>   --rundir 2 \
>   --readme "Baseline phrase run" \
>   --source es \
>   --target en \
>   --type phrase \
>   --corpus $FISHER/corpus/ldc/fisher_train \
>   --tune $FISHER/corpus/ldc/fisher_dev \
>   --test $FISHER/corpus/ldc/fisher_dev2 \
>   --maxlen 11 \
>   --maxlen-tune 11 \
>   --maxlen-test 11 \
>   --tuner-iterations 1 \
>   --lm-order 3
> {code}
> Also within the third run there is the extra t again and a missing hyphen
> {code}
> $JOSHUA/bin/pipeline.pl \
>   --rundir 3 \
>   --readme "Baseline phrase run, picking up from run 1" \
>   --source es \
>   --target en \
>   --type hiero \
>   --first step model --no-prepare \
>   --alignment 1/alignments/training.align \
>   --corpus 1/data/train/corpus \
>   --tune 1/data/tune/corpus  \
>   --test 1/data/test/corpus \
>   --maxlen 11 \
>   --maxlen-tune 11 \
>   --maxlent-test 11 \
>   --tuner-iterations 1 \
>   --lm-order 3
> {code}
> Should be:
> {code}
> $JOSHUA/bin/pipeline.pl \
>   --rundir 3 \
>   --readme "Baseline phrase run, picking up from run 1" \
>   --source es \
>   --target en \
>   --type hiero \
>   --first-step model --no-prepare \
>   --alignment 1/alignments/training.align \
>   --corpus 1/data/train/corpus \
>   --tune 1/data/tune/corpus  \
>   --test 1/data/test/corpus \
>   --maxlen 11 \
>   --maxlen-tune 11 \
>   --maxlen-test 11 \
>   --tuner-iterations 1 \
>   --lm-order 3
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)