[jira] [Commented] (JOSHUA-331) Address Apache Joshua 6.1 RC#3 Issues
[
https://issues.apache.org/jira/browse/JOSHUA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898102#comment-15898102
]
Matt Post commented on JOSHUA-331:
--
All four files should be variations of each other. Alas, they are not.
lm.berkeleylm.gz uncompressed is lm.berkeleylm, so that's good.
lm.gz, unfortunately, when uncompressed, is missing a line from "lm". However,
recompressing "lm" (with its additional line) into lm.gz results in no changes
to the tests.
However, I regenerated all the files from the "lm" file (with its additional
line, which is crucial for one of the tests). This was done in the
following manner:
cat lm | gzip -9n > lm.gz
$JOSHUA/scripts/lm/compile_berkeleylm.py lm lm.berkeleylm
cat lm.berkeleylm | gzip -9n > lm.berkeleylm.gz
Running "mvn test" then succeeds, so I have done this and committed and pushed.
All of these tests are important because they exercise BerkeleyLM's ability to
read and properly recognize its different supported files.
Now, compile_berkeleylm.py is a fairly simply wrapper around a java call. So it
would not be difficult to modify the code and distribute only the
human-readable "lm" file.
Thoughts?
> Address Apache Joshua 6.1 RC#3 Issues
> -
>
> Key: JOSHUA-331
> URL: https://issues.apache.org/jira/browse/JOSHUA-331
> Project: Joshua
> Issue Type: Task
> Components: release
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> Address the following issues:
> {quote}
> Every ASF release MUST contain one or more source packages, which MUST be
> sufficient for a user to build and test the release provided they have
> access to the appropriate platform and tools. - NO
> -Not building due to failing test (BerkleyLM failure). I'm digging a
> bit more into this.
> {quote}
> {quote}
> Every artifact distributed to the public through Apache channels MUST be
> accompanied by one file containing an OpenPGP compatible ASCII armored
> detached signature and another file containing an MD5 checksum.
> - .asc - NO
> I get warning:
> "gpg --verify joshua-incubating-6.1-src.tar.gz.asc
> joshua-incubating-6.1-src.tar.gz
> gpg: Signature made Thu Feb 23 09:15:17 2017 CET using RSA key ID
> 891768A5
> gpg: Good signature from "Tommaso Teofili "
> [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner."
> - .md5 - NO
> My md5 of joshua-incubating-6.1-src.tar.gz is
> 504976876b01294811293aa45b5400f5, the joshua-incubating-6.1-src.tar.gz.md5
> indicates it should be 22b738eeae45757715080702a5bd2789
> - .sha - NO
> My sha of joshua-incubating-6.1-src.tar.gz is
> 4AB5BA24301590F36AE6452DACC3F21CBD8B3FEC, the
> joshua-incubating-6.1-src.tar.gz.md5 indicates it should be
> 2a55b6d341dddc5369b22a4802a86ec40accd0a1
> - KEYS - YES
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (JOSHUA-331) Address Apache Joshua 6.1 RC#3 Issues
[
https://issues.apache.org/jira/browse/JOSHUA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15898018#comment-15898018
]
Hudson commented on JOSHUA-331:
---
SUCCESS: Integrated in Jenkins build joshua_master #192 (See
[https://builds.apache.org/job/joshua_master/192/])
JOSHUA-331 - reverted to 6.1-SNAPSHOT (tommaso: rev
7a3e957497d856609b2d1531a1a2ceba54fb8e7b)
* (edit) pom.xml
> Address Apache Joshua 6.1 RC#3 Issues
> -
>
> Key: JOSHUA-331
> URL: https://issues.apache.org/jira/browse/JOSHUA-331
> Project: Joshua
> Issue Type: Task
> Components: release
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> Address the following issues:
> {quote}
> Every ASF release MUST contain one or more source packages, which MUST be
> sufficient for a user to build and test the release provided they have
> access to the appropriate platform and tools. - NO
> -Not building due to failing test (BerkleyLM failure). I'm digging a
> bit more into this.
> {quote}
> {quote}
> Every artifact distributed to the public through Apache channels MUST be
> accompanied by one file containing an OpenPGP compatible ASCII armored
> detached signature and another file containing an MD5 checksum.
> - .asc - NO
> I get warning:
> "gpg --verify joshua-incubating-6.1-src.tar.gz.asc
> joshua-incubating-6.1-src.tar.gz
> gpg: Signature made Thu Feb 23 09:15:17 2017 CET using RSA key ID
> 891768A5
> gpg: Good signature from "Tommaso Teofili "
> [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner."
> - .md5 - NO
> My md5 of joshua-incubating-6.1-src.tar.gz is
> 504976876b01294811293aa45b5400f5, the joshua-incubating-6.1-src.tar.gz.md5
> indicates it should be 22b738eeae45757715080702a5bd2789
> - .sha - NO
> My sha of joshua-incubating-6.1-src.tar.gz is
> 4AB5BA24301590F36AE6452DACC3F21CBD8B3FEC, the
> joshua-incubating-6.1-src.tar.gz.md5 indicates it should be
> 2a55b6d341dddc5369b22a4802a86ec40accd0a1
> - KEYS - YES
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (JOSHUA-331) Address Apache Joshua 6.1 RC#3 Issues
[
https://issues.apache.org/jira/browse/JOSHUA-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897957#comment-15897957
]
Tommaso Teofili commented on JOSHUA-331:
I have double checked the test issue.
It seems
https://github.com/apache/incubator-joshua/tree/master/src/test/resources/berkeley_lm
contains some binary files; probably it's correct not to have them in a source
distribution, what do others think ?
Is there a way we can just generate them ?
Or simply use the [plain text
one|https://github.com/apache/incubator-joshua/blob/master/src/test/resources/berkeley_lm/lm].
> Address Apache Joshua 6.1 RC#3 Issues
> -
>
> Key: JOSHUA-331
> URL: https://issues.apache.org/jira/browse/JOSHUA-331
> Project: Joshua
> Issue Type: Task
> Components: release
>Reporter: Tommaso Teofili
>Assignee: Tommaso Teofili
> Fix For: 6.1
>
>
> Address the following issues:
> {quote}
> Every ASF release MUST contain one or more source packages, which MUST be
> sufficient for a user to build and test the release provided they have
> access to the appropriate platform and tools. - NO
> -Not building due to failing test (BerkleyLM failure). I'm digging a
> bit more into this.
> {quote}
> {quote}
> Every artifact distributed to the public through Apache channels MUST be
> accompanied by one file containing an OpenPGP compatible ASCII armored
> detached signature and another file containing an MD5 checksum.
> - .asc - NO
> I get warning:
> "gpg --verify joshua-incubating-6.1-src.tar.gz.asc
> joshua-incubating-6.1-src.tar.gz
> gpg: Signature made Thu Feb 23 09:15:17 2017 CET using RSA key ID
> 891768A5
> gpg: Good signature from "Tommaso Teofili "
> [unknown]
> gpg: WARNING: This key is not certified with a trusted signature!
> gpg: There is no indication that the signature belongs to the
> owner."
> - .md5 - NO
> My md5 of joshua-incubating-6.1-src.tar.gz is
> 504976876b01294811293aa45b5400f5, the joshua-incubating-6.1-src.tar.gz.md5
> indicates it should be 22b738eeae45757715080702a5bd2789
> - .sha - NO
> My sha of joshua-incubating-6.1-src.tar.gz is
> 4AB5BA24301590F36AE6452DACC3F21CBD8B3FEC, the
> joshua-incubating-6.1-src.tar.gz.md5 indicates it should be
> 2a55b6d341dddc5369b22a4802a86ec40accd0a1
> - KEYS - YES
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Created] (JOSHUA-331) Address Apache Joshua 6.1 RC#3 Issues
Tommaso Teofili created JOSHUA-331:
--
Summary: Address Apache Joshua 6.1 RC#3 Issues
Key: JOSHUA-331
URL: https://issues.apache.org/jira/browse/JOSHUA-331
Project: Joshua
Issue Type: Task
Components: release
Reporter: Tommaso Teofili
Assignee: Tommaso Teofili
Fix For: 6.1
Address the following issues:
{quote}
Every ASF release MUST contain one or more source packages, which MUST be
sufficient for a user to build and test the release provided they have
access to the appropriate platform and tools. - NO
-Not building due to failing test (BerkleyLM failure). I'm digging a
bit more into this.
{quote}
{quote}
Every artifact distributed to the public through Apache channels MUST be
accompanied by one file containing an OpenPGP compatible ASCII armored
detached signature and another file containing an MD5 checksum.
- .asc - NO
I get warning:
"gpg --verify joshua-incubating-6.1-src.tar.gz.asc
joshua-incubating-6.1-src.tar.gz
gpg: Signature made Thu Feb 23 09:15:17 2017 CET using RSA key ID
891768A5
gpg: Good signature from "Tommaso Teofili "
[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg: There is no indication that the signature belongs to the
owner."
- .md5 - NO
My md5 of joshua-incubating-6.1-src.tar.gz is
504976876b01294811293aa45b5400f5, the joshua-incubating-6.1-src.tar.gz.md5
indicates it should be 22b738eeae45757715080702a5bd2789
- .sha - NO
My sha of joshua-incubating-6.1-src.tar.gz is
4AB5BA24301590F36AE6452DACC3F21CBD8B3FEC, the
joshua-incubating-6.1-src.tar.gz.md5 indicates it should be
2a55b6d341dddc5369b22a4802a86ec40accd0a1
- KEYS - YES
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
