[jira] [Commented] (JOSHUA-321) Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts

2016-11-09 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/JOSHUA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652478#comment-15652478
 ] 

Hudson commented on JOSHUA-321:
---

SUCCESS: Integrated in Jenkins build joshua_master #142 (See 
[https://builds.apache.org/job/joshua_master/142/])
JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash 
(lewis.mcgibbney: rev 2f3e752969a2bacc17aa029595c9a56b93331e9e)
* (edit) bin/extract-1best
* (edit) bin/bleu


> Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts
> -
>
> Key: JOSHUA-321
> URL: https://issues.apache.org/jira/browse/JOSHUA-321
> Project: Joshua
>  Issue Type: Bug
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> Right now both bleu and extract-1best do not have the required $JOSHUA env 
> variable which will result in an error if it is not set within the users 
> environment. This currently breaks the Homebrew install amongst other things 
> so we should add it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (JOSHUA-321) Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts

2016-11-09 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/JOSHUA-321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15652378#comment-15652378
 ] 

ASF GitHub Bot commented on JOSHUA-321:
---

GitHub user lewismc opened a pull request:

https://github.com/apache/incubator-joshua/pull/74

JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts

This issue addresses https://issues.apache.org/jira/browse/JOSHUA-321

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lewismc/incubator-joshua JOSHUA-321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-joshua/pull/74.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #74


commit 2f3e752969a2bacc17aa029595c9a56b93331e9e
Author: Lewis John McGibbney 
Date:   2016-11-09T23:31:30Z

JOSHUA-321 Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts




> Add JOSHUA env to ./bin/bleu and ./bin/extract-1best bash scripts
> -
>
> Key: JOSHUA-321
> URL: https://issues.apache.org/jira/browse/JOSHUA-321
> Project: Joshua
>  Issue Type: Bug
>Affects Versions: 6.0.5
>Reporter: Lewis John McGibbney
>Assignee: Lewis John McGibbney
>Priority: Trivial
> Fix For: 6.1
>
>
> Right now both bleu and extract-1best do not have the required $JOSHUA env 
> variable which will result in an error if it is not set within the users 
> environment. This currently breaks the Homebrew install amongst other things 
> so we should add it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)