[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876442#comment-15876442 ] Lewis John McGibbney commented on JOSHUA-324: - [~teofili] yes thank you very much, please do. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Tommaso Teofili >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873206#comment-15873206 ] Hudson commented on JOSHUA-324: --- SUCCESS: Integrated in Jenkins build joshua_master #180 (See [https://builds.apache.org/job/joshua_master/180/]) JOSHUA-324 - added exclude for IDEA files (tommaso: rev e6cd6adb1678f9c69d4c28c71203811db1b16560) * (edit) src/main/assembly/src.xml JOSHUA-324 - added exclude for release files (tommaso: rev 3b51467090cfe57e10265e8d5646e14d906ce30c) * (edit) src/main/assembly/src.xml > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873192#comment-15873192 ] Tommaso Teofili commented on JOSHUA-324: I'm giving this a try, I have adjusted a few missing excludes for the assembly descriptor. Running _ mvn release:clean release:prepare -DautoVersionSubmodules=true -DdryRun=true_ works for me, if no one objects I'll work on getting out the new RC. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873135#comment-15873135 ] Hudson commented on JOSHUA-324: --- SUCCESS: Integrated in Jenkins build joshua_master #179 (See [https://builds.apache.org/job/joshua_master/179/]) JOSHUA-324 - added missing rat exclude (tommaso: rev 0693aea73a598a976163d793dd0b3af44e67c3ab) * (edit) pom.xml > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843018#comment-15843018 ] Tom Barber commented on JOSHUA-324: --- Infact why is it running twice? [INFO] Replacing /tmp/incubator-joshua/target/joshua-incubating-6.1-SNAPSHOT-jar-with-dependencies.jar with /tmp/incubator-joshua/target/joshua-incubating-6.1-SNAPSHOT-shaded.jar [INFO] [INFO] --- maven-assembly-plugin:3.0.0:single (assembly) @ joshua-incubating --- [INFO] Reading assembly descriptor: /tmp/incubator-joshua/src/main/assembly/src.xml [INFO] Building tar: /tmp/incubator-joshua/target/joshua-incubating-6.1-SNAPSHOT-src.tar.gz [INFO] Building zip: /tmp/incubator-joshua/target/joshua-incubating-6.1-SNAPSHOT-src.zip [INFO] [INFO] --- maven-assembly-plugin:3.0.0:single (source-release-assembly) @ joshua-incubating --- [INFO] Reading assembly descriptor: /tmp/incubator-joshua/src/main/assembly/src.xml > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843006#comment-15843006 ] Tom Barber commented on JOSHUA-324: --- Okay so its a bug in the maven archive plugin. Basically on the first run it picks up the POSIX flag, on the second run for the source code it doesn't seem to pick up any of the configs because stuff liker dryRun is false as well. I will suss that out and send a PR upstream, in the mean time you'll have to use a local user account or a container to build it I suspect. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842911#comment-15842911 ] Tom Barber commented on JOSHUA-324: --- I have replicated it though, give me a while I'll see what I can do. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15842906#comment-15842906 ] Tom Barber commented on JOSHUA-324: --- Just don't run it on your NASA issued laptop! :P Or run it in a docker container or something :) > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15839892#comment-15839892 ] ASF GitHub Bot commented on JOSHUA-324: --- Github user asfgit closed the pull request at: https://github.com/apache/incubator-joshua/pull/79 > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838344#comment-15838344 ] ASF GitHub Bot commented on JOSHUA-324: --- Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/79 travis fails because of a much earlier error where the download-deps.sh script causes things to hang indefinitely. Fixing that first, then will re-test this. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838087#comment-15838087 ] Lewis John McGibbney commented on JOSHUA-324: - [~post] the only pending issue is the mvn assembly issue I described at http://www.mail-archive.com/dev%40joshua.incubator.apache.org/msg02023.html I'll have a crack today and try to resolve it. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838085#comment-15838085 ] ASF GitHub Bot commented on JOSHUA-324: --- Github user mjpost commented on the issue: https://github.com/apache/incubator-joshua/pull/79 Thanks for catching this, Kellen. I'll pull this in as soon as travis completes. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838043#comment-15838043 ] ASF GitHub Bot commented on JOSHUA-324: --- GitHub user KellenSunderland opened a pull request: https://github.com/apache/incubator-joshua/pull/79 JOSHUA-324 renamed LICENSE, removed minification of license in bootst… …rap.min.css Small patch to make detection of the license easier in this minified file. I believe this was flagged during our release review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/KellenSunderland/incubator-joshua master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-joshua/pull/79.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #79 > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837799#comment-15837799 ] Matt Post commented on JOSHUA-324: -- Lewis — Does this mean we're good to go? Is there something I can do? > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827366#comment-15827366 ] Hudson commented on JOSHUA-324: --- SUCCESS: Integrated in Jenkins build joshua_master #166 (See [https://builds.apache.org/job/joshua_master/166/]) JOSHUA-324 Address Apache Joshua 6.1 RC#2 Issues (lewis.mcgibbney: rev ae755a8bc0b1de9475285fcc8d35d8a8b5f00a6f) * (add) LICENSE.txt * (edit) CHANGES.md * (delete) LICENSE * (edit) src/main/assembly/src.xml * (edit) doap_joshua.rdf > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15827360#comment-15827360 ] Lewis John McGibbney commented on JOSHUA-324: - I'll be finishing my QA and producing an RC#3 tomorrow folks. Thanks. I've just committed {code} commit ae755a8bc0b1de9475285fcc8d35d8a8b5f00a6f Author: Lewis John McGibbneyDate: Tue Jan 17 19:12:10 2017 -0800 JOSHUA-324 Address Apache Joshua 6.1 RC#2 Issues {code} > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766912#comment-15766912 ] Hudson commented on JOSHUA-324: --- SUCCESS: Integrated in Jenkins build joshua_master #165 (See [https://builds.apache.org/job/joshua_master/165/]) JOSHUA-324 - added missing incubating suffix (tommaso: rev 5aa5308cd108c60c19b883dade54d810d1e0966e) * (edit) pom.xml > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15766822#comment-15766822 ] Tommaso Teofili commented on JOSHUA-324: changed artifactId in _joshua-incubating_ on master branch. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15708848#comment-15708848 ] Hudson commented on JOSHUA-324: --- SUCCESS: Integrated in Jenkins build joshua_master #161 (See [https://builds.apache.org/job/joshua_master/161/]) JOSHUA-324 Included correct license for OwnerMapTest (kellens: rev 142c403c3345a372ed8f7975599fa24d2a81961c) * (edit) src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706777#comment-15706777 ] Tom Barber commented on JOSHUA-324: --- My bad, found them: https://dist.apache.org/repos/dist/dev/incubator/joshua/ They aren't whats in the staging maven repo though, so I'm not sure what [~lewi...@apache.org] did there. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706760#comment-15706760 ] Tom Barber commented on JOSHUA-324: --- For what its worth, I can't find the binaries either so i'm not sure where [~jmclean] was looking... but yeah, whats in the git repo doesn't count, its whats in the tarballs that count. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706670#comment-15706670 ] Tom Barber commented on JOSHUA-324: --- what is in git doesn't count though it's what's in the tarball post build that counts > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706660#comment-15706660 ] Matt Post commented on JOSHUA-324: -- I don't see any of the binaries [8] [9] [10]: https://github.com/apache/incubator-joshua/tree/master/bin We discussed the language packs on the mailing list, but I didn't call a vote — it didn't cross my mind. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (JOSHUA-324) Address Apache Joshua 6.1 RC#2 Issues
[ https://issues.apache.org/jira/browse/JOSHUA-324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15706577#comment-15706577 ] Lewis John McGibbney commented on JOSHUA-324: - Hi Folks, I've assigned this to myself and will begin working on a pull request to incrementally address the above issues. > Address Apache Joshua 6.1 RC#2 Issues > - > > Key: JOSHUA-324 > URL: https://issues.apache.org/jira/browse/JOSHUA-324 > Project: Joshua > Issue Type: Task >Affects Versions: 6.1 >Reporter: Lewis John McGibbney >Assignee: Lewis John McGibbney >Priority: Blocker > Fix For: 6.1 > > > Feedback from [~jmclean] (thank you Justin) on our RC#2 is as follows > {code} > == > - Your missing incubating in the release artifacts name. [1] > - There are a number of binary files in the source release that look to be > compiled source code. > I checked: > - name doesn’t include incubating > - signatures and hashes correct > - DISCLAIMER exists > - LICENSE is missing a few things (see below) > - a source file is missing an Apache header [7] > - Several unexpected binary files are contained in the source release > [8][9][10][11] > - Can compile from source > License is missing: > - MIT licensed normalize.css v3.0.3 bundled in [5] > - glyph icon fonts [6] > Not an issue but it's a little odd to have LICENSE and NOTICE.txt - usually > both are bare or both have .txt extension. > Also while looking at your site I noticed that the download links of you > incubating site [2] points to github, please change to point to the offical > release area. > Also the 6.1 release has already been tagged and it available for public > download on github [4] before this vote is finished. This is IMO against > Apache release policy [3] please remove. > I also notice you recently released the language packs (18th Nov) but there > doesn’t seem to have been a vote for that? Any reason for this? > === > [1] http://incubator.apache.org/incubation/Incubation_Policy.html#Releases > [2] > https://cwiki.apache.org/confluence/display/JOSHUA/Apache+Joshua+%28Incubating%29+Home > [3] http://www.apache.org/dev/release.html#what > [4] https://github.com/apache/incubator-joshua/releases > [5] ./demo/bootstrap/css/bootstrap.min.css > [6] apache-joshua-6.1/demo/bootstrap/fonts/* > [7] ./src/test/java/org/apache/joshua/decoder/ff/tm/OwnerMapTest.java > [8] ./bin/GIZA++ > [9] ./bin/mkcls > [10 ]./bin/snt2cooc.out > [11] ,/src/test/resources/berkeley_lm/lm.berkeleylm.gz > [12] http://www.mail-archive.com/general%40incubator.apache.org/msg57543.html > [13] http://www.mail-archive.com/general%40incubator.apache.org/msg57551.html > {code} > This is a blocking issue and until addressed we cannot release 6.1-incubating -- This message was sent by Atlassian JIRA (v6.3.4#6332)