The jar loading logic is done in LoadService, and was a half-assed
attempt for us to make .jar files load something like .so files (load
and initialize at once). We need a better mechanism (probably based on
meta-inf) but I have been manually loading libraries via JRuby.runtime
to move away from th
Ok, I'm pulling in the BC updates based on Matt Hauck's branch. I'll
pull to a bc147 branch for the moment and run sanity checks, but then
merge to master soon after so we get some bake time before JRuby
1.7.3.
Since this is going to master, any remaining issues should be filed as
bugs or PRs so w
Great. I was just about to issue a pull request sometime today actually. I've
been using it for a week or two now and it's been working great at least for my
uses. There are still remaining things to be done, but they are enhancements.
--
Matt Hauck
On Wednesday, January 23, 2013 at 11:51
Ok cool, don't bother with the PR then...I'm in the middle of this and
will push to master soon.
On Wed, Jan 23, 2013 at 1:54 PM, Matt Hauck wrote:
> Great. I was just about to issue a pull request sometime today actually.
> I've been using it for a week or two now and it's been working great at
Ok, all BC 1.47 changes have been pushed to master! I had some
failures, but they didn't seem to correspond to OpenSSL (except for
two in rake test:mri19 I'm looking at now).
We're not green on any CI so I just pushed it with failures. Going to
try to green it up now before incorporating krypt.
-
Sweet!
--
Matt Hauck
On Wednesday, January 23, 2013 at 12:14 PM, Charles Oliver Nutter wrote:
> Ok, all BC 1.47 changes have been pushed to master! I had some
> failures, but they didn't seem to correspond to OpenSSL (except for
> two in rake test:mri19 I'm looking at now).
>
> We're not
Ok, here's the two failures I get. They both seem related to Matt's
"PKCS10 rewrite", which removed our artificial "version" field.
1) Failure:
test_sign_and_verify(OpenSSL::TestX509Request)
[/Users/headius/projects/jruby/test/externals/ruby1.9/openssl/test_x509req.rb:108]:
expected but was
.
The first one fails probably because when it changes the version, it expects
that the outputted der would have been different, and thus does not match the
signature anymore.
--
Matt Hauck
On Wednesday, January 23, 2013 at 1:07 PM, Charles Oliver Nutter wrote:
> Ok, here's the two failures I
On Wed, Jan 23, 2013 at 3:07 PM, Charles Oliver Nutter
wrote:
> You can see these failures running `rake test:mri19` or by running
> them directly (though you need to run with minitest excludes to mask
> expected failures).
Using -n works too.
system ~/projects/jruby $ jruby
test/externals/ruby1
On Wed, Jan 23, 2013 at 3:10 PM, Matt Hauck wrote:
> The first one fails probably because when it changes the version, it expects
> that the outputted der would have been different, and thus does not match
> the signature anymore.
That sounds good to me :-) Perhaps you can figure out the right wa
I had emailed about this previously but did not receive any response (email
subject: "Setting OpenSSL::X509::Request version"), and then put some comments
here: https://jira.codehaus.org/browse/JRUBY-6793, also with no response.
Basically, bouncy castle does not provide an API to do this. The on
This seems pretty reasonable to me. I don't like losing the MRI tests,
so there may be some tweaking we could do to get the meat out of those
tests without the version logic.
There may also be a case for modifying MRI to disallow version
modification, but that's not a high priority.
- Charlie
On
I filed https://github.com/jruby/jruby/issues/509 and excluded the
failing tests for now.
- Charlie
On Wed, Jan 23, 2013 at 3:42 PM, Charles Oliver Nutter
wrote:
> This seems pretty reasonable to me. I don't like losing the MRI tests,
> so there may be some tweaking we could do to get the meat o
I thought I had actually modified the tests to exclude the parts of the test
the try changing the version.
--
Matt Hauck
On Wednesday, January 23, 2013 at 1:42 PM, Charles Oliver Nutter wrote:
> This seems pretty reasonable to me. I don't like losing the MRI tests,
> so there may be some twe
I think you modified the 1.8 versions, but not the 1.9 versions. We
can do the same to the 1.9 versions
(test/externals/ruby1.9/openssl/test_x509req.rb).
We mostly lean on the 1.9 versions of all tests these days, since
that's the path forward.
- Charlie
On Wed, Jan 23, 2013 at 3:47 PM, Matt Hau
Gotcha.
--
Matt Hauck
On Wednesday, January 23, 2013 at 1:49 PM, Charles Oliver Nutter wrote:
> I think you modified the 1.8 versions, but not the 1.9 versions. We
> can do the same to the 1.9 versions
> (test/externals/ruby1.9/openssl/test_x509req.rb).
>
> We mostly lean on the 1.9 versions
16 matches
Mail list logo
