Re: [PR] Update URLConstructor.java [jspwiki]

2023-12-03 Thread via GitHub
udittmer commented on PR #322: URL: https://github.com/apache/jspwiki/pull/322#issuecomment-1837465275 No, that doesn't make a difference - any umlauts being saved are mangled. My encoding is UTF-8, in case that makes a difference, and useEncoding is true. I played around a bit

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

2023-12-03 Thread Murray Altheim
Hi Juan Pablo, Sounds like a good idea. I wouldn't mind at all but I'm sorry to say I'm not in a situation for the next month or so (until mid-January) where I can do any coding. Apologies. Cheers, Murray On 3/12/23 22:03, Juan Pablo Santos Rodríguez wrote: Hi Murray, I agree, listeners

Re: [PR] [JSPWIKI-1178] Address potential deadlock with JDK 21 Virtual Threads. [jspwiki]

2023-12-03 Thread Juan Pablo Santos Rodríguez
Hi Murray, I agree, listeners should only appear on startup, if they appear later on then there's something wrong. It occurs to me that, in this case, perhaps replacing the listener list with a CopyOnWriteArrayList would be enough to tackle all the synchronized code (and the need to wrap it