I'm not sure if there's already a guideline like this, but I wouldn't it make
sense to have it in order to keep documentation in sync with the code?
Also, having this type of documentation as part of the codebase to allow proper
versioning might be a good idea as well.
Cosmin
Cosmin,
That's a good idea. In the past, for major new features, we tend to create
a wiki page to outline the design. The wiki pages can be organized better.
Is this what you are looking for?
Thanks,
Jun
On Wed, Jul 10, 2013 at 1:17 AM, Cosmin Lehene cleh...@adobe.com wrote:
I'm not sure if
I like the idea of improving our documentation. Help is very much
appreciated in this area (but of course the problem is that the people who
experience the holes almost by definition can't fill them in). So even just
pointing out areas that aren't covered is really helpful.
We are in a sort of
Jun,
I did a test this morning and got a very interesting result with you
command. I started by wipe all the log files and clean up all zookeeper
data files.
Once I restarted both server, producer and consumer then execute your
command, what I got is a empty log as following:
Dumping
Rebecca Sealfon created KAFKA-968:
-
Summary: Typographical Errors in Output
Key: KAFKA-968
URL: https://issues.apache.org/jira/browse/KAFKA-968
Project: Kafka
Issue Type: Bug
[
https://issues.apache.org/jira/browse/KAFKA-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-959:
Assignee: Guozhang Wang
DefaultEventHandler can send more produce requests than necesary
Sriram Subramanian created KAFKA-969:
Summary: Need to prevent failure of rebalance when there are no
brokers available when consumer comes up
Key: KAFKA-969
URL:
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriram Subramanian updated KAFKA-969:
-
Attachment: emptybrokeronrebalance-1.patch
Need to prevent failure of rebalance when
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sriram Subramanian updated KAFKA-969:
-
Status: Patch Available (was: Open)
Need to prevent failure of rebalance when there
Guys,
I am seeing this:
if (condition) {
// something
}
else {
// something else
}
This is not the style we are using. Please don't do this or accept code
that looks like this. It should be
if (condition) {
// something
} else {
//something else
}
Thanks!
-Jay
Weird - I tried your exact code and it worked for me (although I was
using 0.8 head and not the beta). Can you re-run with trace logs
enabled in your producer and paste that output? Broker logs also if
you can?
Thanks,
Joel
On Wed, Jul 10, 2013 at 10:23 AM, Scott Wang
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705340#comment-13705340
]
Joel Koshy commented on KAFKA-969:
--
This seems reasonable, but I'm not fully convinced
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705461#comment-13705461
]
Sriram Subramanian commented on KAFKA-969:
--
The other issues you mention are
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705484#comment-13705484
]
Guozhang Wang commented on KAFKA-969:
-
I think KAFKA-956 is orthogonal to this JIRA. It
[
https://issues.apache.org/jira/browse/KAFKA-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705490#comment-13705490
]
Joel Koshy commented on KAFKA-969:
--
As I already said, I'm +1 on this patch for what it
15 matches
Mail list logo
