Re: Review Request 17263: New producer for Kafka.

2014-01-27 Thread Jay Kreps
> On Jan. 28, 2014, 2:07 a.m., Neha Narkhede wrote: > > clients/src/main/java/kafka/clients/producer/ProducerConfig.java, line 19 > > > > > > I think someone on the mailing list suggested this as well and I agree. > >

[jira] [Updated] (KAFKA-1171) Gradle build for Kafka

2014-01-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1171: --- Attachment: kafka-1171_v6.patch Attaching v6 patch again with the gradle binary jar included. Joe, Could yo

[jira] [Updated] (KAFKA-1171) Gradle build for Kafka

2014-01-27 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1171: --- Attachment: (was: kafka-1171_v6.patch) > Gradle build for Kafka > -- > >

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-27_18:54:53.patch > System test exception handling does not stop b

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883690#comment-13883690 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 28, 2014, 2:55 a.m.) Review request for kafka. Bugs: KAFKA-1212

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-27_18:24:03.patch > System test exception handling does not stop b

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883667#comment-13883667 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 28, 2014, 2:24 a.m.) Review request for kafka. Bugs: KAFKA-1212

Re: Review Request 17263: New producer for Kafka.

2014-01-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review32850 --- Made a first pass over some parts of the code. Will follow up with m

[jira] [Commented] (KAFKA-1227) Code dump of new producer

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883603#comment-13883603 ] Guozhang Wang commented on KAFKA-1227: -- About reasoning the offset in RecordSend, the

[jira] [Commented] (KAFKA-1227) Code dump of new producer

2014-01-27 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883481#comment-13883481 ] Jay Kreps commented on KAFKA-1227: -- Hey Edward, What I actually want for the Cluster con

[jira] [Updated] (KAFKA-930) Integrate preferred replica election logic into kafka

2014-01-27 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriram Subramanian updated KAFKA-930: - Attachment: KAFKA-930_2014-01-27_13:28:51.patch > Integrate preferred replica election log

[jira] [Commented] (KAFKA-930) Integrate preferred replica election logic into kafka

2014-01-27 Thread Sriram Subramanian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883343#comment-13883343 ] Sriram Subramanian commented on KAFKA-930: -- Updated reviewboard https://reviews.ap

Re: Review Request 15711: Patch for KAFKA-930

2014-01-27 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15711/ --- (Updated Jan. 27, 2014, 9:28 p.m.) Review request for kafka. Bugs: KAFKA-930

[jira] [Created] (KAFKA-1231) Support partition shrink (delete partition)

2014-01-27 Thread Marc Labbe (JIRA)
Marc Labbe created KAFKA-1231: - Summary: Support partition shrink (delete partition) Key: KAFKA-1231 URL: https://issues.apache.org/jira/browse/KAFKA-1231 Project: Kafka Issue Type: Wish

Re: Review Request 17263: New producer for Kafka.

2014-01-27 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review32863 --- clients/src/main/java/kafka/clients/producer/internals/BufferPool.j

Re: Review Request 17263: New producer for Kafka.

2014-01-27 Thread Sriram Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17263/#review32808 --- clients/src/main/java/kafka/common/protocol/types/Struct.java

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Guozhang Wang
> On Jan. 27, 2014, 7:01 p.m., Neha Narkhede wrote: > > system_test/utils/kafka_system_test_utils.py, line 1490 > > > > > > wouldn't this only kill the producer that is on localhost. But seems > > like stop_remote_en

[jira] Subscription: outstanding kafka patches

2014-01-27 Thread jira
Issue Subscription Filter: outstanding kafka patches (84 issues) The list of outstanding kafka patches Subscriber: kafka-mailing-list Key Summary KAFKA-1228 Socket Leak on ReplicaFetcherThread https://issues.apache.org/jira/browse/KAFKA-1228 KAFKA-1227 Code dump of new produc

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/#review32857 --- system_test/utils/kafka_system_test_utils.py

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883111#comment-13883111 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

[jira] [Commented] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883116#comment-13883116 ] Guozhang Wang commented on KAFKA-1212: -- Updated reviewboard https://reviews.apache.or

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-27_10:59:24.patch > System test exception handling does not stop b

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 27, 2014, 6:59 p.m.) Review request for kafka. Bugs: KAFKA-1212

[jira] [Updated] (KAFKA-1212) System test exception handling does not stop background producer threads

2014-01-27 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1212: - Attachment: KAFKA-1212_2014-01-27_10:55:11.patch > System test exception handling does not stop b

Re: Review Request 17006: Keep track of local pid and kill it on stopping all entities as discussed with John

2014-01-27 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17006/ --- (Updated Jan. 27, 2014, 6:55 p.m.) Review request for kafka. Bugs: KAFKA-1212

[jira] [Commented] (KAFKA-949) Integrate kafka into YARN

2014-01-27 Thread Sudarshan Kadambi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882966#comment-13882966 ] Sudarshan Kadambi commented on KAFKA-949: - Any timelines on when this will be avail

[jira] [Commented] (KAFKA-1227) Code dump of new producer

2014-01-27 Thread Edward Ribeiro (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882758#comment-13882758 ] Edward Ribeiro commented on KAFKA-1227: --- Hello folks, I've just started to look int