Re: QOS on Producer Side

2014-05-06 Thread Jun Rao
The callback will be invoked on completion. The exception tells you whether the send completed or not. This api will be available in the next release. Thanks, Jun On Mon, May 5, 2014 at 10:03 PM, Bhavesh Mistry mistry.p.bhav...@gmail.comwrote: Thanks for answers. Does the callback get call

[jira] [Created] (KAFKA-1437) ConsumerMetadataResponse should always include coordinator information

2014-05-06 Thread Joel Koshy (JIRA)
Joel Koshy created KAFKA-1437: - Summary: ConsumerMetadataResponse should always include coordinator information Key: KAFKA-1437 URL: https://issues.apache.org/jira/browse/KAFKA-1437 Project: Kafka

[jira] [Created] (KAFKA-1438) Migrate kafka client tools

2014-05-06 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1438: Summary: Migrate kafka client tools Key: KAFKA-1438 URL: https://issues.apache.org/jira/browse/KAFKA-1438 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1352) Reduce logging on the server

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990817#comment-13990817 ] Guozhang Wang commented on KAFKA-1352: -- Another observation from [~jonbringhurst] is

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-05-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990819#comment-13990819 ] Jay Kreps commented on KAFKA-1430: -- The way we garbage collect obsolete entries was

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-05-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990829#comment-13990829 ] Jay Kreps commented on KAFKA-1430: -- A couple of random thoughts. - Not sure if I have

[jira] [Commented] (KAFKA-1430) Purgatory redesign

2014-05-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990853#comment-13990853 ] Jun Rao commented on KAFKA-1430: Yes, it would be good to improve garbage collection in

[jira] [Resolved] (KAFKA-1397) delete topic is not working

2014-05-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1397. Resolution: Fixed Fix Version/s: 0.8.2 Assignee: Timothy Chen Thanks for the patch. +1 and

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-06 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/#review42323 --- The patch doesn't apply any more. Could you rebase?

Review Request 21123: Patch for KAFKA-1437

2014-05-06 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21123/ --- Review request for kafka. Bugs: KAFKA-1437

[jira] [Updated] (KAFKA-1437) ConsumerMetadataResponse should always include coordinator information

2014-05-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1437: -- Attachment: KAFKA-1437.patch ConsumerMetadataResponse should always include coordinator information

[jira] [Commented] (KAFKA-1437) ConsumerMetadataResponse should always include coordinator information

2014-05-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990890#comment-13990890 ] Joel Koshy commented on KAFKA-1437: --- Created reviewboard

Re: QOS on Producer Side

2014-05-06 Thread Bhavesh Mistry
So to retrieve the message that was not transmitted due to error, I will have to store the message in each call back the message and store this in a file.Is there an alternative solution ? What is best way to achieve QOS on producer side ? Also, will new Producer API will work with Broker

[jira] [Commented] (KAFKA-1437) ConsumerMetadataResponse should always include coordinator information

2014-05-06 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990994#comment-13990994 ] Joel Koshy commented on KAFKA-1437: --- Can someone review? (Not sure why the patch update

[jira] [Updated] (KAFKA-1384) Log Broker state

2014-05-06 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Chen updated KAFKA-1384: Attachment: KAFKA-1384_2014-05-06_13:21:14.patch Log Broker state -

Re: Review Request 20718: Patch for KAFKA-1384

2014-05-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20718/ --- (Updated May 6, 2014, 8:21 p.m.) Review request for kafka. Bugs: KAFKA-1384

[jira] [Commented] (KAFKA-1384) Log Broker state

2014-05-06 Thread Timothy Chen (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991080#comment-13991080 ] Timothy Chen commented on KAFKA-1384: - Updated reviewboard

Re: Review for the new consumer APIs

2014-05-06 Thread Neha Narkhede
1) We would like to find out what is latest message per partition that current consumer is connected? I'm not sure I understood what you meant by connected. The new consumer will expose the

[jira] [Commented] (KAFKA-1432) Make num.producerThreads configurable on new MirrrorMaker

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991286#comment-13991286 ] Guozhang Wang commented on KAFKA-1432: -- Created reviewboard against branch

[jira] [Updated] (KAFKA-1432) Make num.producerThreads configurable on new MirrrorMaker

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1432: - Attachment: KAFKA-1432.patch Make num.producerThreads configurable on new MirrrorMaker

Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown issue

2014-05-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21134/ --- Review request for kafka. Bugs: KAFKA-1432

[jira] [Commented] (KAFKA-1432) Make num.producerThreads configurable on new MirrrorMaker

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991293#comment-13991293 ] Guozhang Wang commented on KAFKA-1432: -- Created reviewboard

[jira] [Updated] (KAFKA-1432) Make num.producerThreads configurable on new MirrrorMaker

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1432: - Attachment: KAFKA-1432.patch Make num.producerThreads configurable on new MirrrorMaker

Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown issue

2014-05-06 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/21134/ --- (Updated May 6, 2014, 11:05 p.m.) Review request for kafka. Bugs: KAFKA-1432

Re: Review Request 21134: Fix KAFKA-1432: follow-up on producer shutdown issue

2014-05-06 Thread Guozhang Wang
On May 6, 2014, 11:19 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, line 166 https://reviews.apache.org/r/21134/diff/1/?file=575738#file575738line166 This is a good catch. I'm wondering if we need both though. Shouldn't it suffice to call

[jira] [Resolved] (KAFKA-1384) Log Broker state

2014-05-06 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-1384. Resolution: Fixed Fix Version/s: 0.8.2 Thanks for the patch. +1 and committed to trunk. Log

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-06 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991361#comment-13991361 ] Jay Kreps commented on KAFKA-1316: -- Okay so here is my proposal. I want to refactor out a

[jira] [Commented] (KAFKA-1316) Refactor Sender

2014-05-06 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991379#comment-13991379 ] Guozhang Wang commented on KAFKA-1316: -- I think we also need to refactor out the