Re: Review Request 22496: Patch for KAFKA-1096

2014-06-20 Thread Neha Narkhede
On June 19, 2014, 4:29 a.m., Neha Narkhede wrote: core/src/main/scala/kafka/controller/KafkaController.scala, line 172 https://reviews.apache.org/r/22496/diff/1/?file=608034#file608034line172 I think this should be removed as well. Basically, the only time the broker needs to

Re: Review Request 22802: KAFKA-1308, publish test jars

2014-06-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22802/#review46258 --- Ship it! Ship It! - Neha Narkhede On June 20, 2014, 5:27 a.m.,

[jira] [Comment Edited] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-06-20 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14016078#comment-14016078 ] Otis Gospodnetic edited comment on KAFKA-1481 at 6/20/14 9:41 AM:

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-06-20 Thread Otis Gospodnetic (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038721#comment-14038721 ] Otis Gospodnetic commented on KAFKA-1481: - Nice and simple patch. Question about

Re: Review Request 22802: KAFKA-1308, publish test jars

2014-06-20 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22802/#review46277 --- Hmm, I ran ./gradlew uploadArchivesAll locally, but don't see any

[jira] [Commented] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038923#comment-14038923 ] Sriharsha Chintalapani commented on KAFKA-1283: --- [~nehanarkhede]

[jira] [Commented] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Babak Behzad (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038935#comment-14038935 ] Babak Behzad commented on KAFKA-1283: - Great! I can test this soon. I will let you

[jira] [Updated] (KAFKA-1308) Publish jar of test utilities to Maven

2014-06-20 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-1308: --- Attachment: kafka-1308_v2_0.8.1.patch Attached is a simpler patch for 0.8.1. I do see the test jar copied

[jira] [Created] (KAFKA-1502) source jar is empty

2014-06-20 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1502: -- Summary: source jar is empty Key: KAFKA-1502 URL: https://issues.apache.org/jira/browse/KAFKA-1502 Project: Kafka Issue Type: Bug Affects Versions: 0.8.2

[jira] [Created] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Jianwen Wang (JIRA)
Jianwen Wang created KAFKA-1503: --- Summary: all partitions are using same broker as their leader after broker is down Key: KAFKA-1503 URL: https://issues.apache.org/jira/browse/KAFKA-1503 Project: Kafka

[jira] [Commented] (KAFKA-1308) Publish jar of test utilities to Maven

2014-06-20 Thread Jakob Homan (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039246#comment-14039246 ] Jakob Homan commented on KAFKA-1308: Yes, we need the pom. Publish jar of test

[jira] [Commented] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Babak Behzad (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039275#comment-14039275 ] Babak Behzad commented on KAFKA-1283: - Thanks [~sriharsha]. I pulled the trunk and the

[jira] [Comment Edited] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Babak Behzad (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039275#comment-14039275 ] Babak Behzad edited comment on KAFKA-1283 at 6/20/14 8:19 PM: --

[jira] [Resolved] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede resolved KAFKA-1283. -- Resolution: Fixed Log4jAppender is unable to send the message.

[jira] [Commented] (KAFKA-1283) Log4jAppender is unable to send the message.

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039278#comment-14039278 ] Neha Narkhede commented on KAFKA-1283: -- bq. Neha Narkhede, should I create a new

Re: Review Request 22802: KAFKA-1308, publish test jars

2014-06-20 Thread Neha Narkhede
On June 20, 2014, 3:11 p.m., Jun Rao wrote: Hmm, I ran ./gradlew uploadArchivesAll locally, but don't see any test jar created for publish. hmmm... I think my test jar was lying around from a previous manual build. See the same issue after clearing it and using ./gradlew

[jira] [Updated] (KAFKA-1502) source jar is empty

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1502: - Labels: newbie (was: ) source jar is empty --- Key:

[jira] [Updated] (KAFKA-1502) source jar is empty

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1502: - Component/s: build source jar is empty --- Key: KAFKA-1502

Re: Review Request 22496: Patch for KAFKA-1096

2014-06-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/#review46316 --- core/src/main/scala/kafka/controller/KafkaController.scala

Re: Review Request 22496: Patch for KAFKA-1096

2014-06-20 Thread Sriharsha Chintalapani
On June 20, 2014, 8:35 p.m., Neha Narkhede wrote: core/src/main/scala/kafka/controller/KafkaController.scala, line 878 https://reviews.apache.org/r/22496/diff/1/?file=608034#file608034line878 On second thoughts, we also don't need this API. The controller knows it's epoch when it

Review Request 22841: Patch for KAFKA-1329

2014-06-20 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22841/ --- Review request for kafka. Bugs: KAFKA-1329

[jira] [Updated] (KAFKA-1329) Add metadata fetch and refresh functionality to the consumer

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1329: - Attachment: KAFKA-1329.patch Add metadata fetch and refresh functionality to the consumer

[jira] [Commented] (KAFKA-1329) Add metadata fetch and refresh functionality to the consumer

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039362#comment-14039362 ] Neha Narkhede commented on KAFKA-1329: -- Created reviewboard

[jira] [Updated] (KAFKA-1329) Add metadata fetch and refresh functionality to the consumer

2014-06-20 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1329: - Status: Patch Available (was: In Progress) Add metadata fetch and refresh functionality to the

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039394#comment-14039394 ] Guozhang Wang commented on KAFKA-1503: -- Hello Jianwen, Controller does always pick

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Jianwen Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039417#comment-14039417 ] Jianwen Wang commented on KAFKA-1503: - Hi Guozhang, That is not what I experienced

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Jianwen Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039422#comment-14039422 ] Jianwen Wang commented on KAFKA-1503: - One way to break this loop is to turn on

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Jianwen Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039424#comment-14039424 ] Jianwen Wang commented on KAFKA-1503: - Also, I experienced another issue is that auto

Re: Review Request 22496: Patch for KAFKA-1096

2014-06-20 Thread Sriharsha Chintalapani
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22496/ --- (Updated June 20, 2014, 10:27 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1096) An old controller coming out of long GC could update its epoch to the latest controller's epoch

2014-06-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039470#comment-14039470 ] Sriharsha Chintalapani commented on KAFKA-1096: --- Updated reviewboard

[jira] [Updated] (KAFKA-1096) An old controller coming out of long GC could update its epoch to the latest controller's epoch

2014-06-20 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani updated KAFKA-1096: -- Attachment: KAFKA-1096_2014-06-20_15:27:44.patch An old controller coming out

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Jianwen Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039487#comment-14039487 ] Jianwen Wang commented on KAFKA-1503: - Hi Guozhang, The fully working auto

[jira] [Commented] (KAFKA-1503) all partitions are using same broker as their leader after broker is down

2014-06-20 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039502#comment-14039502 ] Guozhang Wang commented on KAFKA-1503: -- Cool, could you upload your patch as a file