[jira] [Commented] (KAFKA-1377) transient unit test failure in LogOffsetTest

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059734#comment-14059734 ] Manikumar Reddy commented on KAFKA-1377: LogOffsetTests are consistently failing

Review Request 23439: Patch for KAFKA-1258

2014-07-12 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23439/ --- Review request for kafka. Bugs: KAFKA-1258

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059741#comment-14059741 ] Manikumar Reddy commented on KAFKA-1258: Created reviewboard

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1258: --- Attachment: KAFKA-1258.patch Delete temporary data directory after unit test finishes

[jira] [Assigned] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy reassigned KAFKA-1258: -- Assignee: Manikumar Reddy Delete temporary data directory after unit test finishes

[jira] [Commented] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059742#comment-14059742 ] Manikumar Reddy commented on KAFKA-1258: Junit 4.7 can be used to manage temporary

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1258: --- Status: Patch Available (was: Open) Delete temporary data directory after unit test

[jira] [Updated] (KAFKA-1531) zookeeper.connection.timeout.ms is set to 10000000 in configuration file in Kafka tarball

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1531: --- Status: Patch Available (was: Open) zookeeper.connection.timeout.ms is set to 1000 in

Review Request 23440: Patch for KAFKA-1536

2014-07-12 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/ --- Review request for kafka. Bugs: KAFKA-1536

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Change the status of

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059791#comment-14059791 ] Manikumar Reddy commented on KAFKA-1536: Created reviewboard

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1536: --- Attachment: KAFKA-1536.patch Change the status of the JIRA to Patch Available in the

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059793#comment-14059793 ] Manikumar Reddy commented on KAFKA-1536: kafka-patch-review.py script updated to

[jira] [Commented] (KAFKA-167) Move partition assignment to the broker

2014-07-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059796#comment-14059796 ] nicu marasoiu commented on KAFKA-167: - Hi, So I would suggest this: for each consumer

[jira] [Commented] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2014-07-12 Thread nicu marasoiu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059798#comment-14059798 ] nicu marasoiu commented on KAFKA-264: -

[jira] [Updated] (KAFKA-1258) Delete temporary data directory after unit test finishes

2014-07-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1258: - Resolution: Fixed Status: Resolved (was: Patch Available) Committed. Thanks! Delete temporary

Review Request 23442: Patch for KAFKA-1330

2014-07-12 Thread Jay Kreps
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23442/ --- Review request for kafka. Bugs: KAFKA-1330

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059904#comment-14059904 ] Jay Kreps commented on KAFKA-1330: -- Created reviewboard

[jira] [Updated] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jay Kreps updated KAFKA-1330: - Attachment: KAFKA-1330.patch Implement subscribe(TopicPartition...partitions) in the new consumer

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059905#comment-14059905 ] Jay Kreps commented on KAFKA-1330: -- Hey [~nmarasoi], sorry had actually been working on

Build failed in Jenkins: Kafka-trunk #221

2014-07-12 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/221/changes Changes: [jay.kreps] KAFKA-1258 Automatically delete temporary directories with a shutdown hook during tests to avoid leaking temp files. Patch by Manikumar Reddy. -- Started by an SCM change

[jira] [Commented] (KAFKA-1330) Implement subscribe(TopicPartition...partitions) in the new consumer

2014-07-12 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059906#comment-14059906 ] Jay Kreps commented on KAFKA-1330: -- Guys, I posted a very rough draft that implements

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1536: - Status: In Progress (was: Patch Available) Change the status of the JIRA to Patch Available in

Review Request 23444: test

2014-07-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23444/ --- Review request for kafka. Bugs: KAFKA-1536

[jira] [Updated] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1536: - Attachment: KAFKA-1536.patch Change the status of the JIRA to Patch Available in the

Review Request 23445: test

2014-07-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23445/ --- Review request for kafka. Bugs: KAFKA-1538

[jira] [Created] (KAFKA-1538) TEST JIRA for KAFKA-1536

2014-07-12 Thread Guozhang Wang (JIRA)
Guozhang Wang created KAFKA-1538: Summary: TEST JIRA for KAFKA-1536 Key: KAFKA-1538 URL: https://issues.apache.org/jira/browse/KAFKA-1538 Project: Kafka Issue Type: Test

[jira] [Commented] (KAFKA-1536) Change the status of the JIRA to Patch Available in the kafka-review-tool

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059974#comment-14059974 ] Guozhang Wang commented on KAFKA-1536: -- Created reviewboard

Re: Review Request 23440: Patch for KAFKA-1536

2014-07-12 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23440/#review47688 --- Ship it! Local test works. - Guozhang Wang On July 12, 2014,

[jira] [Commented] (KAFKA-1538) TEST JIRA for KAFKA-1536

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14059975#comment-14059975 ] Guozhang Wang commented on KAFKA-1538: -- Created reviewboard

[jira] [Updated] (KAFKA-1538) TEST JIRA for KAFKA-1536

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1538: - Assignee: Guozhang Wang Status: Patch Available (was: Open) TEST JIRA for KAFKA-1536

[jira] [Updated] (KAFKA-1538) TEST JIRA for KAFKA-1536

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1538: - Attachment: KAFKA-1538.patch TEST JIRA for KAFKA-1536

[jira] [Updated] (KAFKA-264) Change the consumer side load balancing and distributed co-ordination to use a consumer co-ordinator

2014-07-12 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-264: Description: A high level design for the zookeeper consumer is here -

Re: Can I get a review on KAFKA-1512?

2014-07-12 Thread Gwen Shapira
Looks like Jun's comments on review board were not addressed? They seem valid to me - especially the points about IPv6 (seen this at some customers) and InetAddress having both host and port. Gwen On Sat, Jul 12, 2014 at 1:21 PM, Jay Kreps jay.kr...@gmail.com wrote: Thx, -Jay