Re: Review Request 24704: Patch for KAFKA-1499

2014-09-21 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24704/ --- (Updated Sept. 21, 2014, 10:30 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1499) Broker-side compression configuration

2014-09-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-1499: --- Attachment: KAFKA-1499_2014-09-21_15:57:23.patch Broker-side compression configuration

[jira] [Commented] (KAFKA-1499) Broker-side compression configuration

2014-09-21 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142413#comment-14142413 ] Manikumar Reddy commented on KAFKA-1499: Updated reviewboard

Re: Review Request 24704: Patch for KAFKA-1499

2014-09-21 Thread Manikumar Reddy O
On Sept. 19, 2014, 8:26 p.m., Joel Koshy wrote: core/src/test/scala/unit/kafka/log/BrokerCompressionTest.scala, line 55 https://reviews.apache.org/r/24704/diff/6/?file=666213#file666213line55 Should this just be part of LogTest instead? I used parameterized test to test all the

[jira] [Commented] (KAFKA-1558) AdminUtils.deleteTopic does not work

2014-09-21 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142481#comment-14142481 ] Neha Narkhede commented on KAFKA-1558: -- This is great, [~sriharsha]. Thanks for

[jira] [Commented] (KAFKA-1558) AdminUtils.deleteTopic does not work

2014-09-21 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142636#comment-14142636 ] Sriharsha Chintalapani commented on KAFKA-1558: --- [~nehanarkhede] 3 and 5

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-21 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Attachment: KAFKA-1618-REVIEW-COMMENTS.patch Patch attached after implementing review comments.

[jira] [Updated] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-21 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1618: -- Status: In Progress (was: Patch Available) Updated patch after review comments Exception

[jira] [Assigned] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-21 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri reassigned KAFKA-1618: - Assignee: BalajiSeshadri (was: Balaji Seshadri) Exception thrown when running console

[jira] [Commented] (KAFKA-1618) Exception thrown when running console producer with no port number for the broker

2014-09-21 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142716#comment-14142716 ] BalajiSeshadri commented on KAFKA-1618: --- [~nehanarkhede] Sorry couldnt fix the space

[jira] [Commented] (KAFKA-1590) Binarize trace level request logging along with debug level text logging

2014-09-21 Thread Abhishek Sharma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14142913#comment-14142913 ] Abhishek Sharma commented on KAFKA-1590: [~guozhang] and [~nehanarkhede] - Do we

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-09-21 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555.0.patch Tested the change with a 3-broker cluster. Taking one broker down to

Review Request 25886: KAFKA-1555: provide strong consistency with reasonable availability

2014-09-21 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25886/ --- Review request for kafka. Repository: kafka Description --- KAFKA-1555: