[jira] [Updated] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-31 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vladimir Tretyakov updated KAFKA-1481: -- Attachment: KAFKA-1481_2014-10-31_14-35-43.patch Stop using dashes AND underscores as

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-31 Thread Vladimir Tretyakov (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191698#comment-14191698 ] Vladimir Tretyakov commented on KAFKA-1481: --- Hi Jun, added new one, changed

[jira] [Created] (KAFKA-1741) consumer get always old messages

2014-10-31 Thread hamza ezzi (JIRA)
hamza ezzi created KAFKA-1741: - Summary: consumer get always old messages Key: KAFKA-1741 URL: https://issues.apache.org/jira/browse/KAFKA-1741 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1733) Producer.send will block indeterminately when broker is unavailable.

2014-10-31 Thread R. Tyler Croy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192003#comment-14192003 ] R. Tyler Croy commented on KAFKA-1733: -- [~junrao] we are seeing this behavior against

[jira] [Commented] (KAFKA-1481) Stop using dashes AND underscores as separators in MBean names

2014-10-31 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192034#comment-14192034 ] Jun Rao commented on KAFKA-1481: Thanks for the patch. A few more comments. 50.

Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- Review request for kafka. Bugs: KAFKA-1720

[jira] [Updated] (KAFKA-1720) [Renaming / Comments] Delayed Operations

2014-10-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1720: - Status: Patch Available (was: Open) [Renaming / Comments] Delayed Operations

[jira] [Updated] (KAFKA-1720) [Renaming / Comments] Delayed Operations

2014-10-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1720: - Attachment: KAFKA-1720.patch [Renaming / Comments] Delayed Operations

Re: MBeans, dashes, underscores, and KAFKA-1481

2014-10-31 Thread Jun Rao
To circle back on this thread. The patch in kafka-1482 is almost ready. To make the mbean names more meaningful and easier to parse, the patch will use explicit key/value pairs in the mbean name for things like clientId and topic, and will get rid of the quotes. So, instead of

Re: MBeans, dashes, underscores, and KAFKA-1481

2014-10-31 Thread Joel Koshy
That sounds good, although is that the only change (sorry I have not done a careful review of that patch and would like to before it gets checked in). On Fri, Oct 31, 2014 at 10:42:13AM -0700, Jun Rao wrote: To circle back on this thread. The patch in kafka-1482 is almost ready. To make the

Re: MBeans, dashes, underscores, and KAFKA-1481

2014-10-31 Thread Jun Rao
Yes, all changes are related to metric names. Feel free to review the patch. Thanks, Jun On Fri, Oct 31, 2014 at 10:48 AM, Joel Koshy jjkosh...@gmail.com wrote: That sounds good, although is that the only change (sorry I have not done a careful review of that patch and would like to before

[jira] [Commented] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192223#comment-14192223 ] Joel Koshy commented on KAFKA-1555: --- Given the current implementation, I think the

Re: Review Request 24676: Fix KAFKA-1583

2014-10-31 Thread Guozhang Wang
On Oct. 31, 2014, 6:08 p.m., Jun Rao wrote: core/src/main/scala/kafka/cluster/Partition.scala, line 236 https://reviews.apache.org/r/24676/diff/13/?file=735940#file735940line236 Could we get rid of = since this method is supposed to not return any value? Thanks Jun. I will

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-10-31 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-1476: -- Attachment: KAFKA-1476-REVIEW-COMMENTS.patch [~nehanarkhede] Please find patch attached. Get

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-10-31 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192269#comment-14192269 ] BalajiSeshadri commented on KAFKA-1476: --- [~nehanarkhede] Can i get commiter access

[jira] [Created] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Onur Karaman (JIRA)
Onur Karaman created KAFKA-1742: --- Summary: ControllerContext removeTopic does not correctly update state Key: KAFKA-1742 URL: https://issues.apache.org/jira/browse/KAFKA-1742 Project: Kafka

[jira] [Assigned] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat reassigned KAFKA-1742: -- Assignee: Mayuresh Gharat ControllerContext removeTopic does not correctly update

[jira] [Updated] (KAFKA-1733) Producer.send will block indeterminately when broker is unavailable.

2014-10-31 Thread Marc Chung (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc Chung updated KAFKA-1733: -- Attachment: (was: kafka-1733-add-connectTimeoutMs.patch) Producer.send will block indeterminately

[jira] [Assigned] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Onur Karaman reassigned KAFKA-1742: --- Assignee: Onur Karaman (was: Mayuresh Gharat) ControllerContext removeTopic does not

[jira] [Updated] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Joel Koshy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1742: -- Priority: Blocker (was: Major) Fix Version/s: 0.8.2 ControllerContext removeTopic does not

Re: Compile failure going from kafka 0.8.1.1 to 0.8.2

2014-10-31 Thread Jack Foy
On Thu, Oct 30, 2014 at 9:20 AM, Jay Kreps jay.kr...@gmail.commailto:jay.kr...@gmail.com wrote: I think we should treat this like a bug for 0.8.2 final, we should be able to add two commitOffsets methods with and without the param which should fix the problem, right? On Oct 30, 2014, at 9:51 AM,

[jira] [Updated] (KAFKA-328) Write unit test for kafka server startup and shutdown API

2014-10-31 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-328?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] BalajiSeshadri updated KAFKA-328: - Attachment: KAFKA-328-REVIEW-COMMENTS.patch [~nehanarkhede] Please review Write unit test for

[GitHub] kafka pull request: Trunk

2014-10-31 Thread futtre
GitHub user futtre opened a pull request: https://github.com/apache/kafka/pull/35 Trunk You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/kafka trunk Alternatively you can review and apply these changes as the patch at:

[jira] [Commented] (KAFKA-1742) ControllerContext removeTopic does not correctly update state

2014-10-31 Thread Onur Karaman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192733#comment-14192733 ] Onur Karaman commented on KAFKA-1742: - partitionLeadershipInfo and

[jira] [Created] (KAFKA-1743) ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible

2014-10-31 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-1743: -- Summary: ConsumerConnector.commitOffsets in 0.8.2 is not backward compatible Key: KAFKA-1743 URL: https://issues.apache.org/jira/browse/KAFKA-1743 Project: Kafka Issue

Re: Compile failure going from kafka 0.8.1.1 to 0.8.2

2014-10-31 Thread Jun Rao
Yes, this is actually indeed an incompatible change. In 0.8.1.x, ConsumerConnector has the following api: def commitOffsets This is changed to the following in 0.8.2 and breaks compatibility def commitOffsets(retryOnFailure: Boolean = true) Filed KAFKA-1743 as an 0.8.2 blocker. Thanks, Jun

Re: Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- (Updated Nov. 1, 2014, 12:21 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1720) [Renaming / Comments] Delayed Operations

2014-10-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14192810#comment-14192810 ] Guozhang Wang commented on KAFKA-1720: -- Updated reviewboard

[jira] [Updated] (KAFKA-1720) [Renaming / Comments] Delayed Operations

2014-10-31 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1720: - Attachment: KAFKA-1720_2014-10-31_17:21:46.patch [Renaming / Comments] Delayed Operations

Re: Review Request 27430: Fix KAFKA-1720

2014-10-31 Thread Gwen Shapira
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review59453 --- Ship it! LGTM :) - Gwen Shapira On Nov. 1, 2014, 12:21 a.m.,

[jira] [Updated] (KAFKA-1555) provide strong consistency with reasonable availability

2014-10-31 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1555: Attachment: KAFKA-1555-DOCS.3.patch Thank you for the detailed review [~jjkoshy]. I think the