Review Request 28694: Patch for KAFKA-1501

2014-12-04 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28694/ --- Review request for kafka. Bugs: KAFKA-1501

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 3, 2014, 11:02 p.m.) Review request for kafka. Bugs:

Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/#review63803 --- Ship it! Ship It! - Joel Koshy On Dec. 3, 2014, 9:34 p.m.,

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 4, 2014, 3:02 a.m.) Review request for kafka. Bugs: KAFKA-1650

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Jiangjie Qin
On Dec. 3, 2014, 6:57 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, line 613 https://reviews.apache.org/r/25995/diff/7/?file=774325#file774325line613 I think there may be a race condition here, for example consider this sequence: 1.

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Jiangjie Qin
On Dec. 3, 2014, 6:57 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, line 613 https://reviews.apache.org/r/25995/diff/7/?file=774325#file774325line613 I think there may be a race condition here, for example consider this sequence: 1.

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Guozhang Wang
On Dec. 3, 2014, 6:57 p.m., Guozhang Wang wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, line 613 https://reviews.apache.org/r/25995/diff/7/?file=774325#file774325line613 I think there may be a race condition here, for example consider this sequence: 1.

Re: Review Request 28481: Patch for KAFKA-1792

2014-12-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/#review63757 --- core/src/main/scala/kafka/admin/AdminUtils.scala

Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Guozhang Wang
On Nov. 25, 2014, 5:50 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/ReplicaManager.scala, line 87 https://reviews.apache.org/r/27430/diff/2/?file=746549#file746549line87 In Kafka-1583 we had discussed renaming ReplicaManager to ReplicatedLogManager or something like

Re: Review Request 27430: Fix KAFKA-1720

2014-12-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27430/ --- (Updated Dec. 3, 2014, 9:34 p.m.) Review request for kafka. Bugs: KAFKA-1720

Re: Review Request 28481: Patch for KAFKA-1792

2014-12-04 Thread Dmitry Pekar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28481/ --- (Updated Dec. 3, 2014, 5:25 p.m.) Review request for kafka. Bugs: KAFKA-1792

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review63703 --- core/src/main/scala/kafka/tools/MirrorMaker.scala

[jira] [Commented] (KAFKA-1642) [Java New Producer Kafka Trunk] CPU Usage Spike to 100% when network connection is lost

2014-12-04 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234297#comment-14234297 ] Bhavesh Mistry commented on KAFKA-1642: --- [~ewencp], 1) I will posted toward

[jira] [Commented] (KAFKA-1476) Get a list of consumer groups

2014-12-04 Thread BalajiSeshadri (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234415#comment-14234415 ] BalajiSeshadri commented on KAFKA-1476: --- [~nehanarkhede] or [~junrao] or [~jkreps]

Re: [DISCUSSION] adding the serializer api back to the new java producer

2014-12-04 Thread Jiangjie Qin
I'm just thinking instead of binding serialization with producer, another option is to bind serializer/deserializer with ProducerRecord/ConsumerRecord (please see the detail proposal below.) The arguments for this option is: A. A single producer could send different message

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Guozhang Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/#review63878 --- Ship it! Ship It! - Guozhang Wang On Dec. 4, 2014, 3:02 a.m.,

[jira] [Commented] (KAFKA-1790) Remote controlled shutdown was removed

2014-12-04 Thread James Oliver (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234496#comment-14234496 ] James Oliver commented on KAFKA-1790: - Thanks for the input, Joel. We'll keep that in

[jira] [Commented] (KAFKA-1772) Add an Admin message type for request response

2014-12-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234530#comment-14234530 ] Jun Rao commented on KAFKA-1772: It makes sense to have a single ClusterMetadata request

[jira] [Commented] (KAFKA-1790) Remote controlled shutdown was removed

2014-12-04 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234545#comment-14234545 ] Jun Rao commented on KAFKA-1790: James, Thanks for the explanation. It seems that not

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-04 Thread Jiangjie Qin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25995/ --- (Updated Dec. 4, 2014, 7:59 p.m.) Review request for kafka. Bugs: KAFKA-1650

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234554#comment-14234554 ] Jiangjie Qin commented on KAFKA-1650: - Updated reviewboard

[jira] [Updated] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin updated KAFKA-1650: Attachment: KAFKA-1650_2014-12-04_11:59:07.patch Mirror Maker could lose data on unclean shutdown.

[jira] [Commented] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234557#comment-14234557 ] Jiangjie Qin commented on KAFKA-1650: - [~junrao] Could you also help review the patch

[jira] [Comment Edited] (KAFKA-1650) Mirror Maker could lose data on unclean shutdown.

2014-12-04 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234557#comment-14234557 ] Jiangjie Qin edited comment on KAFKA-1650 at 12/4/14 8:02 PM: --

[jira] [Commented] (KAFKA-1788) producer record can stay in RecordAccumulator forever if leader is no available

2014-12-04 Thread Bhavesh Mistry (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234595#comment-14234595 ] Bhavesh Mistry commented on KAFKA-1788: --- We also need to fix the Producer Close

[jira] [Commented] (KAFKA-727) broker can still expose uncommitted data to a consumer

2014-12-04 Thread lokesh Birla (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234678#comment-14234678 ] lokesh Birla commented on KAFKA-727: Hi, Is this really fixed? I still see this issue

Build failed in Jenkins: Kafka-trunk #348

2014-12-04 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/348/ -- [...truncated 827 lines...] java.net.BindException: Address already in use at sun.nio.ch.Net.bind(Native Method) at

[jira] [Created] (KAFKA-1806) broker can still expose uncommitted data to a consumer

2014-12-04 Thread lokesh Birla (JIRA)
lokesh Birla created KAFKA-1806: --- Summary: broker can still expose uncommitted data to a consumer Key: KAFKA-1806 URL: https://issues.apache.org/jira/browse/KAFKA-1806 Project: Kafka Issue

[jira] [Commented] (KAFKA-1795) OOME - high level kafka consumer

2014-12-04 Thread Umesh Batra (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234738#comment-14234738 ] Umesh Batra commented on KAFKA-1795: Please ignore; I figured it out and leak was

[jira] [Resolved] (KAFKA-1795) OOME - high level kafka consumer

2014-12-04 Thread Umesh Batra (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Umesh Batra resolved KAFKA-1795. Resolution: Not a Problem The issue was with downstream post consumer component and not with Kafka.

[jira] [Closed] (KAFKA-1795) OOME - high level kafka consumer

2014-12-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede closed KAFKA-1795. OOME - high level kafka consumer Key: KAFKA-1795

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-12-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1476: - Assignee: (was: BalajiSeshadri) Get a list of consumer groups -

[jira] [Updated] (KAFKA-1476) Get a list of consumer groups

2014-12-04 Thread Neha Narkhede (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neha Narkhede updated KAFKA-1476: - Assignee: Balaji Seshadri Get a list of consumer groups -

Re: [DISCUSSION] adding the serializer api back to the new java producer

2014-12-04 Thread Jay Kreps
I agree that having the new ProducerK, V(KeySerializerK, ValueSerializerV) interface would be useful. People suggested cases where you want to mix and match serialization types. The ByteArraySerializer is a no-op that would give the current behavior so any odd case where you need to mix and match

[jira] [Commented] (KAFKA-1755) Improve error handling in log cleaner

2014-12-04 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234780#comment-14234780 ] Guozhang Wang commented on KAFKA-1755: -- Here are my two cents: 1. At the end of the

[jira] [Commented] (KAFKA-1173) Using Vagrant to get up and running with Apache Kafka

2014-12-04 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234816#comment-14234816 ] Joe Stein commented on KAFKA-1173: -- [~ewencp] fell off my radar some will circle back on

[jira] [Created] (KAFKA-1807) Improve accuracy of ProducerPerformance target throughput

2014-12-04 Thread Ewen Cheslack-Postava (JIRA)
Ewen Cheslack-Postava created KAFKA-1807: Summary: Improve accuracy of ProducerPerformance target throughput Key: KAFKA-1807 URL: https://issues.apache.org/jira/browse/KAFKA-1807 Project:

Review Request 28735: Patch for KAFKA-1807

2014-12-04 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28735/ --- Review request for kafka. Bugs: KAFKA-1807

[jira] [Updated] (KAFKA-1807) Improve accuracy of ProducerPerformance target throughput

2014-12-04 Thread Lam Thien Son (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lam Thien Son updated KAFKA-1807: - Status: Patch Available (was: Open) Improve accuracy of ProducerPerformance target throughput

[jira] [Commented] (KAFKA-1807) Improve accuracy of ProducerPerformance target throughput

2014-12-04 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14234940#comment-14234940 ] Ewen Cheslack-Postava commented on KAFKA-1807: -- Created reviewboard

[jira] [Updated] (KAFKA-1807) Improve accuracy of ProducerPerformance target throughput

2014-12-04 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1807: - Attachment: KAFKA-1807.patch Improve accuracy of ProducerPerformance target

Re: Review Request 28735: Patch for KAFKA-1807

2014-12-04 Thread Neha Narkhede
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28735/#review63953 --- Ship it! Ship It! - Neha Narkhede On Dec. 5, 2014, 2:21 a.m.,