Review Request 28793: Patch for KAFKA-1784

2014-12-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/ --- Review request for kafka. Bugs: KAFKA-1784

Re: Review Request 28793: Patch for KAFKA-1784

2014-12-07 Thread Mayuresh Gharat
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28793/ --- (Updated Dec. 7, 2014, 7:43 p.m.) Review request for kafka. Bugs: KAFKA-1784

[jira] [Commented] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-07 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237248#comment-14237248 ] Mayuresh Gharat commented on KAFKA-1784: Created reviewboard

[jira] [Updated] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-07 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1784: --- Attachment: KAFKA-1784.patch Implement a ConsumerOffsetClient library

[jira] [Updated] (KAFKA-1784) Implement a ConsumerOffsetClient library

2014-12-07 Thread Mayuresh Gharat (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayuresh Gharat updated KAFKA-1784: --- Status: Patch Available (was: Open) Implement a ConsumerOffsetClient library

[jira] [Updated] (KAFKA-1694) kafka command line and centralized operations

2014-12-07 Thread Andrii Biletskyi (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Biletskyi updated KAFKA-1694: Attachment: KAFKA-1772_1802_1775_1774.patch I've added a single patch that covers all

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-07 Thread Jun Rao
On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 529-530 https://reviews.apache.org/r/25995/diff/10/?file=782732#file782732line529 Does that imply there is always an offset? Is that always true? I don't quite follow how

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-07 Thread Jiangjie Qin
On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 529-530 https://reviews.apache.org/r/25995/diff/10/?file=782732#file782732line529 Does that imply there is always an offset? Is that always true? I don't quite follow how

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-07 Thread Jun Rao
On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 529-530 https://reviews.apache.org/r/25995/diff/10/?file=782732#file782732line529 Does that imply there is always an offset? Is that always true? I don't quite follow how

Re: Review Request 25995: Patch for KAFKA-1650

2014-12-07 Thread Jiangjie Qin
On Dec. 6, 2014, 5:17 p.m., Jun Rao wrote: core/src/main/scala/kafka/tools/MirrorMaker.scala, lines 529-530 https://reviews.apache.org/r/25995/diff/10/?file=782732#file782732line529 Does that imply there is always an offset? Is that always true? I don't quite follow how