Review Request 31816: Fix for KAFKA-527

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31816/ --- Review request for kafka. Bugs: KAFKA-527

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351186#comment-14351186 ] Jiangjie Qin commented on KAFKA-1660: - Thanks for the quick response

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351159#comment-14351159 ] Jiangjie Qin commented on KAFKA-1660: - [~parth.brahmbhatt] Have you got a chance to

[jira] [Commented] (KAFKA-2003) Add upgrade tests

[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351184#comment-14351184 ] Guozhang Wang commented on KAFKA-2003: -- Are these three tickets concerning the same

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351179#comment-14351179 ] Parth Brahmbhatt commented on KAFKA-1660: - No and I wont be able to do it for

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351177#comment-14351177 ] Guozhang Wang commented on KAFKA-527: - Thanks for the patch, this is very promising.

[jira] [Commented] (KAFKA-527) Compression support does numerous byte copies

[ https://issues.apache.org/jira/browse/KAFKA-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351180#comment-14351180 ] Guozhang Wang commented on KAFKA-527: - Created reviewboard

[jira] [Commented] (KAFKA-2003) Add upgrade tests

[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14351199#comment-14351199 ] Gwen Shapira commented on KAFKA-2003: - I think this one is a dupe of KAFKA-1888, but

[jira] [Assigned] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jiangjie Qin reassigned KAFKA-1660: --- Assignee: Jiangjie Qin (was: Parth Brahmbhatt) Ability to call close() with a timeout on

[jira] [Updated] (KAFKA-2007) update offsetrequest for more useful information we have on broker about partition

[ https://issues.apache.org/jira/browse/KAFKA-2007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Stein updated KAFKA-2007: - Description: this will need a KIP via [~jkreps] in KIP-6 discussion about KAFKA-1694 The other

[jira] [Created] (KAFKA-2006) switch the broker server over to the new java protocol definitions

Joe Stein created KAFKA-2006: Summary: switch the broker server over to the new java protocol definitions Key: KAFKA-2006 URL: https://issues.apache.org/jira/browse/KAFKA-2006 Project: Kafka

[jira] [Created] (KAFKA-2007) update offsetrequest for more useful information we have on broker about partition

Joe Stein created KAFKA-2007: Summary: update offsetrequest for more useful information we have on broker about partition Key: KAFKA-2007 URL: https://issues.apache.org/jira/browse/KAFKA-2007 Project:

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350126#comment-14350126 ] Honghai Chen edited comment on KAFKA-1646 at 3/6/15 9:01 AM: -

Re: [DISCUSS] KIP-11- Authorization design for kafka security

Hi Parth, Thanks for putting this together. Overall it looks good to me. Although AdminUtils is a concern KIP-4 can probably fix that part. Thanks, Harsha On Thu, Mar 5, 2015, at 10:39 AM, Parth Brahmbhatt wrote: Forgot to add links to wiki and jira. Link

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350126#comment-14350126 ] Honghai Chen edited comment on KAFKA-1646 at 3/6/15 8:59 AM: -

Re: Review Request 29091: Improve 1646 fix by truncate extra space when clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated March 6, 2015, 9:11 a.m.) Review request for kafka. Changes ---

[jira] [Comment Edited] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350126#comment-14350126 ] Honghai Chen edited comment on KAFKA-1646 at 3/6/15 9:02 AM: -

Review Request 31806: Patch for KAFKA-1501

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31806/ --- Review request for kafka. Bugs: KAFKA-1501

Re: [DISCUSS] KIP-6 - New reassignment partition logic for re-balancing

I am +1 Todd's suggestion, the default reassignment scheme is only used when a reassignment command is issued with no scheme specified, and changing this default scheme should not automatically trigger a reassignment of all existing topics: it will only take effect when the next reassignment

[jira] [Updated] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-1501: - Attachment: KAFKA-1501.patch transient unit tests failures due to port already

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350725#comment-14350725 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Uploaded a wip patch. It gets

[jira] [Commented] (KAFKA-1501) transient unit tests failures due to port already in use

[ https://issues.apache.org/jira/browse/KAFKA-1501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350706#comment-14350706 ] Ewen Cheslack-Postava commented on KAFKA-1501: -- Created reviewboard

Re: Review Request 31369: Patch for KAFKA-1982

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31369/#review75529 --- Ship it! Thats a really sweet producer example :) LGTM. - Gwen

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

On March 5, 2015, 10:42 p.m., Onur Karaman wrote: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java, lines 137-138 https://reviews.apache.org/r/31650/diff/1/?file=882439#file882439line137 This is really minor, but are longs necessary for these

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

Re: Review Request 31591: Patch for KAFKA-1992

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/ --- (Updated March 6, 2015, 9:34 p.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350933#comment-14350933 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard

[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350942#comment-14350942 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard

[jira] [Commented] (KAFKA-2003) Add upgrade tests

[ https://issues.apache.org/jira/browse/KAFKA-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350973#comment-14350973 ] Gwen Shapira commented on KAFKA-2003: - Something like that :) 1. We may need two

[jira] [Updated] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1992: Attachment: KAFKA-1992_2015-03-06_13:34:20.patch Following KAFKA-1697,

[jira] [Updated] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1992: Attachment: KAFKA-1992_2015-03-06_13:36:32.patch Following KAFKA-1697,

Re: Review Request 31591: Patch for KAFKA-1992

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/ --- (Updated March 6, 2015, 9:36 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira updated KAFKA-1992: Attachment: KAFKA-1992_2015-03-06_13:37:39.patch Following KAFKA-1697,

Re: Review Request 31591: Patch for KAFKA-1992

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31591/ --- (Updated March 6, 2015, 9:37 p.m.) Review request for kafka. Bugs:

Re: Review Request 31650: Drag Coordinator and FetchManager out of KafkaConsumer, fix a bunch of consumer test issues

On March 5, 2015, 11:39 p.m., Onur Karaman wrote: clients/src/test/java/org/apache/kafka/clients/consumer/internals/CoordinatorTest.java, line 83 https://reviews.apache.org/r/31650/diff/2/?file=886350#file886350line83 I think these scenarios should be split up into separate

[jira] [Commented] (KAFKA-1992) Following KAFKA-1697, checkEnoughReplicasReachOffset doesn't need to get requiredAcks

[ https://issues.apache.org/jira/browse/KAFKA-1992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350940#comment-14350940 ] Gwen Shapira commented on KAFKA-1992: - Updated reviewboard

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) Improve consumer

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350101#comment-14350101 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150306_002850.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350110#comment-14350110 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150306_003432.patch Improve consumer read performance for Windows

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150306_003722.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350118#comment-14350118 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150306_004321.patch Improve consumer read performance for Windows

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350121#comment-14350121 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch

Re: Review Request 29091: Improve 1646 fix by truncate extra space when clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated March 6, 2015, 8:48 a.m.) Review request for kafka. Summary

Re: Review Request 29091: Improve 1646 fix by truncate extra space when clean shutdown

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29091/ --- (Updated March 6, 2015, 8:51 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150306_002850.patch) Improve consumer read performance for

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150306_004321.patch) Improve consumer read performance for

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150306_004014.patch) Improve consumer read performance for

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: (was: KAFKA-1646_20150306_003432.patch) Improve consumer read performance for

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14350126#comment-14350126 ] Honghai Chen commented on KAFKA-1646: - Updated reviewboard against branch

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) Improve consumer

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) Improve consumer

[jira] [Issue Comment Deleted] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Comment: was deleted (was: Updated reviewboard against branch origin/0.8.1) Improve consumer

[jira] [Updated] (KAFKA-1646) Improve consumer read performance for Windows

[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Honghai Chen updated KAFKA-1646: Attachment: KAFKA-1646_20150306_005526.patch Improve consumer read performance for Windows