[jira] [Commented] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-04-01 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390168#comment-14390168 ] Ismael Juma commented on KAFKA-2039: Is there anything I can do to help move this

Re: Any idea why acceptor is volatile in SocketServer?

2015-04-01 Thread Gwen Shapira
Thanks! Yeah, the shutdown hook will run on a separate thread. In that case, I don't need (or want) to keep acceptors in ConcurrentHashMap - we are either starting up or shutting down a broker, but don't want to do both at same time. I'll just synchronize the acceptors startup and shutdown in

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390783#comment-14390783 ] Sriharsha Chintalapani commented on KAFKA-2073: --- [~gwenshap] are you

[jira] [Commented] (KAFKA-2074) Add UpdateMetadata request/response to o.a.k.common.requests and replace its use in core module

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390780#comment-14390780 ] Sriharsha Chintalapani commented on KAFKA-2074: --- [~gwenshap] are you

Re: kafka system tests

2015-04-01 Thread Harsha
Geoffrey, One thing I want to consider in re-writing the system tests is the ability to run these on other OS not just linux. If we can support both linux and windows that will be great. I am not sure how much of that work will be involved on the

Re: Does system_test work on MacOs?

2015-04-01 Thread Gwen Shapira
Thanks for confirming :) On Wed, Apr 1, 2015 at 8:42 AM, Jun Rao j...@confluent.io wrote: Yes, I was able to run the system tests on mac, after enabling ssh. Thanks, Jun On Tue, Mar 31, 2015 at 6:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, The first line of the system_test

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390801#comment-14390801 ] Sriharsha Chintalapani commented on KAFKA-2073: --- Thanks :) [~gwenshap]

Re: Any idea why acceptor is volatile in SocketServer?

2015-04-01 Thread Jun Rao
Yes. That sounds good. It also fixes the visibility of processors, which seems to have a potential issue now. Thanks, Jun On Tue, Mar 31, 2015 at 11:25 PM, Gwen Shapira gshap...@cloudera.com wrote: Thanks! Yeah, the shutdown hook will run on a separate thread. In that case, I don't need

[jira] [Assigned] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-2073: - Assignee: Sriharsha Chintalapani Replace TopicMetadata request/response

[jira] [Assigned] (KAFKA-2074) Add UpdateMetadata request/response to o.a.k.common.requests and replace its use in core module

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sriharsha Chintalapani reassigned KAFKA-2074: - Assignee: Sriharsha Chintalapani Add UpdateMetadata request/response to

[jira] [Commented] (KAFKA-2073) Replace TopicMetadata request/response with o.a.k.requests.metadata

2015-04-01 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390790#comment-14390790 ] Gwen Shapira commented on KAFKA-2073: - Take as many of these as you want, my friend. I

Re: Does system_test work on MacOs?

2015-04-01 Thread Jun Rao
Yes, I was able to run the system tests on mac, after enabling ssh. Thanks, Jun On Tue, Mar 31, 2015 at 6:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, The first line of the system_test README says: This test framework currently doesn't support MacOS due to different ps argument

[jira] [Created] (KAFKA-2086) testRoundRobinPartitionAssignor transient failure

2015-04-01 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2086: -- Summary: testRoundRobinPartitionAssignor transient failure Key: KAFKA-2086 URL: https://issues.apache.org/jira/browse/KAFKA-2086 Project: Kafka Issue Type: Sub-task

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392017#comment-14392017 ] Evan Huus commented on KAFKA-2082: -- I have pushed another branch called

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391877#comment-14391877 ] Evan Huus commented on KAFKA-2082: -- The 3GB is only set if you use VMware fusion, if you

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391999#comment-14391999 ] Tong Li commented on KAFKA-1926: [~junrao]Thanks so much for the quick review. All the new

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2082: - Description: While running integration tests for Sarama (the go client) we came across a pattern of

Build failed in Jenkins: KafkaPreCommit #50

2015-04-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/50/changes Changes: [junrao] kafka-2013; benchmark test for the purgatory; patched by Yasuhiro Matsuda; reviewed by Jun Rao -- [...truncated 2090 lines...] kafka.admin.DeleteTopicTest

[jira] [Updated] (KAFKA-2013) benchmark test for the purgatory

2015-04-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2013: --- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Thanks for

Build failed in Jenkins: Kafka-trunk #438

2015-04-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/438/changes Changes: [junrao] kafka-2013; benchmark test for the purgatory; patched by Yasuhiro Matsuda; reviewed by Jun Rao -- [...truncated 2229 lines...] kafka.message.MessageWriterTest

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391990#comment-14391990 ] Tong Li commented on KAFKA-1926: Updated reviewboard https://reviews.apache.org/r/32740/

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926_2015-04-01_22:16:46.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

Re: Review Request 30809: Patch for KAFKA-1888

2015-04-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30809/#review78630 --- Thanks for the patch. A few high level comments. 1. I think we are

Re: Review Request 32740: Patch for KAFKA-1926

2015-04-01 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/ --- (Updated April 2, 2015, 2:16 a.m.) Review request for kafka. Bugs:

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-04-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391970#comment-14391970 ] Jun Rao commented on KAFKA-2078: Do you see ZK session timeout on the broker? With large

[jira] [Comment Edited] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-04-01 Thread Aravind (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392123#comment-14392123 ] Aravind edited comment on KAFKA-2078 at 4/2/15 4:30 AM: Hi Jun,

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-04-01 Thread Aravind (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14392123#comment-14392123 ] Aravind commented on KAFKA-2078: Hi Jun, There is no ZK session timeout on the broker. I

[jira] [Assigned] (KAFKA-2064) Replace ConsumerMetadataRequest and Response with org.apache.kafka.common.requests objects

2015-04-01 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Holoman reassigned KAFKA-2064: --- Assignee: Jeff Holoman Replace ConsumerMetadataRequest and Response with

[jira] [Commented] (KAFKA-1660) Ability to call close() with a timeout on the Java Kafka Producer.

2015-04-01 Thread Jiangjie Qin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14390958#comment-14390958 ] Jiangjie Qin commented on KAFKA-1660: - [~jkreps] Ping to see if you could help review

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review78444 --- Thanks for the patch! A few comments below.

Review Request 32740: Patch for KAFKA-1926

2015-04-01 Thread Tong Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32740/ --- Review request for kafka. Bugs: KAFKA-1926

[jira] [Commented] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391295#comment-14391295 ] Tong Li commented on KAFKA-1926: [~junrao], all comments have been addressed in the latest

[jira] [Commented] (KAFKA-1929) Convert core kafka module to use the errors in org.apache.kafka.common.errors

2015-04-01 Thread Jeff Holoman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391298#comment-14391298 ] Jeff Holoman commented on KAFKA-1929: - [~jkreps] Did you have a chance to review this?

[jira] [Updated] (KAFKA-1926) Replace kafka.utils.Utils with o.a.k.common.utils.Utils

2015-04-01 Thread Tong Li (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tong Li updated KAFKA-1926: --- Attachment: KAFKA-1926.patch Replace kafka.utils.Utils with o.a.k.common.utils.Utils

Re: Review Request 28769: Patch for KAFKA-1809

2015-04-01 Thread Jun Rao
On March 29, 2015, 7:33 p.m., Jun Rao wrote: core/src/main/scala/kafka/server/KafkaConfig.scala, lines 345-347 https://reviews.apache.org/r/28769/diff/21/?file=908381#file908381line345 It seems that a 3-digit value like 0.8.2 is also valid? Gwen Shapira wrote: yes, and also

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391517#comment-14391517 ] Sriharsha Chintalapani commented on KAFKA-2082: --- [~eapache] did a quick look

Build failed in Jenkins: KafkaPreCommit #49

2015-04-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/KafkaPreCommit/49/changes Changes: [junrao] kafka-2039; Update Scala to 2.10.5 and 2.11.6; patched by Ismael Juma; reviewed by Jun Rao -- [...truncated 2111 lines...] java.net.BindException: Address already in use

[jira] [Created] (KAFKA-2081) testUncleanLeaderElectionEnabledByTopicOverride transient failure

2015-04-01 Thread Jun Rao (JIRA)
Jun Rao created KAFKA-2081: -- Summary: testUncleanLeaderElectionEnabledByTopicOverride transient failure Key: KAFKA-2081 URL: https://issues.apache.org/jira/browse/KAFKA-2081 Project: Kafka Issue

[jira] [Updated] (KAFKA-2039) Update Scala to 2.10.5 and 2.11.6

2015-04-01 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao updated KAFKA-2039: --- Resolution: Fixed Fix Version/s: 0.8.3 Assignee: Ismael Juma Status: Resolved

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-01 Thread Yasuhiro Matsuda
On April 1, 2015, 6:46 p.m., Jun Rao wrote: core/src/main/scala/kafka/server/DelayedOperation.scala, line 126 https://reviews.apache.org/r/31568/diff/2/?file=901425#file901425line126 timeoutTimer is an implementation detail in ExpiredOperationReaper. Could we hide it inside

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-01 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391422#comment-14391422 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-01 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-01_13:49:58.patch New purgatory design

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2082: - Description: While running integration tests for Sarama (the go client) we came across a pattern of

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2082: - Description: While running integration tests for Sarama (the go client) we came across a pattern of

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2082: - Description: While running integration tests for Sarama (the go client) we came across a pattern of

[jira] [Updated] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2082: - Description: While running integration tests for Sarama (the go client) we came across a pattern of

[jira] [Commented] (KAFKA-2078) Getting Selector [WARN] Error in I/O with host java.io.EOFException

2015-04-01 Thread Aravind (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391618#comment-14391618 ] Aravind commented on KAFKA-2078: Also getting few of Connection timed out errors my

RE: [KIP-DISCUSSION] KIP-13 Quotas

2015-04-01 Thread Aditya Auradkar
Hey everyone, I've made changes to the KIP to capture our discussions over the last couple of weeks. https://cwiki.apache.org/confluence/display/KAFKA/KIP-13+-+Quotas I'll start a voting thread after people have had a chance to read/comment. Thanks, Aditya

[jira] [Created] (KAFKA-2083) Quotas for Kafka

2015-04-01 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2083: -- Summary: Quotas for Kafka Key: KAFKA-2083 URL: https://issues.apache.org/jira/browse/KAFKA-2083 Project: Kafka Issue Type: New Feature

[jira] [Created] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

2015-04-01 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2084: -- Summary: byte rate metrics per client ID (producer and consumer) Key: KAFKA-2084 URL: https://issues.apache.org/jira/browse/KAFKA-2084 Project: Kafka

[jira] [Created] (KAFKA-2085) Return delay time in QuotaViolationException

2015-04-01 Thread Aditya Auradkar (JIRA)
Aditya Auradkar created KAFKA-2085: -- Summary: Return delay time in QuotaViolationException Key: KAFKA-2085 URL: https://issues.apache.org/jira/browse/KAFKA-2085 Project: Kafka Issue Type:

[jira] [Commented] (KAFKA-2079) Support exhibitor

2015-04-01 Thread Joe Stein (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391680#comment-14391680 ] Joe Stein commented on KAFKA-2079: -- I think if we do this (which we should) the work

[jira] [Commented] (KAFKA-2082) Kafka Replication ends up in a bad state

2015-04-01 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14391699#comment-14391699 ] Sriharsha Chintalapani commented on KAFKA-2082: --- [~eapache] I am having hard