Re: [KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

2015-04-23 Thread Jay Kreps
Hey Harsha, A few comments: Can you finish up the KIP there are some unfinished sentences and odd whitespace things going on. Here are the questions I think we should consider: 1. Do we need this at all given that we have the partition argument in ProducerRecord which gives full control? I

[jira] [Commented] (KAFKA-1646) Improve consumer read performance for Windows

2015-04-23 Thread Jay Kreps (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509311#comment-14509311 ] Jay Kreps commented on KAFKA-1646: -- So [~waldenchen] next steps for this patch: 1. KIP is

[jira] [Commented] (KAFKA-2077) Add ability to specify a TopicPicker class for KafkaLog4jApender

2015-04-23 Thread Benoy Antony (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509468#comment-14509468 ] Benoy Antony commented on KAFKA-2077: - Could I please get a review of this enhancement

Re: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-04-23 Thread Jay Kreps
Yeah if we understand the optimal policy for a config we always want to set it automatically. In this case I don't think we do yet, but down the road that could be nice. I think for now we should consider this option experimental to give people a chance to try it out. -Jay On Wed, Apr 22, 2015

[jira] [Created] (KAFKA-2142) Follow-up patch for KAFKA-2138 Refactor the drain message logic in new producer

2015-04-23 Thread Jiangjie Qin (JIRA)
Jiangjie Qin created KAFKA-2142: --- Summary: Follow-up patch for KAFKA-2138 Refactor the drain message logic in new producer Key: KAFKA-2142 URL: https://issues.apache.org/jira/browse/KAFKA-2142 Project:

Re: [DISCUSS] KIP 20 Enable log preallocate to improve consume performance under windows and some old Linux file system

2015-04-23 Thread Sriram Subramanian
+1 Some information on how this will be tested would be useful. On 4/23/15 9:33 AM, Jay Kreps jay.kr...@gmail.com wrote: Yeah if we understand the optimal policy for a config we always want to set it automatically. In this case I don't think we do yet, but down the road that could be nice. I

[jira] [Created] (KAFKA-2143) Replicas get ahead of leader and fail

2015-04-23 Thread Evan Huus (JIRA)
Evan Huus created KAFKA-2143: Summary: Replicas get ahead of leader and fail Key: KAFKA-2143 URL: https://issues.apache.org/jira/browse/KAFKA-2143 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-2143) Replicas get ahead of leader and fail

2015-04-23 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus updated KAFKA-2143: - Description: On a cluster of 6 nodes, we recently saw a case where a single under-replicated partition

[jira] [Resolved] (KAFKA-2035) Add a topic config cache.

2015-04-23 Thread Parth Brahmbhatt (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parth Brahmbhatt resolved KAFKA-2035. - Resolution: Invalid Add a topic config cache. -

[jira] [Resolved] (KAFKA-1033) Metadata requests do not always return the complete list of available brokers

2015-04-23 Thread Evan Huus (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Evan Huus resolved KAFKA-1033. -- Resolution: Not A Problem Metadata requests do not always return the complete list of available

[jira] [Created] (KAFKA-2144) Discuss benefits of adding a top level Topic class containing all the topic level details.

2015-04-23 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created KAFKA-2144: --- Summary: Discuss benefits of adding a top level Topic class containing all the topic level details. Key: KAFKA-2144 URL: https://issues.apache.org/jira/browse/KAFKA-2144

[jira] [Created] (KAFKA-2145) An option to add topic owners.

2015-04-23 Thread Parth Brahmbhatt (JIRA)
Parth Brahmbhatt created KAFKA-2145: --- Summary: An option to add topic owners. Key: KAFKA-2145 URL: https://issues.apache.org/jira/browse/KAFKA-2145 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] New consumer offset commit API

2015-04-23 Thread Ewen Cheslack-Postava
Thanks, great feedback everyone. Jiangjie -- I was worried about interleaving as well. For commits using the consumer's own current set of offsets, I agree we could easily limit to 1 outstanding request so the older one gets cancelled. For commits that specify offsets manually, we might not need

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-23 Thread Joel Koshy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32650/#review81413 --- core/src/main/scala/kafka/server/OffsetManager.scala

Re: Review Request 32650: Patch for KAFKA-2000

2015-04-23 Thread Joel Koshy
On April 23, 2015, 9:51 p.m., Joel Koshy wrote: core/src/main/scala/kafka/server/OffsetManager.scala, line 124 https://reviews.apache.org/r/32650/diff/1/?file=909897#file909897line124 A safer fix is to proactively purge as part of UpdateMetadataRequest - i.e., removePartitionInfo

Re: [KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

2015-04-23 Thread Sriharsha Chintalapani
Hi Jay,          Sorry about the KIP formatting . I fixed those in the KIP. 2. We certainly need to add both the serialized and unserialized form for  the key as both are useful.  I added those to the interface. 3. Do we need to add the value? I suspect people will have uses for  computing

Re: Leap second coming up!

2015-04-23 Thread Ewen Cheslack-Postava
Not sure of the best solution, but a couple of ideas: * A lot of code is already setup to use the Time interface. You could use an modification of SystemTime that allows you to start at a specific timestamp. There aren't as many System.currentTimeMillis as I thought there would be so getting them

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

2015-04-23 Thread Neha Narkhede
My understanding is that ideally the 0.8.3 consumer should work with an 0.8.2 broker if the offset commit config was set to zookeeper. The only thing that might not work is offset commit to Kafka, which makes sense since the 0.8.2 broker does not support Kafka based offset management. If we

[jira] [Commented] (KAFKA-2121) prevent potential resource leak in KafkaProducer and KafkaConsumer

2015-04-23 Thread Sean Lydon (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510117#comment-14510117 ] Sean Lydon commented on KAFKA-2121: --- While this does resolve

Should 0.8.3 consumers correctly function with 0.8.2 brokers?

2015-04-23 Thread Sean Lydon
Currently the clients consumer (trunk) sends offset commit requests of version 2. The 0.8.2 brokers fail to handle this particular request with a: java.lang.AssertionError: assertion failed: Version 2 is invalid for OffsetCommitRequest. Valid versions are 0 or 1. I was able to make this work

Re: [KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

2015-04-23 Thread Jay Kreps
Hey Sriharsha, Great, thanks! For 4: Yeah the use case for init and close is making use of any kind of metadata. An example of this would be if you are trying to do range partitioning you need to map lexicographic ranges to numeric partitions. You might do this by adding a new property to the

Remote kafka - Connection refused.

2015-04-23 Thread madhavan kumar
Dear all, I am trying to connect my python consumer to a remote kafka server. But in kafka/conn.py#reinit, the socket call socket.create_connection throws connection refused error. to confirm, it is not a firewall issue, i tried connecting to other servers (in the same machine as kafka server)

[jira] [Commented] (KAFKA-2128) kafka.Kafka should return non-zero exit code when caught exception.

2015-04-23 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510209#comment-14510209 ] Aditya Auradkar commented on KAFKA-2128: +1 kafka.Kafka should return non-zero

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

2015-04-23 Thread Sriharsha Chintalapani (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509101#comment-14509101 ] Sriharsha Chintalapani commented on KAFKA-2091: --- [~azaroth] Here is the KIP

[KIP-DISCUSSION] KIP-22 Expose a Partitioner interface in the new producer

2015-04-23 Thread Sriharsha Chintalapani
Hi, Here is the KIP for adding a partitioner interface for producer. https://cwiki.apache.org/confluence/display/KAFKA/KIP-+22+-+Expose+a+Partitioner+interface+in+the+new+producer There is one open question about how interface should look like. Please take a look and let me know if you

[jira] [Commented] (KAFKA-2091) Expose a Partitioner interface in the new producer

2015-04-23 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14508649#comment-14508649 ] Gianmarco De Francisci Morales commented on KAFKA-2091: --- Hi, I think

[jira] [Updated] (KAFKA-2134) Producer blocked on metric publish

2015-04-23 Thread Vamsi Subhash Achanta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vamsi Subhash Achanta updated KAFKA-2134: - Priority: Blocker (was: Major) Producer blocked on metric publish

[jira] [Commented] (KAFKA-2134) Producer blocked on metric publish

2015-04-23 Thread Vamsi Subhash Achanta (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14509083#comment-14509083 ] Vamsi Subhash Achanta commented on KAFKA-2134: -- We noticed this

[jira] [Commented] (KAFKA-2128) kafka.Kafka should return non-zero exit code when caught exception.

2015-04-23 Thread Sasaki Toru (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510155#comment-14510155 ] Sasaki Toru commented on KAFKA-2128: This is a easy patch, which add System.exit(1)

[jira] [Commented] (KAFKA-2128) kafka.Kafka should return non-zero exit code when caught exception.

2015-04-23 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510197#comment-14510197 ] Gwen Shapira commented on KAFKA-2128: - +1 It will make life a lot less confusing to

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

2015-04-23 Thread Ewen Cheslack-Postava
@Neha I think you're mixing up the 0.8.1/0.8.2 updates and the 0.8.2/0.8.3 that's being discussed here? I think the original question was about using the *new* consumer (clients consumer) with 0.8.2. Gwen's right, it will use features not even implemented in the broker in trunk yet, let alone the

Re: Should 0.8.3 consumers correctly function with 0.8.2 brokers?

2015-04-23 Thread Gwen Shapira
I didn't think 0.8.3 consumer will ever be able to talk to 0.8.2 broker... there are some essential pieces that are missing in 0.8.2 (Coordinator, Heartbeat, etc). Maybe I'm missing something. It will be nice if this will work :) Mind sharing what / how you tested? Were there no errors in broker

Leap second coming up!

2015-04-23 Thread Gwen Shapira
Hi, Looks like we are getting a new leap second on June 30. Is anyone planning on testing Kafka with leap seconds before it happens in production? Gwen

Re: Remote kafka - Connection refused.

2015-04-23 Thread Gwen Shapira
Perhaps this will help: https://cwiki.apache.org/confluence/display/KAFKA/FAQ#FAQ-Whycan'tmyconsumers/producersconnecttothebrokers? On Thu, Apr 23, 2015 at 3:24 PM, madhavan kumar madhavan020...@gmail.com wrote: Dear all, I am trying to connect my python consumer to a remote kafka server.

Re: Leap second coming up!

2015-04-23 Thread Ewen Cheslack-Postava
That sounds like a great candidate for a system test. On Thu, Apr 23, 2015 at 7:48 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, Looks like we are getting a new leap second on June 30. Is anyone planning on testing Kafka with leap seconds before it happens in production? Gwen --

Re: Leap second coming up!

2015-04-23 Thread Gwen Shapira
Any ideas on how to simulate leap seconds on test environments? On Thu, Apr 23, 2015 at 7:51 PM, Ewen Cheslack-Postava e...@confluent.io wrote: That sounds like a great candidate for a system test. On Thu, Apr 23, 2015 at 7:48 PM, Gwen Shapira gshap...@cloudera.com wrote: Hi, Looks like

[jira] [Commented] (KAFKA-2145) An option to add topic owners.

2015-04-23 Thread Neelesh Srinivas Salian (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14510409#comment-14510409 ] Neelesh Srinivas Salian commented on KAFKA-2145: I'd like to work on this,