Aditya, when I think about the motivation of not having to restart brokers
to change a config I think about all of the configurations I have seen
having to get changed in brokers and restarted (which is just about all of
them). What I mean by stop the world is when producers and/or consumers
will
Thomas Zimmer created KAFKA-2166:
Summary: Recreation breaks topic-list
Key: KAFKA-2166
URL: https://issues.apache.org/jira/browse/KAFKA-2166
Project: Kafka
Issue Type: Bug
Hi, Everyone,
We will have a KIP hangout at 11 PST on May 5. The following is the agenda.
If you want to attend and is not on the invite, please let me know.
Agenda:
KIP-4 (admin commands): any remaining issues
KIP-11 (authorization): any remaining issues
KIP-21 (configuration management)
[
https://issues.apache.org/jira/browse/KAFKA-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526677#comment-14526677
]
Thomas Zimmer commented on KAFKA-2166:
--
It also seems that Zookeeper is out-of-sync:
James.
Thanks for reporting this. So the issue only shows up at Kafka startup
time? After that, the GC time is back to normal again?
Jun
On Tue, Apr 28, 2015 at 1:48 PM, James Lent jl...@tivo.com wrote:
I have filed a bug report with Oracle on this issue today. I have not yet
been assigned
Jon Bringhurst created KAFKA-2167:
-
Summary: ZkUtils updateEphemeralPath JavaDoc (spelling and
correctness)
Key: KAFKA-2167
URL: https://issues.apache.org/jira/browse/KAFKA-2167
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Bringhurst updated KAFKA-2167:
--
Labels: newbie (was: )
ZkUtils updateEphemeralPath JavaDoc (spelling and correctness)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review82382
---
Thanks for the patch.
I agree that ClientQuotaMetrics2 is better.
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526814#comment-14526814
]
Ewen Cheslack-Postava commented on KAFKA-2123:
--
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/
---
(Updated May 4, 2015, 4:39 p.m.)
Review request for kafka.
Bugs: KAFKA-2123
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2123:
-
Attachment: KAFKA-2123_2015-05-04_09:39:50.patch
Make new consumer offset commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33378/#review82389
---
Thanks for the patch. A couple of comments below.
Ewen Cheslack-Postava created KAFKA-2168:
Summary: New consumer poll() can block other calls like
position(), commit(), and close() indefinitely
Key: KAFKA-2168
URL:
Thanks Harsha,
I think you addressed all the points raised so far.
LGTM +1.
Cheers,
--
Gianmarco
On 4 May 2015 at 03:57, Harsha ka...@harsha.io wrote:
Thanks Jay Gianmarco for the comments. I picked the option A, if user
sends a partition id than it will applied and partitioner.class
[
https://issues.apache.org/jira/browse/KAFKA-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526860#comment-14526860
]
Neha Narkhede commented on KAFKA-2166:
--
[~Alien2150] Thanks for reporting this issue.
I'd pick option A too. Rest LGTM. +1
On Mon, May 4, 2015 at 10:03 AM, Gianmarco De Francisci Morales
g...@apache.org wrote:
Thanks Harsha,
I think you addressed all the points raised so far.
LGTM +1.
Cheers,
--
Gianmarco
On 4 May 2015 at 03:57, Harsha ka...@harsha.io wrote:
Thanks
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/#review82392
---
This looks good overall. Couple of questions:
- You have
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33760/#review82399
---
I incorporated Ewen and Guozhang’s comments in the KIP page. Want to speed
up on this KIP because currently we experience mirror-maker hung very
likely when a broker is down.
I also took a shot to solve KAFKA-1788 in KAFKA-2142. I used metadata
timeout to expire the batches which are sitting in
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526902#comment-14526902
]
Jiangjie Qin commented on KAFKA-1660:
-
[~jkreps] [~jjkoshy] ping for a review :)
Hey Harsha,
That proposal sounds good. One minor thing--I don't think we need to have
the partitioner.metadata property. Our reason for using string properties
is exactly to make config extensible at runtime. So a given partitioner can
add whatever properties make sense using the configure() api
[
https://issues.apache.org/jira/browse/KAFKA-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-824:
Affects Version/s: 0.8.2.0
Assignee: (was: Neha Narkhede)
Labels:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31850/#review82402
---
Ship it!
Ship It!
- Jay Kreps
On April 30, 2015, 12:37 a.m.,
Neha Narkhede created KAFKA-2169:
Summary: Upgrade to zkclient-0.5
Key: KAFKA-2169
URL: https://issues.apache.org/jira/browse/KAFKA-2169
Project: Kafka
Issue Type: Bug
Affects Versions:
[
https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2159:
-
Labels: newbie (was: )
offsets.topic.segment.bytes and offsets.topic.retention.minutes are
[
https://issues.apache.org/jira/browse/KAFKA-2159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2159:
-
Component/s: offset manager
offsets.topic.segment.bytes and offsets.topic.retention.minutes are
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33729/#review82404
---
Ship it!
Nice catch. Maybe worth keeping the JIRA open for the
[
https://issues.apache.org/jira/browse/KAFKA-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526932#comment-14526932
]
Neha Narkhede commented on KAFKA-2156:
--
[~sandris] KM = Kafka Metrics
[
https://issues.apache.org/jira/browse/KAFKA-1660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526939#comment-14526939
]
Jiangjie Qin commented on KAFKA-1660:
-
Thanks for the quick response, [~jkreps].
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526945#comment-14526945
]
Neha Narkhede edited comment on KAFKA-1387 at 5/4/15 5:58 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1387:
-
Priority: Blocker (was: Major)
When this happens, there isn't a way to get out of this without
[
https://issues.apache.org/jira/browse/KAFKA-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1387:
-
Labels: newbie patch zkclient-problems (was: newbie patch)
Kafka getting stuck creating
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33645/#review82406
---
Ship it!
Ship It!
- Neha Narkhede
On April 28, 2015, 11:04
[
https://issues.apache.org/jira/browse/KAFKA-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526967#comment-14526967
]
Thomas Zimmer commented on KAFKA-2166:
--
Hey, i am using the latest version 0.8.2.1. I
[
https://issues.apache.org/jira/browse/KAFKA-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526972#comment-14526972
]
Neha Narkhede commented on KAFKA-2157:
--
[~tvaughan77] topics is correct. Patch is
[
https://issues.apache.org/jira/browse/KAFKA-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-2155.
--
Resolution: Not A Problem
Add option to control ZK root for kafka.tools.ConsumerOffsetChecker
[
https://issues.apache.org/jira/browse/KAFKA-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526978#comment-14526978
]
Neha Narkhede commented on KAFKA-2155:
--
You can just specify the zk root as part of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30196/#review82408
---
Ship it!
Ship It!
- Neha Narkhede
On April 28, 2015, 5:28 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Parth Brahmbhatt reassigned KAFKA-2169:
---
Assignee: Parth Brahmbhatt
Upgrade to zkclient-0.5
---
[
https://issues.apache.org/jira/browse/KAFKA-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1843:
-
Labels: newbie++ (was: )
Metadata fetch/refresh in new producer should handle all node
[
https://issues.apache.org/jira/browse/KAFKA-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1843:
-
Priority: Blocker (was: Major)
Metadata fetch/refresh in new producer should handle all node
[
https://issues.apache.org/jira/browse/KAFKA-2139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527048#comment-14527048
]
Neha Narkhede commented on KAFKA-2139:
--
[~becket_qin] Left some comments regarding
[
https://issues.apache.org/jira/browse/KAFKA-1843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-1843:
-
Labels: (was: newbie++)
Metadata fetch/refresh in new producer should handle all node
This problem is so mysterious to me that I am hesitant to make any definitive
statements regarding the scope of the issue. In the staging environment where
the problem was originally seen the GC logs were not enabled. In that
environment the session timeouts persisted for a long time (and
[
https://issues.apache.org/jira/browse/KAFKA-1886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede resolved KAFKA-1886.
--
Resolution: Fixed
Thanks, pushed to trunk
SimpleConsumer swallowing
[
https://issues.apache.org/jira/browse/KAFKA-2158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2158:
-
Reviewer: Jun Rao
Close all fetchers in AbstractFetcherManager without blocking
[
https://issues.apache.org/jira/browse/KAFKA-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Neha Narkhede updated KAFKA-2153:
-
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks, pushed to trunk.
[
https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527075#comment-14527075
]
Neha Narkhede commented on KAFKA-313:
-
[~singhashish] I'm sorry for the delay. Not sure
On May 4, 2015, 9:34 p.m., Guozhang Wang wrote:
Some general comments:
1. This patch seems trying to fix multiple issues all at once, which makes
it very hard to reason / review. Could you separate it into multiple phases
with each phase resolving one issue at a time?
2. It
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/
---
(Updated May 5, 2015, 12:57 a.m.)
Review request for kafka.
Bugs: KAFKA-2142
[
https://issues.apache.org/jira/browse/KAFKA-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527711#comment-14527711
]
Jiangjie Qin commented on KAFKA-2142:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/
---
(Updated May 5, 2015, 1:14 a.m.)
Review request for kafka.
Bugs: KAFKA-2142
[
https://issues.apache.org/jira/browse/KAFKA-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin updated KAFKA-2142:
Attachment: KAFKA-2142_2015-05-04_18:14:44.patch
Follow-up patch for KAFKA-2138 Refactor the drain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/
---
(Updated May 5, 2015, 1:15 a.m.)
Review request for kafka.
Bugs: KAFKA-2142
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aditya A Auradkar updated KAFKA-1984:
-
Attachment: KAFKA-1984_2015-05-04_19:52:19.patch
java producer may miss an available
Hi guys,
I'm trying add test cases, but below case crashed at line
segReopen.recover(64*1024)-- index.trimToValidSize() , any idea for it?
Appreciate your help.
The case assume kafka suddenly crash, and need recover the last segment.
kafka.log.LogSegmentTest
Added.
Thanks,
Jun
On Mon, May 4, 2015 at 2:17 PM, Ashish Singh asi...@cloudera.com wrote:
Thanks for extending help here. I do have a separate confluence wiki
account, https://cwiki.apache.org/confluence/display/~asingh. Below are
the
details.
username: asingh
email:
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527865#comment-14527865
]
Jun Rao commented on KAFKA-1984:
[~auradkar], did you attach the patch to the wrong jira?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/
---
(Updated May 5, 2015, 12:19 a.m.)
Review request for kafka.
Bugs: KAFKA-2142
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/#review82448
---
Hey Neha,
Thanks for the feedback.
1. In my earlier exchange with Jay, I mentioned the broker writing all it's
configs to ZK (while respecting the overrides). Then ZK can be used to view all
configs.
2. Need to think about this a bit more. Perhaps we can discuss this during the
hangout
On May 4, 2015, 3:46 p.m., Jun Rao wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics2.scala, lines 153-162
https://reviews.apache.org/r/33049/diff/5/?file=938427#file938427line153
For measuring the amount of throtting, would it be better to measure it
as a percentage of
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 2:52 a.m.)
Review request for kafka, Joel Koshy and Jun
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527818#comment-14527818
]
Aditya A Auradkar commented on KAFKA-1984:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-1984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527887#comment-14527887
]
Aditya Auradkar commented on KAFKA-1984:
[~junrao] My bad.. I attached to 1984
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 4:33 a.m.)
Review request for kafka, Joel Koshy and Jun
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/
---
(Updated May 5, 2015, 4:33 a.m.)
Review request for kafka, Joel Koshy and Jun
Thanks Jun!
On Monday, May 4, 2015, Jun Rao j...@confluent.io wrote:
Added.
Thanks,
Jun
On Mon, May 4, 2015 at 2:17 PM, Ashish Singh asi...@cloudera.com
javascript:; wrote:
Thanks for extending help here. I do have a separate confluence wiki
account,
Bummer... I meant *Confluence id* :)
On Mon, May 4, 2015 at 1:48 PM, Ashish Singh asi...@cloudera.com wrote:
Hello,
While trying to create a KIP, I realized that I probably need to get my
confluence id to be able to create a page under Apache Kafka. Either that
or I am doing something
[
https://issues.apache.org/jira/browse/KAFKA-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527467#comment-14527467
]
David Hay commented on KAFKA-2135:
--
[~ewencp] This does appear to be a duplicate of
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527454#comment-14527454
]
Dong Lin commented on KAFKA-1936:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33557/
---
(Updated May 4, 2015, 10:18 p.m.)
Review request for kafka.
Bugs: KAFKA-1936
[
https://issues.apache.org/jira/browse/KAFKA-1936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-1936:
Attachment: KAFKA-1936_2015-05-04_15:17:50.patch
Track offset commit requests separately from produce
1. Essentially, I think removing the option to configure properties via file
may be a big change for everyone. Having said that, your points are very valid.
I guess we can discuss this a bit more during the KIP hangout.
4. Yes, we will need to make some changes to update the MetricConfig for
On May 4, 2015, 5:18 p.m., Joel Koshy wrote:
This looks good overall. Couple of questions:
- You have blacklisted the topic for recording in the global broker topic
metrics, but for consistency should we do this for per-topic metrics as
well?
- Rather than do the topic check in
[
https://issues.apache.org/jira/browse/KAFKA-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava resolved KAFKA-2135.
--
Resolution: Duplicate
New Kafka Producer Client: Send requests wait
See https://builds.apache.org/job/KafkaPreCommit/95/changes
Changes:
[nehanarkhede] KAFKA-1886 SimpleConsumer swallowing ClosedByInterruptException;
reviewed by Neha Narkhede
[nehanarkhede] KAFKA-2153 kafka-patch-review tool uploads a patch even if it is
empty; reviewed by Neha Narkhede, Gwen
Hello,
While trying to create a KIP, I realized that I probably need to get my
confluence id to be able to create a page under Apache Kafka. Either that
or I am doing something wrong. Could someone with appropriate privileges/
knowledge help me out.
My confluence account is registered with
Joe, I'm not sure if I follow what you are saying. I think you are saying
that unless we make all configs dynamic it will be confusing. Is that
right? I somewhat agree. We are already kind of in that situation with the
topic configs being dynamic, though.
I think trying to make all configs
Hey Jay,
Thanks for the feedback.
1. We can certainly discuss what it means to remove the file configuration as a
thought exercise. However, is this something we want to do for real? IMO, we
can remove file configuration by having all configs stored in zookeeper. The
flow can be:
- Broker
Hey Aditya,
1. I would argue for either staying with what we have or else moving to a
better solution, but not doing both. A solution that uses both is going to
be quite complex to figure out what is configured and where it comes from.
If you think this is needed let's try to construct the
[
https://issues.apache.org/jira/browse/KAFKA-2135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527293#comment-14527293
]
Ewen Cheslack-Postava commented on KAFKA-2135:
--
[~dhay] is this a duplicate
Thanks for extending help here. I do have a separate confluence wiki
account, https://cwiki.apache.org/confluence/display/~asingh. Below are the
details.
username: asingh
email: asi...@cloudera.com
full name: Ashish Singh
Let me know if you are still not able to find me.
On Mon, May 4, 2015 at
Ashish,
I cannot find your id in conflunce. Note that you need separate ids for
conflunce wiki and JIRA.
Guozhang
On Mon, May 4, 2015 at 1:49 PM, Ashish Singh asi...@cloudera.com wrote:
Bummer... I meant *Confluence id* :)
On Mon, May 4, 2015 at 1:48 PM, Ashish Singh asi...@cloudera.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33552/#review82444
---
Some general comments:
1. This patch seems trying to fix multiple
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14527975#comment-14527975
]
Ewen Cheslack-Postava commented on KAFKA-2123:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2123:
-
Attachment: KAFKA-2123_2015-05-04_22:51:48.patch
Make new consumer offset commit
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33196/
---
(Updated May 5, 2015, 5:51 a.m.)
Review request for kafka.
Bugs: KAFKA-2123
On May 5, 2015, 1:39 a.m., Guozhang Wang wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Coordinator.java,
lines 186-188
https://reviews.apache.org/r/33196/diff/4/?file=949010#file949010line186
Maybe we can combine the commitOffsetRequests and
89 matches
Mail list logo
