On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/
---
Review request for kafka.
Bugs: KAFKA-2168
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2168:
---
Attachment: KAFKA-2168.patch
New consumer poll() can block other calls like position(),
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563832#comment-14563832
]
Jason Gustafson commented on KAFKA-2168:
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-2168:
---
Status: Patch Available (was: Open)
New consumer poll() can block other calls like
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563843#comment-14563843
]
Jason Gustafson commented on KAFKA-2168:
I've added a patch which removes
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563858#comment-14563858
]
Joel Koshy commented on KAFKA-1367:
---
Hi [~singhashish] - sorry I missed your pings. Yes
Hi, Jiangjie,
The replication time may vary a bit for different partitions. For example,
a partition with more replicas may take a bit more time to propagate the
messages. Also, the replication time depends on network latency. If you
have a Kafka cluster across availability zones, data will be
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
[
https://issues.apache.org/jira/browse/KAFKA-2186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-2186:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch - committed to
[
https://issues.apache.org/jira/browse/KAFKA-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiangjie Qin resolved KAFKA-2224.
-
Resolution: Duplicate
Duplicate of KAFKA-1951
kafka-consumer-offset-checker when kafka offset
[
https://issues.apache.org/jira/browse/KAFKA-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563652#comment-14563652
]
Jiangjie Qin commented on KAFKA-2224:
-
Seems to be duplicate of KAFKA-1951.
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563795#comment-14563795
]
Ashish K Singh commented on KAFKA-1367:
---
[~jjkoshy] pinging you for your
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32869/#review85608
---
Ship it!
Ship It!
- Joel Koshy
On May 27, 2015, 10:50 p.m.,
[
https://issues.apache.org/jira/browse/KAFKA-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563732#comment-14563732
]
Jun Rao commented on KAFKA-2225:
[~iconara], just to clarify, so you are using the private
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563753#comment-14563753
]
Guozhang Wang commented on KAFKA-2168:
--
I would also prefer to stick with
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
[
https://issues.apache.org/jira/browse/KAFKA-2091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joel Koshy updated KAFKA-2091:
--
Thanks for the patch - committed to trunk.
Expose a Partitioner interface in the new producer
+1 (non binding)
On May 28, 2015, at 11:41 AM, Aditya Auradkar
aaurad...@linkedin.com.INVALID wrote:
bump
From: Aditya Auradkar
Sent: Tuesday, May 26, 2015 1:16 PM
To: dev@kafka.apache.org
Subject: RE: [VOTE] KIP-21 Dynamic Configuration
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85596
---
Thanks for the patch. A couple of questions below.
Also, in
On May 28, 2015, 8:42 a.m., Onur Karaman wrote:
It seems like you're concerned about adding/removing a TimerTaskEntry that
already exists in another TimerTaskList. Can you explain how that can
happen? My understanding of the timing wheel stuff is only so-so.
For adding, a
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
Thanks for the patch. A couple of questions below.
Also, in TimerTask.setTimerTaskEntry(), the comment suggests that the
TaskEntry can change for a TimerTask. However, it seems that we set the
entry for the task only during entry
[
https://issues.apache.org/jira/browse/KAFKA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2189:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
Thanks for the patch. +1 and committed to
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34789/#review85644
---
I think close() isn't quite right, and is probably harder than just
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34524/#review85641
---
The purpose of the replication timeout was not to control the purgatory
size but rather to bound the time you block on replication to other servers.
We discussed making it a server-side config but the rationale for making a
client configuration is that these timeouts are fundamentally about how
On May 28, 2015, 7:10 p.m., Jun Rao wrote:
core/src/main/scala/kafka/utils/timer/TimerTaskList.scala, lines 132-135
https://reviews.apache.org/r/34734/diff/1/?file=973063#file973063line132
So, I guess the race condition is the following. The expiration thread
moves a
For the sequential config/changes/config_change_XX znode, do we have any
manners to do cleaning in order to avoid the change-log from growing
indefinitely?
Guozhang
On Thu, May 28, 2015 at 5:02 PM, Jay Kreps jay.kr...@gmail.com wrote:
I still have a couple of questions:
1. Are we introducing
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563968#comment-14563968
]
Jason Gustafson commented on KAFKA-2168:
This patch is a work in progress. Using
[
https://issues.apache.org/jira/browse/KAFKA-2185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao updated KAFKA-2185:
---
Resolution: Fixed
Fix Version/s: 0.8.3
Status: Resolved (was: Patch Available)
Thanks for
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563904#comment-14563904
]
Ashish K Singh commented on KAFKA-1367:
---
Thanks [~jjkoshy]! I will update the KIP
On May 28, 2015, 11:30 p.m., Ewen Cheslack-Postava wrote:
clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java,
line 857
https://reviews.apache.org/r/34789/diff/1/?file=973873#file973873line857
I think this requires a bit more coordination between the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85665
---
Thanks for the new patch. A few more clarification questions below.
I still have a couple of questions:
1. Are we introducing a new Java API for the config change protocol and if
so where will that appear? Is that going to be part of the java api in the
admin api kip? Let's document that.
2. The proposed JSON format uses camel case for field names, is that what
That is handled now so I am assuming the same mechanism carries over?
-Jay
On Thu, May 28, 2015 at 5:12 PM, Guozhang Wang wangg...@gmail.com wrote:
For the sequential config/changes/config_change_XX znode, do we have any
manners to do cleaning in order to avoid the change-log from growing
I still have a couple of questions:
1. Are we introducing a new Java API for the config change protocol and if
so where will that appear? Is that going to be part of the java api in the
admin api kip? Let's document that.
2. The proposed JSON format uses camel case for field names, is that what
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563965#comment-14563965
]
Yasuhiro Matsuda commented on KAFKA-2226:
-
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/
---
(Updated May 29, 2015, 12:19 a.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yasuhiro Matsuda updated KAFKA-2226:
Attachment: KAFKA-2226_2015-05-28_17:18:55.patch
NullPointerException in
Jay Kreps created KAFKA-2230:
Summary: Add a wakeup() call to the new consumer
Key: KAFKA-2230
URL: https://issues.apache.org/jira/browse/KAFKA-2230
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563960#comment-14563960
]
Joel Koshy commented on KAFKA-1367:
---
Jun - that is a good point. That sounds like a good
[
https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14564029#comment-14564029
]
Jun Rao commented on KAFKA-1367:
Well, in that approach, you still have the problem on the
Jun, Jay and Joel, thanks a lot for the explanations.
Just summarize what I learned - please correct me if I understand wrong:
1. The actually replication time is determined by inter-broker
(intra-cluster) communication.
2. The actual replication time for different topics may be different.
3. The
Thanks. Perhaps we should leave TMR unchanged for now. Should we discuss this
during the next hangout?
Aditya
From: Jun Rao [j...@confluent.io]
Sent: Thursday, May 28, 2015 5:32 PM
To: dev@kafka.apache.org
Subject: Re: [DISCUSS] KIP-4 - Command line and
[
https://issues.apache.org/jira/browse/KAFKA-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562478#comment-14562478
]
Ismael Juma commented on KAFKA-2187:
[~nehanarkhede], please let me know if there's
[
https://issues.apache.org/jira/browse/KAFKA-2189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562470#comment-14562470
]
Ismael Juma commented on KAFKA-2189:
Given the positive feedback, it seems like it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34734/#review85530
---
It seems like you're concerned about adding/removing a
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi updated KAFKA-2229:
Status: Patch Available (was: Open)
Phase 1: Requests and KafkaApis
Andrii Biletskyi created KAFKA-2228:
---
Summary: Phase 1: Requests and KafkaApis
Key: KAFKA-2228
URL: https://issues.apache.org/jira/browse/KAFKA-2228
Project: Kafka
Issue Type: Sub-task
Andrii Biletskyi created KAFKA-2229:
---
Summary: Phase 1: Requests and KafkaApis
Key: KAFKA-2229
URL: https://issues.apache.org/jira/browse/KAFKA-2229
Project: Kafka
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrii Biletskyi updated KAFKA-2229:
Attachment: KAFKA-2229.patch
Phase 1: Requests and KafkaApis
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34766/
---
Review request for kafka.
Bugs: KAFKA-2229
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33049/#review85545
---
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala
[
https://issues.apache.org/jira/browse/KAFKA-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14562877#comment-14562877
]
Andrii Biletskyi commented on KAFKA-2229:
-
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563030#comment-14563030
]
Gabriel Reid commented on KAFKA-2223:
-
Ok, thanks for taking a look [~jkreps].
I
sorry, wrong email list :)
~ Joe Stein
- - - - - - - - - - - - - - - - -
http://www.stealth.ly
- - - - - - - - - - - - - - - - -
On Thu, May 28, 2015 at 11:41 AM, Joe Stein joe.st...@stealth.ly wrote:
Hi, a few folks from a few different companies (Cisco, Elodina,
Mesosphere, Moz) are
[
https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14563212#comment-14563212
]
Jason Gustafson commented on KAFKA-2168:
Talked with Neha, Ewen, and Jay last
Hi, a few folks from a few different companies (Cisco, Elodina, Mesosphere,
Moz) are going to be having a hangout
https://plus.google.com/hangouts/_/stealth.ly/mesos-network every Friday
11am PT / 2pm ET and wanted to invite any other interested parties to join
too. We have already talked with
On May 28, 2015, 12:58 p.m., Manikumar Reddy O wrote:
core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 145
https://reviews.apache.org/r/33049/diff/10/?file=972066#file972066line145
Are we using clientID as uniqueKey?. But as of now, clientID is not
mandatory and it
60 matches
Mail list logo
