[jira] [Updated] (KAFKA-2132) Move Log4J appender to a separate module

2015-06-13 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2132: -- Status: Patch Available (was: In Progress) Move Log4J appender to a separate module

[jira] [Commented] (KAFKA-2218) reassignment tool needs to parse and validate the json

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584945#comment-14584945 ] Manikumar Reddy commented on KAFKA-2218: [~charmalloc] I am not able to reproduce

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33614/ --- (Updated June 14, 2015, 4:19 a.m.) Review request for kafka. Bugs:

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
On June 12, 2015, 2:03 a.m., Jun Rao wrote: Thanks for the patch. A few comments below. Thanks for the review Jun. Addressed your comments. On June 12, 2015, 2:03 a.m., Jun Rao wrote: log4j-appender/src/main/java/org/apache/kafka/log4jappender/KafkaLog4jAppender.java, lines 121-122

Re: Review Request 33614: Patch for KAFKA-2132

2015-06-13 Thread Ashish Singh
On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote: Hey Ashish, I've left a few minor comments. Thanks! Thanks for the review Aditya. Addressed your comments. On June 11, 2015, 10:15 p.m., Aditya Auradkar wrote:

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

2015-06-13 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584688#comment-14584688 ] ASF GitHub Bot commented on KAFKA-2092: --- GitHub user gdfm opened a pull request:

[jira] [Updated] (KAFKA-2092) New partitioning for better load balancing

2015-06-13 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gianmarco De Francisci Morales updated KAFKA-2092: -- Attachment: KAFKA-2092-v1.patch New partitioning for better

[jira] [Updated] (KAFKA-2092) New partitioning for better load balancing

2015-06-13 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gianmarco De Francisci Morales updated KAFKA-2092: -- Status: Patch Available (was: Open) First attempt at a patch

[jira] [Commented] (KAFKA-2262) LogSegmentSize validation should be consistent

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584539#comment-14584539 ] Manikumar Reddy commented on KAFKA-2262: Created reviewboard

[jira] [Updated] (KAFKA-2262) LogSegmentSize validation should be consistent

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2262: --- Attachment: KAFKA-2262.patch LogSegmentSize validation should be consistent

[jira] [Updated] (KAFKA-2262) LogSegmentSize validation should be consistent

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2262: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) LogSegmentSize

[jira] [Updated] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2026: --- Assignee: Manikumar Reddy (was: Ewen Cheslack-Postava) Status: Patch Available (was:

[jira] [Commented] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584544#comment-14584544 ] Manikumar Reddy commented on KAFKA-2026: Created reviewboard

[jira] [Updated] (KAFKA-2026) Logging of unused options always shows null for the value and is misleading if the option is used by serializers

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2026: --- Attachment: KAFKA-2026.patch Logging of unused options always shows null for the value and

Review Request 35421: Patch for KAFKA-2026

2015-06-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35421/ --- Review request for kafka. Bugs: KAFKA-2026

[jira] [Updated] (KAFKA-2264) SESSION_TIMEOUT_MS_CONFIG in ConsumerConfig should be int

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2264: --- Attachment: KAFKA-2264.patch SESSION_TIMEOUT_MS_CONFIG in ConsumerConfig should be int

[jira] [Updated] (KAFKA-2264) SESSION_TIMEOUT_MS_CONFIG in ConsumerConfig should be int

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2264: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open)

Review Request 35418: Patch for KAFKA-2264

2015-06-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35418/ --- Review request for kafka. Bugs: KAFKA-2264

[jira] [Commented] (KAFKA-2264) SESSION_TIMEOUT_MS_CONFIG in ConsumerConfig should be int

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584521#comment-14584521 ] Manikumar Reddy commented on KAFKA-2264: Created reviewboard

Review Request 35419: Patch for KAFKA-2262

2015-06-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35419/ --- Review request for kafka. Bugs: KAFKA-2262

Review Request 35424: Patch for KAFKA-2234

2015-06-13 Thread Manikumar Reddy O
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35424/ --- Review request for kafka. Bugs: KAFKA-2234

[jira] [Updated] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2234: --- Attachment: KAFKA-2234.patch Partition reassignment of a nonexistent topic prevents future

[jira] [Updated] (KAFKA-2234) Partition reassignment of a nonexistent topic prevents future reassignments

2015-06-13 Thread Manikumar Reddy (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar Reddy updated KAFKA-2234: --- Assignee: Manikumar Reddy Status: Patch Available (was: Open) Partition reassignment

Re: Review Request 35421: Patch for KAFKA-2026

2015-06-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35421/#review87842 --- Ship it! This minimal fix is fine as long as we're happy with the

Re: Review Request 35076: Patch for KAFKA-2248

2015-06-13 Thread Ewen Cheslack-Postava
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35076/ --- (Updated June 13, 2015, 9:10 p.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2248) Use Apache Rat to enforce copyright headers

2015-06-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ewen Cheslack-Postava updated KAFKA-2248: - Attachment: KAFKA-2248_2015-06-13_14:10:23.patch Use Apache Rat to enforce

[jira] [Commented] (KAFKA-2248) Use Apache Rat to enforce copyright headers

2015-06-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584817#comment-14584817 ] Ewen Cheslack-Postava commented on KAFKA-2248: -- Updated reviewboard

[jira] [Commented] (KAFKA-2248) Use Apache Rat to enforce copyright headers

2015-06-13 Thread Ewen Cheslack-Postava (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14584818#comment-14584818 ] Ewen Cheslack-Postava commented on KAFKA-2248: -- [~junrao] Try this new