Ashish K Singh created KAFKA-2299:
-
Summary: kafka-patch-review tool does not correctly capture
testing done
Key: KAFKA-2299
URL: https://issues.apache.org/jira/browse/KAFKA-2299
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599029#comment-14599029
]
Ashish K Singh commented on KAFKA-2299:
---
[~nehanarkhede] do you mind taking a look
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599028#comment-14599028
]
Ashish K Singh commented on KAFKA-2299:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2299:
--
Status: Patch Available (was: Open)
kafka-patch-review tool does not correctly capture
[
https://issues.apache.org/jira/browse/KAFKA-2299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2299:
--
Attachment: KAFKA-2299.patch
kafka-patch-review tool does not correctly capture testing done
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35822/
---
Review request for kafka.
Bugs: KAFKA-2299
[
https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599317#comment-14599317
]
Jason Rosenberg commented on KAFKA-1901:
[~omkreddy] Yes, that sounds find.
[
https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2301:
--
Attachment: KAFKA-2301.patch
Deprecate ConsumerOffsetChecker
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/
---
Review request for kafka.
Bugs: KAFKA-2301
[
https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2301:
--
Status: Patch Available (was: Open)
Deprecate ConsumerOffsetChecker
[
https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600256#comment-14600256
]
Ashish K Singh commented on KAFKA-2301:
---
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600318#comment-14600318
]
Matthieu Sprunck commented on KAFKA-282:
I still have this issue with the API
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600093#comment-14600093
]
Jakob Homan commented on KAFKA-2203:
A couple data points:
* Samza has a script that
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35850/#review89301
---
Is this what was intended by deprecate? I'm not sure there's been
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh reassigned KAFKA-972:
Assignee: Ashish K Singh
MetadataRequest returns stale list of brokers
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Grant Henke updated KAFKA-972:
--
Attachment: BrokerMetadataTest.scala
Sample Failing Tests:
- testBrokerMetadataOnClusterWithNoTopics
-
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600602#comment-14600602
]
Ashish K Singh edited comment on KAFKA-972 at 6/25/15 3:10 AM:
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600602#comment-14600602
]
Ashish K Singh edited comment on KAFKA-972 at 6/25/15 3:10 AM:
[
https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600602#comment-14600602
]
Ashish K Singh commented on KAFKA-972:
--
Hey Guys,
I spent some time reproducing the
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599666#comment-14599666
]
Ewen Cheslack-Postava commented on KAFKA-2203:
--
The drawback is that I don't
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33620/#review89063
---
Thanks for the patch, Sriharsha. A few comments below.
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599681#comment-14599681
]
Gwen Shapira commented on KAFKA-2203:
-
This should be done pre-commit and nearly every
Johnny Brown created KAFKA-2300:
---
Summary: Error in controller log when broker tries to rejoin
cluster
Key: KAFKA-2300
URL: https://issues.apache.org/jira/browse/KAFKA-2300
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599556#comment-14599556
]
Jeff Maxwell commented on KAFKA-2203:
-
The KAFKA-2294 patch allows java 8 builds to
[
https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-313:
-
Attachment: KAFKA-313_2015-06-24_11:14:24.patch
Add JSON/CSV output and looping options to
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
282
https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282
Do you think we should just move the disconnected.add() into the close
[
https://issues.apache.org/jira/browse/KAFKA-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599872#comment-14599872
]
Ashish K Singh commented on KAFKA-313:
--
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599926#comment-14599926
]
Kurt Harriger commented on KAFKA-2300:
--
Looking at the code it appears once the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614/
---
(Updated June 24, 2015, 5:20 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599778#comment-14599778
]
Ashish K Singh commented on KAFKA-2132:
---
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2132:
--
Attachment: KAFKA-2132_2015-06-24_10:25:43.patch
Move Log4J appender to a separate module
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599797#comment-14599797
]
Jeff Maxwell commented on KAFKA-2203:
-
FWIW Spring's solution appears to be dedicated
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
282
https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282
Do you think we should just move the disconnected.add() into the close
There are loads of other improvements that could me
made too -- for example, I'd love seeing Docker support, which would make
running tests way cheaper/simpler.
Haha, that was my first thought when I saw Vagrant in there - why not Docker? :)
I didn't realize we already had Vagrant integration
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35832/
---
Review request for kafka.
Bugs: KAFKA-2199
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599743#comment-14599743
]
Ewen Cheslack-Postava commented on KAFKA-2199:
--
[~omkreddy] Sorry about that,
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish K Singh updated KAFKA-2132:
--
Attachment: KAFKA-2132_2015-06-24_10:19:56.patch
Move Log4J appender to a separate module
[
https://issues.apache.org/jira/browse/KAFKA-2132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599770#comment-14599770
]
Ashish K Singh commented on KAFKA-2132:
---
Updated reviewboard
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33614/
---
(Updated June 24, 2015, 5:25 p.m.)
Review request for kafka.
Bugs:
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599823#comment-14599823
]
Gwen Shapira commented on KAFKA-2203:
-
Having pre-commit comments on a JIRA will be
Github either lets you do inline comments on the diff (Files Changed tab)
or on the entire commit (Conversation). One of the things review board
does right that's a bit frustrating in Github his that you can't group a
bunch of comments into a single review and post it all at once (and get
only one
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599738#comment-14599738
]
Ewen Cheslack-Postava commented on KAFKA-2199:
--
Created reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ewen Cheslack-Postava updated KAFKA-2199:
-
Attachment: KAFKA-2199.patch
Make signing artifacts optional, setting maven
[
https://issues.apache.org/jira/browse/KAFKA-2203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14599771#comment-14599771
]
Ewen Cheslack-Postava commented on KAFKA-2203:
--
[~gwenshap] Agreed that
On June 16, 2015, 1:31 a.m., Jun Rao wrote:
Thanks for the patch. There seems to be a compilation error.
:log4j-appender:compileTestJava
/Users/junrao/intellij/kafka/log4j-appender/src/test/java/org/apache/kafka/log4jappender/MockKafkaLog4jAppender.java:27:
cannot find symbol
Hey Sriram,
Good question here was the thinking:
1. I think the argument we are making is that a stream processing framework
is the right way to do complex transformations. We can bake in some
mechanism for simple, single-row transforms in copycat, but for anything
more complex copycat is really
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
282
https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282
Do you think we should just move the disconnected.add() into the close
Hi Gwen,
A couple other thoughts:
services/templates
These are jinja2 templates which can be populated with values as desired.
Although currently many individual configs in various templates have preset
values, we can easily make these more parametrizable (presumably with
default values).
There
On June 23, 2015, 5:59 p.m., Jason Gustafson wrote:
clients/src/main/java/org/apache/kafka/common/network/Selector.java, line
282
https://reviews.apache.org/r/35791/diff/1/?file=990592#file990592line282
Do you think we should just move the disconnected.add() into the close
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35791/
---
(Updated June 24, 2015, 8 p.m.)
Review request for kafka.
Bugs: KAFKA-2298
[
https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600047#comment-14600047
]
Dong Lin commented on KAFKA-2298:
-
Updated reviewboard
[
https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Lin updated KAFKA-2298:
Attachment: KAFKA-2298_2015-06-24_13:00:39.patch
Client Selector can drop connections on
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35791/#review89241
---
Ship it!
Ship It!
- Jason Gustafson
On June 24, 2015, 8 p.m.,
53 matches
Mail list logo
