Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 1, 2015, 8:37 a.m.) Review request for kafka. Bugs: KAFKA-972

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 1, 2015, 8:43 a.m.) Review request for kafka. Bugs: KAFKA-972

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
On July 1, 2015, 4:37 a.m., Jun Rao wrote: core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, line 69 https://reviews.apache.org/r/36030/diff/2/?file=996282#file996282line69 Do we need this? In tearDown(), ZookeeperTestHarness will delete all ZK data. Ahh.. I

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-01_01:36:56.patch MetadataRequest returns stale list of brokers

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-01_01:42:42.patch MetadataRequest returns stale list of brokers

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609749#comment-14609749 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

2015-07-01 Thread Jason Gustafson (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610622#comment-14610622 ] Jason Gustafson commented on KAFKA-2092: [~azaroth], since the partitioner is

[jira] [Resolved] (KAFKA-2165) ReplicaFetcherThread: data loss on unknown exception

2015-07-01 Thread Gwen Shapira (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gwen Shapira resolved KAFKA-2165. - Resolution: Not A Problem ReplicaFetcherThread: data loss on unknown exception

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Jun Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/#review90045 --- Thanks for the patch. Just one more comment.

Re: Review Request 34494: Patch for KAFKA-2212

2015-07-01 Thread Tom Graves
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34494/#review90044 --- When running acls and not specifying the config I get a

[jira] [Updated] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-972: - Attachment: KAFKA-972_2015-07-01_08:06:03.patch MetadataRequest returns stale list of brokers

[jira] [Commented] (KAFKA-972) MetadataRequest returns stale list of brokers

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610423#comment-14610423 ] Ashish K Singh commented on KAFKA-972: -- Updated reviewboard

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36030/ --- (Updated July 1, 2015, 3:06 p.m.) Review request for kafka. Bugs: KAFKA-972

Re: Review Request 36030: Patch for KAFKA-972

2015-07-01 Thread Ashish Singh
On July 1, 2015, 2:18 p.m., Jun Rao wrote: core/src/test/scala/unit/kafka/integration/TopicMetadataTest.scala, lines 162-172 https://reviews.apache.org/r/36030/diff/4/?file=996501#file996501line162 The propagation of the metadata to different brokers are independant. So,we

EOL JDK 1.6 for Kafka

2015-07-01 Thread Harsha
Hi, During our SSL Patch KAFKA-1690. Some of the reviewers/users asked for support this config https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/SSLParameters.html#setEndpointIdentificationAlgorithm-java.lang.String- It allows clients to verify the server and prevent

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Joel Koshy
+1 On Wednesday, July 1, 2015, Harsha ka...@harsha.io wrote: Hi, During our SSL Patch KAFKA-1690. Some of the reviewers/users asked for support this config

[jira] [Commented] (KAFKA-2092) New partitioning for better load balancing

2015-07-01 Thread Gianmarco De Francisci Morales (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14609701#comment-14609701 ] Gianmarco De Francisci Morales commented on KAFKA-2092: --- Is

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Marina
+1 for deprecating JDK1.6 From: Harsha ka...@harsha.io To: us...@kafka.apache.org; dev@kafka.apache.org Sent: Wednesday, July 1, 2015 11:05 AM Subject: EOL JDK 1.6 for Kafka Hi,         During our SSL Patch KAFKA-1690. Some of the reviewers/users         asked for support this

dev subscription request

2015-07-01 Thread Sethuram, Anup
Hi, Could you please add me to the dev-subscriber list. Regards, anup The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-01 Thread Aditya Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611311#comment-14611311 ] Aditya Auradkar commented on KAFKA-2205: [~junrao] - Addressed your comments. Can

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Jiangjie Qin
+1 On 7/1/15, 1:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Huge +1. I don't think there is any other project that still supports 1.6. On Wed, Jul 1, 2015 at 8:05 AM, Harsha ka...@harsha.io wrote: Hi, During our SSL Patch KAFKA-1690. Some of the reviewers/users asked

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Guozhang Wang
+1. On Wed, Jul 1, 2015 at 1:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Huge +1. I don't think there is any other project that still supports 1.6. On Wed, Jul 1, 2015 at 8:05 AM, Harsha ka...@harsha.io wrote: Hi, During our SSL Patch KAFKA-1690. Some of the reviewers/users

Re: Review Request 35231: Address Onur and Jason's comments

2015-07-01 Thread Jason Gustafson
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35231/#review90155 --- Ship it! Ship It! - Jason Gustafson On June 30, 2015, 1:44

[jira] [Updated] (KAFKA-1735) MemoryRecords.Iterator needs to handle partial reads from compressed stream

2015-07-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-1735: - Resolution: Fixed Status: Resolved (was: Patch Available) MemoryRecords.Iterator needs

Jenkins build is back to normal : Kafka-trunk #523

2015-07-01 Thread Apache Jenkins Server
See https://builds.apache.org/job/Kafka-trunk/523/changes

[jira] [Updated] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

2015-07-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-2168: - Resolution: Fixed Status: Resolved (was: Patch Available) New consumer poll() can block

[jira] [Commented] (KAFKA-2168) New consumer poll() can block other calls like position(), commit(), and close() indefinitely

2015-07-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611104#comment-14611104 ] Guozhang Wang commented on KAFKA-2168: -- Committed the follow-up patch to trunk.

Re: Review Request 35231: Address Onur and Jason's comments

2015-07-01 Thread Guozhang Wang
On June 18, 2015, 12:50 a.m., Jason Gustafson wrote: core/src/main/scala/kafka/coordinator/ConsumerCoordinator.scala, lines 229-236 https://reviews.apache.org/r/35231/diff/1/?file=980918#file980918line229 In manual group management, would we expect consumerId and generationId

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Jay Kreps
+1 -Jay On Wed, Jul 1, 2015 at 3:32 PM, Guozhang Wang wangg...@gmail.com wrote: +1. On Wed, Jul 1, 2015 at 1:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Huge +1. I don't think there is any other project that still supports 1.6. On Wed, Jul 1, 2015 at 8:05 AM, Harsha

Re: EOL JDK 1.6 for Kafka

2015-07-01 Thread Neha Narkhede
+1. It's about time. On Wed, Jul 1, 2015 at 3:52 PM, Jay Kreps j...@confluent.io wrote: +1 -Jay On Wed, Jul 1, 2015 at 3:32 PM, Guozhang Wang wangg...@gmail.com wrote: +1. On Wed, Jul 1, 2015 at 1:00 PM, Gwen Shapira gshap...@cloudera.com wrote: Huge +1. I don't think

[jira] [Commented] (KAFKA-1735) MemoryRecords.Iterator needs to handle partial reads from compressed stream

2015-07-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611164#comment-14611164 ] Guozhang Wang commented on KAFKA-1735: -- This bug has been resolved in another ticket,

[jira] [Updated] (KAFKA-996) Capitalize first letter for log entries

2015-07-01 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-996: Resolution: Won't Fix Status: Resolved (was: Patch Available) Capitalize first letter for

[jira] [Updated] (KAFKA-2301) Deprecate ConsumerOffsetChecker

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-2301: -- Attachment: KAFKA-2301_2015-07-01_17:46:34.patch Deprecate ConsumerOffsetChecker

[jira] [Commented] (KAFKA-2301) Deprecate ConsumerOffsetChecker

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611253#comment-14611253 ] Ashish K Singh commented on KAFKA-2301: --- Updated reviewboard

[jira] [Created] (KAFKA-2307) Drop ConsumerOffsetChecker completely

2015-07-01 Thread Ashish K Singh (JIRA)
Ashish K Singh created KAFKA-2307: - Summary: Drop ConsumerOffsetChecker completely Key: KAFKA-2307 URL: https://issues.apache.org/jira/browse/KAFKA-2307 Project: Kafka Issue Type: Sub-task

Deprecation of ConsumerOffsetChecker

2015-07-01 Thread Ashish Singh
Hey Guys, In last KIP hangout, we decided on following path for deprecating ConsumerOffsetChecker. 1. Add deprecation warning to the tool for one release. In this case, the warning will be added in 0.9.0. 2. Drop it completely in next release, 0.9.1. I have updated the (KIP-23){

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-01 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 2, 2015, 1:38 a.m.) Review request for kafka and Joel Koshy.

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1367: -- Attachment: KAFKA-1367_2015-07-01_17:23:14.patch Broker topic metadata not kept in sync with

[jira] [Commented] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611233#comment-14611233 ] Ashish K Singh commented on KAFKA-1367: --- Updated reviewboard

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35820/ --- (Updated July 2, 2015, 12:23 a.m.) Review request for kafka. Bugs:

Re: Review Request 35820: Patch for KAFKA-1367

2015-07-01 Thread Ashish Singh
On June 30, 2015, 4:42 p.m., Jun Rao wrote: Thanks for the patch. A few comments below. Also, could we add a unit test for this? Thanks for the review Jun! Addressed your concerns and added a test that re-produces the issue and verifies the fix. - Ashish

[jira] [Updated] (KAFKA-1367) Broker topic metadata not kept in sync with ZooKeeper

2015-07-01 Thread Ashish K Singh (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish K Singh updated KAFKA-1367: -- Status: Patch Available (was: In Progress) Broker topic metadata not kept in sync with

Re: Review Request 35850: Patch for KAFKA-2301

2015-07-01 Thread Ashish Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35850/ --- (Updated July 2, 2015, 12:46 a.m.) Review request for kafka. Bugs:

[jira] [Updated] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-01 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya A Auradkar updated KAFKA-2205: - Attachment: KAFKA-2205_2015-07-01_18:38:18.patch Generalize TopicConfigManager to handle

[jira] [Commented] (KAFKA-2205) Generalize TopicConfigManager to handle multiple entity configs

2015-07-01 Thread Aditya A Auradkar (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14611309#comment-14611309 ] Aditya A Auradkar commented on KAFKA-2205: -- Updated reviewboard

Re: Review Request 34554: Patch for KAFKA-2205

2015-07-01 Thread Aditya Auradkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34554/ --- (Updated July 2, 2015, 1:39 a.m.) Review request for kafka and Joel Koshy.